----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55687/#review162317 -----------------------------------------------------------
Ship it! Ship It! - Kevin Duling On Jan. 18, 2017, 5:35 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55687/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2017, 5:35 p.m.) > > > Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund. > > > Repository: geode > > > Description > ------- > > * renamed the CliUtils.findAllMatchingServers to findMembersOrThrow to better > describe the behavior > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/management/internal/cli/CliUtil.java > 5b9a6bd63350dd753c66fd25e6058ddea45f9325 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConfigCommands.java > 5154b75e85a42e6d97f5563effe3a7600369126a > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java > 7df4112950cefcc1ae18bdd88cb752cdec5b7de1 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java > f076cec670a4c787fbe4002edfdacde4b025d1bf > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java > 14114cff2febf0e1ba7ae67427549ad4fd19ed85 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DurableClientCommands.java > 053f3ebcc74638f992854cdd96d9c586aa33818a > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/FunctionCommands.java > 9a9ece952110e90b32e65cbff8ea2319779c4aff > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java > bc436ba40e107b931e8d0d10082e26cf068dd56b > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommands.java > 88a9919802f3d32822f20d3a1c8cfcc4ffa5a6c4 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueueCommands.java > 095bd68f54d0f06d9f9439fcaffbca72e49083fc > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/RegionCommands.java > 78a28d68ea7aa75ab2cda0c01b5a567e3d0d9475 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/WanCommands.java > cbf589185e94345be6fd64ebd630f76e84cc2a09 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/CliUtilDUnitTest.java > d7d59b71cd54ca23c716e72da413bae6a05e75fd > > geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfig.java > c2d511d1c4d34aea434751c2bb5b7e9b924482ad > > geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigDeployJarDUnitTest.java > 51a77d2f4454a772251039a465ab00655a9bea98 > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java > 13442fd68ce2855561fc724bf73cd8c21d2317af > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java > 6a5a1e09c03b9a5362e44fd6fe55a6e6181ea17c > > Diff: https://reviews.apache.org/r/55687/diff/ > > > Testing > ------- > > precheckin successful > > > Thanks, > > Jinmei Liao > >
