----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55965/#review163059 -----------------------------------------------------------
Ship it! Ship It! - Kevin Duling On Jan. 25, 2017, 3:58 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55965/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2017, 3:58 p.m.) > > > Review request for geode, Bruce Schuchardt, Jared Stewart, and Kevin Duling. > > > Bugs: GEODE-1930 > https://issues.apache.org/jira/browse/GEODE-1930 > > > Repository: geode > > > Description > ------- > > This is for a follow-up commit to my latest commit for GEODE-1930. I had > fixed a couple Exceptions strings in DUnitLauncher. When I merged that commit > to develop, it combined in a strange way with a commit that Bruce made. This > is my attempt to fix up DUnitLauncher back to what Bruce had. The other > option is to revert my commit and repeat the merge but leave out > DUnitLauncher. > > For reference, here are the two constants used in the modified code: > ```java > static final long STARTUP_TIMEOUT = 120 * 1000; > private static final String STARTUP_TIMEOUT_MESSAGE = > "VMs did not start up within " + (STARTUP_TIMEOUT / 1000) + " seconds"; > ``` > > > Diffs > ----- > > > geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java > 92a7c46950dd9d0a0029ba511b187e36169accbc > > Diff: https://reviews.apache.org/r/55965/diff/ > > > Testing > ------- > > precheckin in progress > > > Thanks, > > Kirk Lund > >
