----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56459/ -----------------------------------------------------------
(Updated Feb. 8, 2017, 4:21 p.m.) Review request for geode, Jinmei Liao, Jared Stewart, and Kirk Lund. Changes ------- Removed login(username, password) in favor of login(credentials) rather than deprecating because this is an internal API. Repository: geode Description ------- GEODE-2247: GFSH connect over HTTP without credentials should fail earlier Diffs (updated) ----- geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java 6507295cd28b5f45f4de164c86c176f467a20f6e geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java 727a1ce0c1c99edd5cd7299ddfbbcda4ca9a664f geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java 79c8c2717b3523837f01939cf67b3b38169c856b geode-core/src/main/java/org/apache/geode/management/internal/web/shell/AbstractHttpOperationInvoker.java fa052489772e3e03eb865d17dbbcb7e227813c42 geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/auth/AbstractGMSAuthenticatorTestCase.java 65c38ad261ba759d5022fad4c1eb20249e71d69d geode-core/src/test/java/org/apache/geode/management/internal/security/IntegratedSecurityServiceWithIniFileJUnitTest.java a300880d1d4a221d03c480df94b5b652175814f7 geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/GeodeAuthenticationProvider.java c8b5cf0827032ae3148bfdeb1777fb8fc3b2d85e Diff: https://reviews.apache.org/r/56459/diff/ Testing ------- Log of UX on https://issues.apache.org/jira/browse/GEODE-2247 precheckin running Thanks, Kevin Duling