Re: [gemfire-dev] New Client-Server Protocol Proposal

2017-05-01 Thread Hitesh Khamesra
>>>The message header currently is specified to have things like correlation id, isPartial message, and also metdatadata about whether the key or the value is JSON. IsPartialMessage: This flag gives us ability to send partial message without serializing the whole key-value(request). lets say I exe

Re: [gemfire-dev] New Client-Server Protocol Proposal

2017-05-02 Thread Hitesh Khamesra
Absolutely its a implementation detail. JSON: Surely we can consider ValueHeader. But then every client(and message) needs to send that. Using metadata its a optional. From: Dan Smith To: Udo Kohlmeyer Cc: dev@geode.apache.org Sent: Tuesday, May 2, 2017 11:39 AM Subject: Re: [gemfire

Re: [gemfire-dev] New Client-Server Protocol Proposal

2017-05-03 Thread Hitesh Khamesra
We have version at api(put, get etc) level https://cwiki.apache.org/confluence/display/GEODE/Message+Structure+and+Definition#MessageStructureandDefinition-RequestHeader. The client will connect to gemfire server by sending the "byte". That can be treated for message serialization. From: M

Re: [gemfire-dev] New Client-Server Protocol Proposal

2017-05-03 Thread Hitesh Khamesra
Here are the few things we need to consider.. 1. key, value, callbackarg can be required to interpret as JSON-to-pdx2. client calls "get/getall" api and want return value as JSON. Value was serialized as pdx.3. This behavior should be optional, if possible no overhead for others.4. "putAll api"

Re: New Client-Server Protocol Proposal

2017-05-03 Thread Hitesh Khamesra
ghts? Thanks.Hitesh. From: Hitesh Khamesra To: "dev@geode.apache.org" Sent: Wednesday, May 3, 2017 10:01 AM Subject: Re: [gemfire-dev] New Client-Server Protocol Proposal Here are the few things we need to consider.. 1. key, value, callbackarg can be required to interpret

Re: [gemfire-dev] New Client-Server Protocol Proposal

2017-05-03 Thread Hitesh Khamesra
o json or vice-versa. Any thoughts? Thanks. HItesh ________ From: Hitesh Khamesra To: "dev@geode.apache.org" Sent: Wednesday, May 3, 2017 10:01 AM Subject: Re: [gemfire-dev] New Client-Server Protocol Proposal Here are the few things we need to consider..

Re: [gemfire-dev] New Client-Server Protocol Proposal

2017-05-03 Thread Hitesh Khamesra
Good point Dan !! that needs to document. From: Dan Smith To: dev@geode.apache.org Sent: Wednesday, May 3, 2017 5:31 PM Subject: Re: [gemfire-dev] New Client-Server Protocol Proposal Okay but how do I has an implementer of a driver know what messages need an event id and which

Re: [gemfire-dev] New Client-Server Protocol Proposal

2017-05-04 Thread Hitesh Khamesra
ssages using "correlationId" ? Thanks. HItesh From: Anthony Baker To: dev@geode.apache.org Cc: Hitesh Khamesra Sent: Wednesday, May 3, 2017 5:42 PM Subject: Re: [gemfire-dev] New Client-Server Protocol Proposal > On May 3, 2017, at 1:33 PM, Galen M O

Re: [gemfire-dev] New Client-Server Protocol Proposal

2017-05-04 Thread Hitesh Khamesra
tand this better. Thanks. Hitesh ________ From: Anthony Baker To: Hitesh Khamesra Cc: "dev@geode.apache.org" Sent: Thursday, May 4, 2017 11:20 AM Subject: Re: [gemfire-dev] New Client-Server Protocol Proposal There would be one Message containing a single Me

Re: [gemfire-dev] New Client-Server Protocol Proposal

2017-05-04 Thread Hitesh Khamesra
posal Sent from my iPhone > On May 4, 2017, at 12:03 PM, Hitesh Khamesra > wrote: > > And len 0 would indicate end of the message? > > > a. Now these two chunks will go continuous. They would appear continuous to the object serialization layer. > >

Re: [gemfire-dev] New Client-Server Protocol Proposal

2017-05-04 Thread Hitesh Khamesra
can read field offset from serialized stream, and then can read field value. Though, I can imagine with the help of pdxType, we can interpret serialized stream. From: Jacob Barrett To: dev@geode.apache.org; Hitesh Khamesra Cc: Anthony Baker Sent: Thursday

Re: [gemfire-dev] New Client-Server Protocol Proposal

2017-05-05 Thread Hitesh Khamesra
chunked input stream and can de-serialize the object as it is coming (DataSerializable.fromData(ChunkedStream)). From: Jacob Barrett To: dev@geode.apache.org; Hitesh Khamesra Cc: Anthony Baker Sent: Friday, May 5, 2017 7:29 AM Subject: Re: [gemfire-dev] New Client-Server Protocol

Re: Review Request 59057: GEODE-2193 a member is kicked out immediately after joining

2017-05-08 Thread Hitesh Khamesra
Then "receiver1" becomes coordinator(legal coordinator) by removing current coordinator. Now if current coordinator sends new view then cluster just ignores that view, as cluster has new-view by "receiver1". - Hitesh Khamesra On May 8, 201

Re: Review Request 59057: GEODE-2193 a member is kicked out immediately after joining

2017-05-08 Thread Hitesh Khamesra
w view by removing current coordinator. - Hitesh Khamesra On May 8, 2017, 5:23 p.m., Bruce Schuchardt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 59057: GEODE-2193 a member is kicked out immediately after joining

2017-05-08 Thread Hitesh Khamesra
> On May 8, 2017, 5:44 p.m., Hitesh Khamesra wrote: > > How about sending pending joinRequest(new member) with shutdown message. And let new coordinator take care of it. - Hitesh --- This is an automatically generated e-mail.

Re: Review Request 59034: GEODE-2352 Document that REST API requires two properties

2017-05-08 Thread Hitesh Khamesra
) <https://reviews.apache.org/r/59034/#comment247338> This looks good to me. ship it - Hitesh Khamesra On May 5, 2017, 10:32 p.m., Dave Barnes wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 59071: GEODE-2875 shutdown is taking as long as 20 seconds

2017-05-08 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59071/#review174234 --- Ship it! Ship It! - Hitesh Khamesra On May 8, 2017, 10:07

Re: Review Request 59237: GEODE-2875 shutdown is taking as long as 20 seconds

2017-05-12 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59237/#review174831 --- Ship it! Ship It! - Hitesh Khamesra On May 12, 2017, 6:29

Review Request 59239: Allow a locator host to be taken off line and replaced with a different machine having the same host name

2017-05-12 Thread Hitesh Khamesra
-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java 385569c Diff: https://reviews.apache.org/r/59239/diff/1/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 59239: Allow a locator host to be taken off line and replaced with a different machine having the same host name

2017-05-12 Thread Hitesh Khamesra
n automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59239/#review174861 --- On May 12, 2017, 7:01 p.m., Hitesh Khamesra wrote: > > --- > This is an a

Re: Review Request 59239: Allow a locator host to be taken off line and replaced with a different machine having the same host name

2017-05-15 Thread Hitesh Khamesra
f/1-2/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 59242: GEODE-2915 Messages rejected due to unknown "vmkind"

2017-05-15 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59242/#review174998 --- Ship it! Ship It! - Hitesh Khamesra On May 12, 2017, 8:28

Re: Review Request 58937: GEODE-2865 data loss in initial-image replication with multicast

2017-05-15 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58937/#review175012 --- Ship it! Ship It! - Hitesh Khamesra On May 5, 2017, 4:57

Re: Review Request 59239: Allow a locator host to be taken off line and replaced with a different machine having the same host name

2017-05-15 Thread Hitesh Khamesra
ionSourceImplJUnitTest.java > > Lines 155 (patched) > > <https://reviews.apache.org/r/59239/diff/2/?file=1718525#file1718525line155> > > > > Is floc2 necessary? It just to test the logic. - Hitesh ---

Re: Review Request 59239: Allow a locator host to be taken off line and replaced with a different machine having the same host name

2017-05-15 Thread Hitesh Khamesra
ogic. - Hitesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59239/#review174980 --- On May 15, 2017, 6:33 p.m., Hitesh Khamesra wrote: > > --

Re: Review Request 59239: Allow a locator host to be taken off line and replaced with a different machine having the same host name

2017-05-15 Thread Hitesh Khamesra
f/2-3/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 59239: Allow a locator host to be taken off line and replaced with a different machine having the same host name

2017-05-15 Thread Hitesh Khamesra
de I will change that. Thanks Bruce and Udo. - Hitesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59239/#review175022 ------- On May 15, 2017, 8:46 p.m., Hitesh Khamesra wrote: > > ---

Re: Review Request 59242: GEODE-2915 Messages rejected due to unknown "vmkind"

2017-05-16 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59242/#review175149 --- Ship it! Ship It! - Hitesh Khamesra On May 15, 2017, 11:13

Re: Review Request 59422: GEODE-2954 Old client gets null memberID in cache listener

2017-05-24 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59422/#review175989 --- Ship it! Ship It! - Hitesh Khamesra On May 19, 2017, 10:48

Review Request 59546: GEODE-2940 Remove verification of locator host on start

2017-05-24 Thread Hitesh Khamesra
lysis/excludedClasses.txt 9cff80d geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java d6d5d7c Diff: https://reviews.apache.org/r/59546/diff/1/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 59546: GEODE-2940 Remove verification of locator host on start

2017-05-25 Thread Hitesh Khamesra
lysis/excludedClasses.txt 9cff80d geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java d6d5d7c Diff: https://reviews.apache.org/r/59546/diff/1/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 59546: GEODE-2940 Remove verification of locator host on start

2017-05-25 Thread Hitesh Khamesra
org/r/59546/diff/1-2/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 59546: GEODE-2940 Remove verification of locator host on start

2017-05-25 Thread Hitesh Khamesra
JUnitTest.java Lines 346 (patched) <https://reviews.apache.org/r/59546/#comment249452> If locator host is still not avialable then server won't be able to join the cluster. - Hitesh Khamesra On May 25, 2017, 7:06 p.m., Hitesh Khamesra wrote: > >

Re: Review Request 59819: GEODE-3034 java.lang.ArrayIndexOutOfBoundsException: 0 on auto-reconnect attempt with multicast enabled

2017-06-06 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59819/#review177091 --- Ship it! Ship It! - Hitesh Khamesra On June 5, 2017, 10:14

Re: Review Request 59757: GEODE-3024 race condition between server and restarted locator preparing membership views

2017-06-06 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59757/#review177093 --- Ship it! Ship It! - Hitesh Khamesra On June 2, 2017, 7:18

Re: Review Request 59863: Removing obsolete SSL handling in `AcceptorImpl.accept` catch block

2017-06-07 Thread Hitesh Khamesra
/sockets/AcceptorImpl.java Line 1252 (original) <https://reviews.apache.org/r/59863/#comment250791> Do we need to move this code in another thread? - Hitesh Khamesra On June 6, 2017, 10:19 p.m., Brian Rowe wrote: > > ---

Re: Review Request 59850: GEODE-3023: TcpServer thread can be blocked in processRequest

2017-06-07 Thread Hitesh Khamesra
/apache/geode/distributed/internal/tcpserver/TcpServer.java Line 171 (original) <https://reviews.apache.org/r/59850/#comment250793> Is that code moved inside/will never happen? - Hitesh Khamesra On June 7, 2017, 11:32 p.m., Udo Kohlmeyer

Review Request 59924: Reverted GEODE-2804 (Allow a locator host to be taken off line and replaced with a different machine having the same host name)

2017-06-08 Thread Hitesh Khamesra
rg/apache/geode/management/internal/configuration/utils/ClusterConfigurationStatusRetriever.java 9f35edd geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java 9ceb461 Diff: https://reviews.apache.org/r/59924/diff/1/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 59894: GEODE-3041 CI failure: DistributedMemberDUnitTest.testGroupsInAllVMs fails intermittently

2017-06-08 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59894/#review177350 --- Ship it! Ship It! - Hitesh Khamesra On June 7, 2017, 9:56

Re: Review Request 60217: GEODE-2995: adding in protocol handler for protobuf messages

2017-06-21 Thread Hitesh Khamesra
0217/#comment252540> How about keeping two byte[] here. One for true and one for false. geode-protobuf/src/main/java/org/apache/geode/serialization/codec/ByteCodec.java Lines 24 (patched) <https://reviews.apache.org/r/60217/#comment252541> Just return first byte? - Hitesh Kha

Re: Review Request 60217: GEODE-2995: adding in protocol handler for protobuf messages

2017-06-21 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60217/#review178527 --- Ship it! Ship It! - Hitesh Khamesra On June 21, 2017, 7:01

Review Request 60312: GEODE-2804 Cache InetAddress if configure host as ip string.

2017-06-21 Thread Hitesh Khamesra
/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java 6d75064 gradle/dependency-versions.properties 183dafc Diff: https://reviews.apache.org/r/60312/diff/1/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 60106: GEODE-3052 Restarting 2 locators within 1s of each other causes potential locator split brain

2017-06-21 Thread Hitesh Khamesra
/membership/gms/locator/GMSLocator.java Lines 235 (patched) <https://reviews.apache.org/r/60106/#comment252637> we are setting -1 viewid for recorded view while recovery. Thus do we need "usingRecoveredView" flag here? - Hitesh Khamesra On June 19, 2017, 4:09 p.m., Bruce

Re: Review Request 60106: GEODE-3052 Restarting 2 locators within 1s of each other causes potential locator split brain

2017-06-21 Thread Hitesh Khamesra
/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java Line 79 (original), 79 (patched) <https://reviews.apache.org/r/60106/#comment252666> do we want fine level log here? - Hitesh Khamesra On June 21, 2017, 10:24 p.m.

Re: Review Request 60106: GEODE-3052 Restarting 2 locators within 1s of each other causes potential locator split brain

2017-06-21 Thread Hitesh Khamesra
/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java Line 79 (original), 79 (patched) <https://reviews.apache.org/r/60106/#comment252666> do we want fine level log here? - Hitesh Khamesra On June 21, 2017, 10:24 p.m.

Re: Review Request 60106: GEODE-3052 Restarting 2 locators within 1s of each other causes potential locator split brain

2017-06-21 Thread Hitesh Khamesra
reviewboard. geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java (Diff revision 2) 235 if (v == null) { we are setting -1 viewid for recorded view while recovery. Thus do we need "usingRecoveredView" flag here? - Hites

Re: Review Request 60106: GEODE-3052 Restarting 2 locators within 1s of each other causes potential locator split brain

2017-06-21 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60106/#review178617 --- Ship it! Ship It! - Hitesh Khamesra On June 21, 2017, 10:24

Re: Review Request 60394: GEODE-3075 and GEODE-2995: merge of new protobuf protocol work.

2017-06-23 Thread Hitesh Khamesra
reviews.apache.org/r/60394/ > --- > > (Updated June 23, 2017, 5:52 p.m.) > > > Review request for geode, Alexander Murmann, Bruce Schuchardt, Hitesh > Khamesra, Udo Kohlmeyer, and Brian Rowe. > > > Repository: geode >

Re: Review Request 60442: GEODE-3130: Refactoring AcceptorImpl communication mode switch

2017-06-26 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60442/#review178916 --- Ship it! Ship It! - Hitesh Khamesra On June 26, 2017, 6:31

Re: Review Request 60446: Events do not get removed from the client queue for 1.0 clients

2017-06-26 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60446/#review178936 --- Ship it! Ship It! - Hitesh Khamesra On June 26, 2017, 10:24

New Apache commons-validato.jar

2017-06-27 Thread Hitesh Khamesra
We are planning to include Apache commons-validator_1.6.jar in Geode. As part of GEODE-2804, we need to validate whether host string is configured as IP or not. Please let us know if there is any issue with it. Thanks. Hitesh

Re: Review Request 60451: GEODE-2996: adding Put handler

2017-06-27 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60451/#review179015 --- Ship it! Ship It! - Hitesh Khamesra On June 27, 2017, 1:20

Re: Review Request 60312: GEODE-2804 Cache InetAddress if configure host as ip string.

2017-06-27 Thread Hitesh Khamesra
a dbc2cc6 geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java 6d75064 gradle/dependency-versions.properties 6a730a4 Diff: https://reviews.apache.org/r/60312/diff/2/ Changes: https://reviews.apache.org/r/60312/diff/1-2/ Testing --- Thank

Re: Review Request 60507: GEODE-3145: add geode-protobuf code to the geode jar

2017-06-28 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60507/#review179135 --- Ship it! Ship It! - Hitesh Khamesra On June 28, 2017, 5:26

Re: Review Request 60312: GEODE-2804 Cache InetAddress if configure host as ip string.

2017-06-28 Thread Hitesh Khamesra
dependency-versions.properties 6a730a4 Diff: https://reviews.apache.org/r/60312/diff/3/ Changes: https://reviews.apache.org/r/60312/diff/2-3/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 60550: GEODE-3154: add geode-protobuf to expected_jars.txt

2017-06-29 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60550/#review179309 --- Ship it! Ship It! - Hitesh Khamesra On June 29, 2017, 9:39

Re: Review Request 60312: GEODE-2804 Cache InetAddress if configure host as ip string.

2017-06-29 Thread Hitesh Khamesra
es 6a730a4 Diff: https://reviews.apache.org/r/60312/diff/3/ Testing --- File Attachments (updated) Latest diff https://reviews.apache.org/media/uploaded/files/2017/06/29/45369a6d-34d0-42dd-96bc-a1c009d00824__GEODE-2804v2.patch Thanks, Hitesh Khamesra

Review Request 60856: GEODE-3052 Need to reset isCoordinator flag in GMSLocator.

2017-07-13 Thread Hitesh Khamesra
.java 9591673 geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java d8c12e2 Diff: https://reviews.apache.org/r/60856/diff/1/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 60856: GEODE-3052 Need to reset isCoordinator flag in GMSLocator.

2017-07-14 Thread Hitesh Khamesra
https://reviews.apache.org/r/60856/diff/1-2/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 60856: GEODE-3052 Need to reset isCoordinator flag in GMSLocator.

2017-07-14 Thread Hitesh Khamesra
automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60856/#review180497 --- On July 14, 2017, 5:06 p.m., Hitesh Khamesra wrote: > > --- > Thi

Re: [VOTE] Apache Geode release - v1.2.0 RC2

2017-07-14 Thread Hitesh Khamesra
+1 same as Dan!! On Wednesday, July 12, 2017, 1:38:44 PM PDT, Dan Smith wrote: +0 I ran geode-release-check against this project. It all looks good except that the md5sum and sha256 sums tasks don't pass because the .md5 and .sha256 file

Review Request 61411: GEODE-3286 Failing to cleanup connections from ConnectionTable receiver table (corrected "stopped" check in previous fix)

2017-08-03 Thread Hitesh Khamesra
e/src/test/java/org/apache/geode/internal/tcp/ConnectionTableTest.java 312c64d Diff: https://reviews.apache.org/r/61411/diff/1/ Testing --- Thanks, Hitesh Khamesra

Review Request 61420: GEODE-3307 CI failure: Uncaught exception in thread Thread[Geode Membership View Creator

2017-08-03 Thread Hitesh Khamesra
rship/GMSJoinLeave.java 40a4254 Diff: https://reviews.apache.org/r/61420/diff/1/ Testing --- Thanks, Hitesh Khamesra

Re: Review Request 61411: GEODE-3286 Failing to cleanup connections from ConnectionTable receiver table (corrected "stopped" check in previous fix)

2017-08-03 Thread Hitesh Khamesra
------ Thanks, Hitesh Khamesra

Re: Review Request 61816: GEODE-3409 Protobuf Client Can't Connect Once Connection Limit Has Been Reached, Even After Connections Closed

2017-08-23 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61816/#review183615 --- Ship it! Ship It! - Hitesh Khamesra On Aug. 23, 2017, 3:47

Re: Review Request 61829: GEODE-3408 Flood of EOF warnings

2017-08-23 Thread Hitesh Khamesra
/sockets/GenericProtocolServerConnection.java Line 68 (original), 72 (patched) <https://reviews.apache.org/r/61829/#comment259684> Will this warning be printed every time when we close the socket? - Hitesh Khamesra On Aug. 22, 2017, 11:41 p.m., Bruce Schuchardt

Re: Review Request 61829: GEODE-3408 Flood of EOF warnings

2017-08-23 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61829/#review183634 --- Ship it! Ship It! - Hitesh Khamesra On Aug. 22, 2017, 11:41

Re: Review Request 61950: GEODE-3519 servers are not locking on remove or invalidate ops initiated by clients

2017-08-28 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61950/#review183950 --- Ship it! Ship It! - Hitesh Khamesra On Aug. 28, 2017, 4:09

Re: Review Request 61978: GEODE-3059: LoadMonitor.connectionClosed incrementing statistics only for client-server connection

2017-09-01 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61978/#review184391 --- Ship it! Ship It! - Hitesh Khamesra On Aug. 30, 2017, 8:48

Re: Review Request 62088: GEODE-3249 Validate internal client/server messages

2017-09-05 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62088/#review184565 --- Ship it! Ship It! - Hitesh Khamesra On Sept. 5, 2017, 5:57

Re: Review Request 62088: GEODE-3249 Validate internal client/server messages

2017-09-08 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62088/#review184986 --- Ship it! Ship It! - Hitesh Khamesra On Sept. 7, 2017, 5:43

Re: New client/server protocol - seeking feedback

2017-10-02 Thread Hitesh Khamesra
+1 On Monday, October 2, 2017, 11:14:55 AM PDT, Jacob Barrett wrote: A change to a message should just be a new message, no need to version it. Clients and severs could negotiate the messages they support or attempt the message they support and fallback to an alternative if the server r

Re: [VOTE] C++ standardize on return values only

2017-10-03 Thread Hitesh Khamesra
Tuple option. Sent from Yahoo Mail on Android On Tue, Oct 3, 2017 at 4:27 PM, Jacob Barrett wrote: Voting on the conversation around C++ return values vs. out parameters. This vote is to adopt the standard of return values over the use of out parameters. On functions that must return more

Re: [DISCUSS] Release branch for 1.1.0

2017-02-03 Thread Hitesh Khamesra
: Hitesh Khamesra To: "dev@geode.apache.org" Sent: Thursday, February 2, 2017 10:33 AM Subject: Re: [DISCUSS] Release branch for 1.1.0 We want to fix one more issue in this release  GEODE-2413 peer-to-peer authentication: Peer need to re-authenticate coordinator while accepting vi

Re: [DISCUSS] Release branch for 1.1.0

2017-02-03 Thread Hitesh Khamesra
wrote: > +1 for pushing out GEODE-2413. I think what Anthony said makes sense. > > -Dan > > On Fri, Feb 3, 2017 at 2:32 PM, Anthony Baker wrote: > > > > > > On Feb 3, 2017, at 2:03 PM, Hitesh Khamesra > > > wrote: > > > > > >  GEODE

[VOTE] RC1: Apache Geode release - v1.1.0

2017-02-03 Thread Hitesh Khamesra
All, This is the first release candidate of the first release for Apache Geode, version 1.1.0. Thanks to all the community members. It fixes the following issues:    https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318420&version=12338352 *** Please download, test and vote b

Re: Fwd: Build failed in Jenkins: Geode-nightly #738

2017-02-06 Thread Hitesh Khamesra
Will disable it  testSSLEnabledLocatorDiesWhenConnectingToNonSSLLocator test. -Hitesh From: Kirk Lund To: geode Sent: Monday, February 6, 2017 9:05 AM Subject: Fwd: Build failed in Jenkins: Geode-nightly #738 Can someone please do one of the following (I don't have build job permi

Re: [VOTE] RC1: Apache Geode release - v1.1.0

2017-02-06 Thread Hitesh Khamesra
/ > configuration/group2.jar > > > If tests require binary files, those files should be generated from source > during the build. > > Anthony > > > On Feb 3, 2017, at 4:11 PM, Hitesh Khamesra > wrote: > > > > All, > > > > This is the first rel

Re: Nightly build broken

2017-02-07 Thread Hitesh Khamesra
Thanks Dan. Lets merge this fix into 1.1 release branch. -Hitesh From: Dan Smith To: dev@geode.apache.org Sent: Tuesday, February 7, 2017 1:12 PM Subject: Re: Nightly build broken Actually, now that I think about it GEODE-2434 was probably the cause of these backwards compatibility

[VOTE] RC2: Apache Geode release - v1.1.0

2017-02-09 Thread Hitesh Khamesra
All, This is the second release candidate of the first release for Apache Geode, version 1.1.0. Thanks to all the community members. It fixes the following issues:    https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318420&version=12338352 *** Please download, test and vote

Re: Review Request 56520: Update dependency versions

2017-02-09 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56520/#review165033 --- Ship it! Ship It! - Hitesh Khamesra On Feb. 10, 2017, 12:07

Re: Review Request 56556: GEODE-2454: use DistributedMember.getId() for memberId assertions

2017-02-10 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56556/#review165168 --- Ship it! Ship It! - Hitesh Khamesra On Feb. 10, 2017, 7:30

Re: Review Request 56564: GEODE-2449: Moved Redis out of Geode-core into its own module

2017-02-10 Thread Hitesh Khamesra
/GeodeRedisService.java (line 22) <https://reviews.apache.org/r/56564/#comment236990> Make this some generic interface which can be used by any other. Next is mamcache .. - Hitesh Khamesra On Feb. 10, 2017, 9:39 p.m., Udo Kohlmeyer

Re: [VOTE] RC2: Apache Geode release - v1.1.0

2017-02-10 Thread Hitesh Khamesra
spark-connector/project/Dependencies.scala:    val geode = "org.apache.geode" % "geode-core" % "1.0.0-incubating" excludeAll(ExclusionRule(organization = "org.jboss.netty" From: Galen M O'Sullivan To: dev@geode.apache.org Cc: Hitesh Khamesra

Re: Review Request 56626: GEODE-2479 Remove docs reference to gemstone.com package

2017-02-13 Thread Hitesh Khamesra
/auto_serialization.html.md.erb <https://reviews.apache.org/r/56626/#comment237267> I thought this info is good to keep; Do we have similar info somewhere else? - Hitesh Khamesra On Feb. 14, 2017, 12:22 a.m., Karen Miller wrote: > > ---

Re: Review Request 56626: GEODE-2479 Remove docs reference to gemstone.com package

2017-02-13 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56626/#review165423 --- Ship it! Ship It! - Hitesh Khamesra On Feb. 14, 2017, 12:22

[RESULT][VOTE] RC2: Apache Geode 1.1.0 release

2017-02-14 Thread Hitesh Khamesra
The vote passes with 6 +1 and 2 +0 votes: Jinmei Liao  +1 Udo Kohlmeyer    +1 William Markito  +1 Dan Smith    +1 Xiaojian Zhou    +1 Anthony Baker    +1 Kenneth Howe +0 Karen Miller +0 Mail thread: http://mail-ar

Merge conflict from release/1.1.0 branch to develop

2017-02-14 Thread Hitesh Khamesra
I was merging release/1.1.0 branch to develop to see if something we need to pull from there. Generally we don't expect anything from it but it is showing some conflicts. Can you(Bruce, Jenmei, Jared) please look following files. -bash-4.2$ git merge --no-ff release/1.1.0Auto-merging gradle.prop

GeodeRedisAdapter improvments/feedback

2017-02-14 Thread Hitesh Khamesra
Current GeodeRedisAdapter implementation is based on https://cwiki.apache.org/confluence/display/GEODE/Geode+Redis+Adapter+Proposal. We are looking for some feedback on Redis commands and their mapping to geode region. 1. Redis Type String   a. Usage Set k1 v1   b. Current implementation creates

Re: Propose a new implementation for collections in Geode transaction (GEODE-2392)

2017-02-14 Thread Hitesh Khamesra
+1 for supporting repeatable read semantics consistently. throw Unsupportedexception if some apis are not supported inside tx. -Hitesh. From: Anthony Baker To: dev@geode.apache.org Sent: Monday, February 13, 2017 8:08 AM Subject: Re: Propose a new implementation for collections in Geode

Re: GeodeRedisAdapter improvments/feedback

2017-02-14 Thread Hitesh Khamesra
ou want to know top 10 tweets which are trending then probably you want use partition-region for "sorted-set". From: Jason Huynh To: dev@geode.apache.org; "u...@geode.apache.org" ; Hitesh Khamesra Sent: Tuesday, February 14, 2017 3:15 PM Subject: Re: GeodeRed

Re: GeodeRedisAdapter improvments/feedback

2017-02-14 Thread Hitesh Khamesra
eir >>>> list named ++^^/## throws an error. Your suggestion to make it a key >>>> rather than a region solves this. Furthermore, creating a new region every >>>> time a new Redis collection is created is going to be slow. I’m not sure >>>> why a region was created bu

Re: GeodeRedisAdapter improvments/feedback

2017-02-15 Thread Hitesh Khamesra
l want PARTITION but Customer B will want > PARTITION_REDUNDANT_EXPIRATION_PERSISTENT.  I wonder if we can consider a > geode> create region —redisType=PARTITION_REDUNDANT_EXPIRATION_PERSISTENT > that makes _all_ Redis regions of that type? > > > > On Feb 14, 2017, at 5:36 PM,

[ANNOUNCE] Apache Geode release 1.1.0

2017-02-15 Thread Hitesh Khamesra
The Apache Geode team is proud to announce Apache Geode release version 1.1.0 Apache *Geode* is a data management platform that provides a database-like consistency model, reliable transaction processing and a shared-nothing architecture to maintain very low latency performance with high concurren

Re: GeodeRedisAdapter improvments/feedback

2017-02-16 Thread Hitesh Khamesra
Thanks for all your feedback. Dan, your third option looks good ( cost of memory/oql need to consider). But this should solves popular redis  use cases "Top k/ multiple leaderboards use cases, where subset of users/entity involves". In general, Redis brings beautiful user apis which is very handf

Re: for discussion: separate website into its own repo+1

2017-02-16 Thread Hitesh Khamesra
+1 Sent from Yahoo Mail on Android On Thu, Feb 16, 2017 at 5:06 PM, Anthony Baker wrote: Yes, please.  Let’s call the repo geode-site.  Use two branches:  master and asf-site.  If we can auto-build and push to asf-site that would be awesome. Anthony > On Feb 16, 2017, at 4:38 PM, Dan Sm

Re: GeodeRedisAdapter improvments/feedback

2017-02-17 Thread Hitesh Khamesra
Right.. Sent from Yahoo Mail on Android On Fri, Feb 17, 2017 at 8:05 AM, Wes Williams wrote: I'm not clear on the reference to "I like the idea of first class data structures like Lists and Sorted Sets." Is the suggestion here to extend Geode to not only support a distributed ConcurrentHa

Re: [GitHub] geode pull request #404: Geode 2469

2017-02-21 Thread Hitesh Khamesra
Thanks Gregory.  I will look this further. From: Gregory Green To: dev@geode.apache.org Sent: Tuesday, February 21, 2017 12:21 PM Subject: Re: [GitHub] geode pull request #404: Geode 2469 Hello Everyone, I just wanted to clarify something with this pull request. The main benefit

Re: Review Request 56986: GEODE-2497 surprise members are never timed out during startu

2017-02-23 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56986/#review166579 --- Ship it! Ship It! - Hitesh Khamesra On Feb. 23, 2017, 4:17

Re: Review Request 56999: GEODE-2534 concurrently started locators fail to create a unified system

2017-02-23 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56999/#review166616 --- Ship it! Ship It! - Hitesh Khamesra On Feb. 23, 2017, 9:50

  1   2   3   4   5   6   >