----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59894/#review177350 -----------------------------------------------------------
Ship it! Ship It! - Hitesh Khamesra On June 7, 2017, 9:56 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59894/ > ----------------------------------------------------------- > > (Updated June 7, 2017, 9:56 p.m.) > > > Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh > Khamesra, Udo Kohlmeyer, and Brian Rowe. > > > Bugs: GEODE-3041 > https://issues.apache.org/jira/browse/GEODE-3041 > > > Repository: geode > > > Description > ------- > > When shutting down the MembershipManager after it has joined we should not > use uncleanShutdown because the member will appear to have crashed. Instead > we should do a normal shutdown. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionChannel.java > ef4056ca56c1b102e507f96bbfe41396d0139aa5 > > geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java > 029e6377f56d80dd81e4cec430f106ac743e5178 > > > Diff: https://reviews.apache.org/r/59894/diff/1/ > > > Testing > ------- > > The test was failing every time I ran it. It no longer fails. > > > Thanks, > > Bruce Schuchardt > >
