----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59757/#review177093 -----------------------------------------------------------
Ship it! Ship It! - Hitesh Khamesra On June 2, 2017, 7:18 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59757/ > ----------------------------------------------------------- > > (Updated June 2, 2017, 7:18 p.m.) > > > Review request for geode, Hitesh Khamesra and Udo Kohlmeyer. > > > Bugs: GEODE-3024 > https://issues.apache.org/jira/browse/GEODE-3024 > > > Repository: geode > > > Description > ------- > > If a locator is preparing a conflicting membership view we now abandon > preparation of a view in a cache server and pause before retrying. This > gives the locator time to gather information from the cache server's view > (which it receives in acks while preparing its own view), incorporate them > into a new view and send it out. When the cache server installs the new view > from the locator it will shut down its ViewCreator thread. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java > 478c4e832dd18635d0d66c4b85e2e2ce6ed5ab91 > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/messages/ViewAckMessage.java > 71bd6bcbf60fbcd9e6320195c5d9a5e1cf809e8a > > geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java > 49b09cab058e9e68c0e029b048e9c03c585b7fe5 > > > Diff: https://reviews.apache.org/r/59757/diff/1/ > > > Testing > ------- > > new unit test, precheckin, partial regression testing > > > Thanks, > > Bruce Schuchardt > >
