> On May 15, 2017, 6:45 p.m., Udo Kohlmeyer wrote: > > geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java > > Line 269 (original), 308 (patched) > > <https://reviews.apache.org/r/59239/diff/1/?file=1717126#file1717126line310> > > > > It might be just me, but I don't see how the `initialLocators` list is > > suddenly bad. We should just treat it as an `initialList`. Why would they > > suddenly be `bad`?
We got new locator list from live locator and it doesn't contain the initial locator. > On May 15, 2017, 6:45 p.m., Udo Kohlmeyer wrote: > > geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java > > Lines 351 (patched) > > <https://reviews.apache.org/r/59239/diff/1/?file=1717126#file1717126line353> > > > > What makes a locator "bad"? I would argue that we make this method more > > of a general "mergeLocatorLists". The fact that we add list containing > > "bad" locators to another list containing locators, is circumstantial. We could change name of that method but I think it is giving you intent of that method explicitly. And thats how its define in code. > On May 15, 2017, 6:45 p.m., Udo Kohlmeyer wrote: > > geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java > > Lines 168 (patched) > > <https://reviews.apache.org/r/59239/diff/1/?file=1717131#file1717131line168> > > > > Maybe this becomes a test that we can successfully merge 2 locator > > lists. We just validaing method logic. - Hitesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59239/#review174980 ----------------------------------------------------------- On May 15, 2017, 6:33 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59239/ > ----------------------------------------------------------- > > (Updated May 15, 2017, 6:33 p.m.) > > > Review request for geode, Bruce Schuchardt, Galen O'Sullivan, and Udo > Kohlmeyer. > > > Repository: geode > > > Description > ------- > > GEODE-2804 Update InetSocketAddress, when there is IOException. > > Geode keeps InetSocketAddress for locators. So, if locators ip > changes in cloud/VM enviroment then Geode process unable to > connect to locator. Thus we have fixed this problem in two way. > > a. If Geode client sees IOException while connectin to locator then > we change cached InetAddress to use locator hostname. In this way, > client does DNS query again for locator host. > b. For other Geode process, now we connect to locator using hostname. > > Added couple of junit tests for it. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java > 1e807ee > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java > 4bf010b > > geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpClient.java > 6b54170 > > geode-core/src/main/java/org/apache/geode/management/internal/JmxManagerLocatorRequest.java > 0efba01 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java > d61e72d > > geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java > 385569c > > > Diff: https://reviews.apache.org/r/59239/diff/2/ > > > Testing > ------- > > > Thanks, > > Hitesh Khamesra > >
