----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60312/ -----------------------------------------------------------
(Updated June 28, 2017, 6:48 p.m.) Review request for geode, Alexander Murmann, Bruce Schuchardt, and Galen O'Sullivan. Changes ------- Updated revied feedback Repository: geode Description ------- GEODE-2804 Cache InetAddress if configure host as ip string. 1. We keep configure host string in HostAddress class 2. We reuse InetsocketAddress if it is ipString. 3. Client has logic to retry thus we keep InetsocketAddress even if it is not ip string. GEODE-3017 IPv6 issue on windows. Above changes fixed this issue. GEODE-2940 Now we don't validate configure host string on start. As there is possibility that host may not available. 1. Earlier wan config were failing because of that. Now we just keep those configure host string. And try this later. Added unit tests for it. Diffs (updated) ----- geode-assembly/build.gradle 39bb542 geode-assembly/src/test/resources/expected_jars.txt 6260167 geode-core/build.gradle 7f34b4a geode-core/src/main/java/org/apache/geode/admin/internal/DistributionLocatorImpl.java c1bfc93 geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java 53d401a geode-core/src/main/java/org/apache/geode/cache/client/internal/PoolImpl.java 3ded54a geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java 01c6157 geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java a4b3a50 geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSUtil.java da295ab geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java aff1938 geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java bc3d708 geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpClient.java 6b54170 geode-core/src/main/java/org/apache/geode/internal/admin/remote/DistributionLocatorId.java 5ab1bed geode-core/src/main/java/org/apache/geode/internal/admin/remote/RemoteTransportConfig.java 1dc2fd1 geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java 92cfd96 geode-core/src/main/java/org/apache/geode/internal/cache/PoolFactoryImpl.java d4fdbd0 geode-core/src/main/java/org/apache/geode/management/internal/JmxManagerLocatorRequest.java 0efba01 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java 88832ba geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceDUnitTest.java 789d326 geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java 3cc3cfc geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionConfigJUnitTest.java 9f6c5fb geode-core/src/test/java/org/apache/geode/distributed/internal/StartupMessageDataJUnitTest.java 9d63050 geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java a31fa8d geode-core/src/test/resources/org/apache/geode/codeAnalysis/excludedClasses.txt 6a6e0c1 geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorDiscovery.java f5a8fcf geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorMembershipListenerImpl.java d6d5d7c geode-wan/src/main/java/org/apache/geode/internal/cache/wan/AbstractRemoteGatewaySender.java dbc2cc6 geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WanAutoDiscoveryDUnitTest.java 6d75064 gradle/dependency-versions.properties 6a730a4 Diff: https://reviews.apache.org/r/60312/diff/3/ Changes: https://reviews.apache.org/r/60312/diff/2-3/ Testing ------- Thanks, Hitesh Khamesra
