----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61816/#review183615 -----------------------------------------------------------
Ship it! Ship It! - Hitesh Khamesra On Aug. 23, 2017, 3:47 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61816/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2017, 3:47 p.m.) > > > Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh > Khamesra, Udo Kohlmeyer, and Brian Rowe. > > > Bugs: GEODE-3409 > https://issues.apache.org/jira/browse/GEODE-3409 > > > Repository: geode > > > Description > ------- > > ServerConnection cleanup was not decrementing the Acceptor's client > connection count when the protobuf communications mode was in effect. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientHealthMonitor.java > 35cc33f3fa5547a01368a3ae3b6ad401b858610d > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java > 394d2614c0d04353c95454c8730e84688e4766fe > > geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java > 12cc08b2f6cac77dcc2b79f1d3245f0960c3e8ba > > > Diff: https://reviews.apache.org/r/61816/diff/2/ > > > Testing > ------- > > new integration test > > > Thanks, > > Bruce Schuchardt > >
