[PR] Bump org.codehaus.mojo:buildnumber-maven-plugin from 3.2.0 to 3.2.1 [pinot]

2024-09-03 Thread via GitHub
dependabot[bot] opened a new pull request, #13931: URL: https://github.com/apache/pinot/pull/13931 Bumps [org.codehaus.mojo:buildnumber-maven-plugin](https://github.com/mojohaus/buildnumber-maven-plugin) from 3.2.0 to 3.2.1. Release notes Sourced from https://github.com/mojohaus/b

Re: [PR] pinot plugin loader [pinot]

2024-09-03 Thread via GitHub
rfscholte closed pull request #13907: pinot plugin loader URL: https://github.com/apache/pinot/pull/13907 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [PR] pinot plugin loader [pinot]

2024-09-03 Thread via GitHub
rfscholte commented on PR #13907: URL: https://github.com/apache/pinot/pull/13907#issuecomment-2326339893 Superseded by https://github.com/apache/pinot/pull/13930 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Support of classrealms and new plugin structure [pinot]

2024-09-03 Thread via GitHub
gortiz commented on code in PR #13930: URL: https://github.com/apache/pinot/pull/13930#discussion_r1742031724 ## pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java: ## @@ -229,22 +257,86 @@ private void initRecordReaderClassMap() { /** * Loads jars rec

Re: [PR] Support of classrealms and new plugin structure [pinot]

2024-09-03 Thread via GitHub
gortiz commented on code in PR #13930: URL: https://github.com/apache/pinot/pull/13930#discussion_r1742032478 ## pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java: ## @@ -229,22 +257,86 @@ private void initRecordReaderClassMap() { /** * Loads jars rec

Re: [PR] Support of classrealms and new plugin structure [pinot]

2024-09-03 Thread via GitHub
gortiz commented on code in PR #13930: URL: https://github.com/apache/pinot/pull/13930#discussion_r1742060140 ## pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java: ## @@ -229,22 +257,86 @@ private void initRecordReaderClassMap() { /** * Loads jars rec

Re: [PR] Support of classrealms and new plugin structure [pinot]

2024-09-03 Thread via GitHub
gortiz commented on code in PR #13930: URL: https://github.com/apache/pinot/pull/13930#discussion_r1742062595 ## pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java: ## @@ -229,22 +257,86 @@ private void initRecordReaderClassMap() { /** * Loads jars rec

Re: [PR] Support of classrealms and new plugin structure [pinot]

2024-09-03 Thread via GitHub
rfscholte commented on code in PR #13930: URL: https://github.com/apache/pinot/pull/13930#discussion_r1742069989 ## pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java: ## @@ -229,22 +257,86 @@ private void initRecordReaderClassMap() { /** * Loads jars

Re: [PR] Support of classrealms and new plugin structure [pinot]

2024-09-03 Thread via GitHub
rfscholte commented on code in PR #13930: URL: https://github.com/apache/pinot/pull/13930#discussion_r1742076065 ## pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java: ## @@ -229,22 +257,86 @@ private void initRecordReaderClassMap() { /** * Loads jars

Re: [PR] Support of classrealms and new plugin structure [pinot]

2024-09-03 Thread via GitHub
gortiz commented on code in PR #13930: URL: https://github.com/apache/pinot/pull/13930#discussion_r1742084366 ## pinot-spi/src/test/java/org/apache/pinot/spi/plugin/PluginManagerTest.java: ## @@ -195,6 +199,116 @@ public void testBackwardCompatible() { "org.apache.pinot

Re: [PR] Support of classrealms and new plugin structure [pinot]

2024-09-03 Thread via GitHub
gortiz commented on code in PR #13930: URL: https://github.com/apache/pinot/pull/13930#discussion_r1742087623 ## pinot-spi/src/test/java/org/apache/pinot/spi/plugin/PluginManagerTest.java: ## @@ -195,6 +199,116 @@ public void testBackwardCompatible() { "org.apache.pinot

Re: [PR] Support of classrealms and new plugin structure [pinot]

2024-09-03 Thread via GitHub
gortiz commented on code in PR #13930: URL: https://github.com/apache/pinot/pull/13930#discussion_r1742088636 ## pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java: ## @@ -229,22 +257,86 @@ private void initRecordReaderClassMap() { /** * Loads jars rec

[PR] Add Blurb for Uber blog post [pinot-site]

2024-09-03 Thread via GitHub
gio-startree opened a new pull request, #134: URL: https://github.com/apache/pinot-site/pull/134 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] Bump com.microsoft.azure:msal4j from 1.17.0 to 1.17.1 [pinot]

2024-09-03 Thread via GitHub
Jackie-Jiang merged PR #13923: URL: https://github.com/apache/pinot/pull/13923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Bump software.amazon.awssdk:bom from 2.27.16 to 2.27.17 [pinot]

2024-09-03 Thread via GitHub
Jackie-Jiang merged PR #13924: URL: https://github.com/apache/pinot/pull/13924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Bump com.puppycrawl.tools:checkstyle from 10.18.0 to 10.18.1 [pinot]

2024-09-03 Thread via GitHub
Jackie-Jiang merged PR #13926: URL: https://github.com/apache/pinot/pull/13926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Bump org.yaml:snakeyaml from 2.2 to 2.3 [pinot]

2024-09-03 Thread via GitHub
Jackie-Jiang merged PR #13925: URL: https://github.com/apache/pinot/pull/13925 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Bump org.codehaus.mojo:buildnumber-maven-plugin from 3.2.0 to 3.2.1 [pinot]

2024-09-03 Thread via GitHub
Jackie-Jiang merged PR #13931: URL: https://github.com/apache/pinot/pull/13931 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] [Backfill] flink based upsert table backfill support [pinot]

2024-09-03 Thread via GitHub
Jackie-Jiang commented on code in PR #13837: URL: https://github.com/apache/pinot/pull/13837#discussion_r1742484129 ## pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/FlinkSegmentWriter.java: ## @@ -124,12 +135,26 @@ public void init(Ta

Re: [PR] CSVRecordReader. Refactor init and line iterator parsing logic [pinot]

2024-09-03 Thread via GitHub
suvodeep-pyne commented on code in PR #13913: URL: https://github.com/apache/pinot/pull/13913#discussion_r1742543940 ## pinot-plugins/pinot-input-format/pinot-csv/src/main/java/org/apache/pinot/plugin/inputformat/csv/CSVRecordReader.java: ## @@ -60,102 +61,119 @@ public class CS

Re: [PR] CSVRecordReader. Refactor init and line iterator parsing logic [pinot]

2024-09-03 Thread via GitHub
suvodeep-pyne commented on code in PR #13913: URL: https://github.com/apache/pinot/pull/13913#discussion_r1742543940 ## pinot-plugins/pinot-input-format/pinot-csv/src/main/java/org/apache/pinot/plugin/inputformat/csv/CSVRecordReader.java: ## @@ -60,102 +61,119 @@ public class CS

Re: [PR] CSVRecordReader. Refactor init and line iterator parsing logic [pinot]

2024-09-03 Thread via GitHub
suvodeep-pyne commented on code in PR #13913: URL: https://github.com/apache/pinot/pull/13913#discussion_r1742547048 ## pinot-plugins/pinot-input-format/pinot-csv/src/main/java/org/apache/pinot/plugin/inputformat/csv/CSVRecordReader.java: ## @@ -60,102 +61,119 @@ public class CS

Re: [PR] CSVRecordReader. Refactor init and line iterator parsing logic [pinot]

2024-09-03 Thread via GitHub
suvodeep-pyne commented on code in PR #13913: URL: https://github.com/apache/pinot/pull/13913#discussion_r1742551019 ## pinot-plugins/pinot-input-format/pinot-csv/src/main/java/org/apache/pinot/plugin/inputformat/csv/CSVRecordReader.java: ## @@ -202,158 +209,142 @@ public Map ge

Re: [PR] CSVRecordReader. Refactor init and line iterator parsing logic [pinot]

2024-09-03 Thread via GitHub
suvodeep-pyne commented on code in PR #13913: URL: https://github.com/apache/pinot/pull/13913#discussion_r1742552352 ## pinot-plugins/pinot-input-format/pinot-csv/src/main/java/org/apache/pinot/plugin/inputformat/csv/CSVRecordReader.java: ## @@ -202,158 +209,142 @@ public Map ge

Re: [PR] CSVRecordReader. Refactor init and line iterator parsing logic [pinot]

2024-09-03 Thread via GitHub
suvodeep-pyne commented on code in PR #13913: URL: https://github.com/apache/pinot/pull/13913#discussion_r1742564600 ## pinot-plugins/pinot-input-format/pinot-csv/src/main/java/org/apache/pinot/plugin/inputformat/csv/CSVRecordReader.java: ## @@ -202,158 +209,142 @@ public Map ge

Re: [PR] CSVRecordReader. Refactor init and line iterator parsing logic [pinot]

2024-09-03 Thread via GitHub
suvodeep-pyne commented on PR #13913: URL: https://github.com/apache/pinot/pull/13913#issuecomment-2327274122 @swaminathanmanish > Curious how you plan to extend this? I'm not planning to extend the iterator. Rather I am trying to reach a simple code path. One example enhancement

Re: [PR] Add Blurb for Uber blog post [pinot-site]

2024-09-03 Thread via GitHub
gio-startree commented on PR #134: URL: https://github.com/apache/pinot-site/pull/134#issuecomment-2327444158 > The author profile doesn't look correct. Are they included accidentally? I have removed the content we don't use from their profile. It is a _legacy_ thing we were discussin

Re: [PR] Expose Get Segments/Table Config Change capture [pinot]

2024-09-03 Thread via GitHub
deepthi912 commented on code in PR #13915: URL: https://github.com/apache/pinot/pull/13915#discussion_r1739563818 ## pinot-controller/src/main/java/org/apache/pinot/controller/util/TableMetadataReader.java: ## @@ -86,6 +86,16 @@ public JsonNode getSegmentsMetadata(String tableN

Re: [PR] Expose Get Segments/Table Config Change capture [pinot]

2024-09-03 Thread via GitHub
deepthi912 commented on code in PR #13915: URL: https://github.com/apache/pinot/pull/13915#discussion_r1742705976 ## pinot-controller/src/main/java/org/apache/pinot/controller/util/TableMetadataReader.java: ## @@ -86,6 +86,16 @@ public JsonNode getSegmentsMetadata(String tableN

Re: [PR] Allows multiple requests per server per request ID [pinot]

2024-09-03 Thread via GitHub
egalpin commented on code in PR #13742: URL: https://github.com/apache/pinot/pull/13742#discussion_r1742753156 ## pinot-core/src/main/java/org/apache/pinot/core/transport/AsyncQueryResponse.java: ## @@ -50,21 +52,31 @@ public class AsyncQueryResponse implements QueryResponse {

Re: [PR] Allows multiple requests per server per request ID [pinot]

2024-09-03 Thread via GitHub
egalpin commented on PR #13742: URL: https://github.com/apache/pinot/pull/13742#issuecomment-2327526039 @siddharthteotia @jackjlli @vvivekiyer Is there a specific order in which different pinot components _must_ be restarted when performing an upgrade? I can think of a smooth way to

Re: [PR] Expose Get Segments/Table Config Change capture [pinot]

2024-09-03 Thread via GitHub
Jackie-Jiang commented on code in PR #13915: URL: https://github.com/apache/pinot/pull/13915#discussion_r1742764772 ## pinot-controller/src/main/java/org/apache/pinot/controller/util/TableMetadataReader.java: ## @@ -60,21 +60,28 @@ public TableMetadataReader(Executor executor,

Re: [PR] Expose Get Segments/Table Config Change capture [pinot]

2024-09-03 Thread via GitHub
deepthi912 commented on code in PR #13915: URL: https://github.com/apache/pinot/pull/13915#discussion_r1742773173 ## pinot-controller/src/main/java/org/apache/pinot/controller/util/TableMetadataReader.java: ## @@ -60,21 +60,28 @@ public TableMetadataReader(Executor executor, Ht

Re: [PR] Expose Get Segments/Table Config Change capture [pinot]

2024-09-03 Thread via GitHub
deepthi912 commented on PR #13915: URL: https://github.com/apache/pinot/pull/13915#issuecomment-2327549775 Do you want to add a new method boolean isReloadNeeded()? Re: I am thinking to extract boolean in the integration with the server responses. -- This is an automated message from t

Re: [PR] Expose Get Segments/Table Config Change capture [pinot]

2024-09-03 Thread via GitHub
deepthi912 commented on code in PR #13915: URL: https://github.com/apache/pinot/pull/13915#discussion_r1742773173 ## pinot-controller/src/main/java/org/apache/pinot/controller/util/TableMetadataReader.java: ## @@ -60,21 +60,28 @@ public TableMetadataReader(Executor executor, Ht

Re: [PR] Enforce max rows in join limit on joined rows with left input as well [pinot]

2024-09-03 Thread via GitHub
Jackie-Jiang commented on code in PR #13922: URL: https://github.com/apache/pinot/pull/13922#discussion_r1742779113 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/HashJoinOperator.java: ## @@ -307,7 +303,7 @@ private TransferableBlock buildJoinedDat

Re: [I] DISTINCTCOUNT and percentile doesn't utilize indexes to filter data [pinot]

2024-09-03 Thread via GitHub
Jackie-Jiang commented on issue #13833: URL: https://github.com/apache/pinot/issues/13833#issuecomment-2327562832 Can you share the star-tree index config? There should be no scan if the dimension is properly split. The split dimension is sorted, thus binary search is applied instead of sca

Re: [PR] Expose Get Segments/Table Config Change capture [pinot]

2024-09-03 Thread via GitHub
Jackie-Jiang commented on PR #13915: URL: https://github.com/apache/pinot/pull/13915#issuecomment-2327564895 I don't fully follow. Currently this PR becomes a pure refactor without adding public method -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Expose Get Segments/Table Config Change capture [pinot]

2024-09-03 Thread via GitHub
deepthi912 commented on PR #13915: URL: https://github.com/apache/pinot/pull/13915#issuecomment-2327571584 getReloadCheckResponses, made this method public. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[PR] Remove unnecessary plugin version override [pinot]

2024-09-03 Thread via GitHub
Jackie-Jiang opened a new pull request, #13932: URL: https://github.com/apache/pinot/pull/13932 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Remove unnecessary plugin version override [pinot]

2024-09-03 Thread via GitHub
codecov-commenter commented on PR #13932: URL: https://github.com/apache/pinot/pull/13932#issuecomment-2327629951 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13932?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add Blurb for Uber blog post [pinot-site]

2024-09-03 Thread via GitHub
xiangfu0 merged PR #134: URL: https://github.com/apache/pinot-site/pull/134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

Re: [PR] Expose Get Segments/Table Config Change capture [pinot]

2024-09-03 Thread via GitHub
Jackie-Jiang merged PR #13915: URL: https://github.com/apache/pinot/pull/13915 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Kafka3 support [pinot]

2024-09-03 Thread via GitHub
Jackie-Jiang commented on code in PR #13891: URL: https://github.com/apache/pinot/pull/13891#discussion_r1742841062 ## pom.xml: ## @@ -1579,17 +1580,6 @@ ${scala.version} - Review Comment: Suggest keeping it as is and only override the version in kaf

Re: [PR] Add support for configuring aggregation function parameters in the star-tree index [pinot]

2024-09-03 Thread via GitHub
Jackie-Jiang commented on code in PR #13835: URL: https://github.com/apache/pinot/pull/13835#discussion_r1742857916 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/startree/AggregationFunctionColumn.java: ## @@ -127,9 +149,14 @@ public boolean equals(Object

Re: [PR] add metric for time retention failing due to end time [pinot]

2024-09-03 Thread via GitHub
jadami10 commented on PR #13879: URL: https://github.com/apache/pinot/pull/13879#issuecomment-2327888469 > We do have a check in `TimeValidationTransformer` to check if the time value is in valid range. Can you double check why it is not triggered since you don't have `continueOnError` set

Re: [PR] Basic changes on server and controller side to introduce pauseless co… [pinot]

2024-09-03 Thread via GitHub
9aman closed pull request #13927: Basic changes on server and controller side to introduce pauseless co… URL: https://github.com/apache/pinot/pull/13927 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Move schema related tests to pinot-spi [pinot]

2024-09-03 Thread via GitHub
Jackie-Jiang merged PR #13929: URL: https://github.com/apache/pinot/pull/13929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[PR] Code format fixes for HashJoinOperator [pinot]

2024-09-03 Thread via GitHub
yashmayya opened a new pull request, #13933: URL: https://github.com/apache/pinot/pull/13933 - https://github.com/apache/pinot/pull/13922/#discussion_r1742779113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Support of classrealms and new plugin structure [pinot]

2024-09-04 Thread via GitHub
rfscholte commented on code in PR #13930: URL: https://github.com/apache/pinot/pull/13930#discussion_r1743220334 ## pinot-spi/src/test/java/org/apache/pinot/spi/plugin/PluginManagerTest.java: ## @@ -195,6 +199,116 @@ public void testBackwardCompatible() { "org.apache.pi

Re: [PR] Support of classrealms and new plugin structure [pinot]

2024-09-04 Thread via GitHub
gortiz commented on code in PR #13930: URL: https://github.com/apache/pinot/pull/13930#discussion_r1743244297 ## pinot-spi/src/test/java/org/apache/pinot/spi/plugin/PluginManagerTest.java: ## @@ -195,6 +199,116 @@ public void testBackwardCompatible() { "org.apache.pinot

Re: [I] Controller host parameter isn't work [pinot]

2024-09-04 Thread via GitHub
sachinshakya507 commented on issue #12209: URL: https://github.com/apache/pinot/issues/12209#issuecomment-2328270968 still getting same issue -controllerHost parameter not working. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] CSVRecordReader. Refactor init and line iterator parsing logic [pinot]

2024-09-04 Thread via GitHub
KKcorps commented on code in PR #13913: URL: https://github.com/apache/pinot/pull/13913#discussion_r1743338028 ## pinot-plugins/pinot-input-format/pinot-csv/src/main/java/org/apache/pinot/plugin/inputformat/csv/CSVRecordReader.java: ## @@ -202,158 +207,139 @@ public Map getCSVHe

Re: [PR] CSVRecordReader. Refactor init and line iterator parsing logic [pinot]

2024-09-04 Thread via GitHub
KKcorps commented on code in PR #13913: URL: https://github.com/apache/pinot/pull/13913#discussion_r1743351539 ## pinot-plugins/pinot-input-format/pinot-csv/src/main/java/org/apache/pinot/plugin/inputformat/csv/CSVRecordReader.java: ## @@ -58,112 +59,127 @@ public class CSVRecor

Re: [PR] Allow table names in TableConfigs with or without database name when database context is passed [pinot]

2024-09-04 Thread via GitHub
codecov-commenter commented on PR #13934: URL: https://github.com/apache/pinot/pull/13934#issuecomment-2328355840 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13934?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add support for configuring aggregation function parameters in the star-tree index [pinot]

2024-09-04 Thread via GitHub
yashmayya commented on code in PR #13835: URL: https://github.com/apache/pinot/pull/13835#discussion_r1743453260 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/startree/AggregationFunctionColumn.java: ## @@ -127,9 +149,14 @@ public boolean equals(Object ob

Re: [PR] Virtual threads [pinot]

2024-09-04 Thread via GitHub
gortiz closed pull request #13619: Virtual threads URL: https://github.com/apache/pinot/pull/13619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

Re: [PR] Code format fixes for HashJoinOperator [pinot]

2024-09-04 Thread via GitHub
gortiz merged PR #13933: URL: https://github.com/apache/pinot/pull/13933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

[PR] Bump eclipse.jetty.version from 9.4.55.v20240627 to 9.4.56.v20240826 [pinot]

2024-09-04 Thread via GitHub
dependabot[bot] opened a new pull request, #13936: URL: https://github.com/apache/pinot/pull/13936 Bumps `eclipse.jetty.version` from 9.4.55.v20240627 to 9.4.56.v20240826. Updates `org.eclipse.jetty.websocket:websocket-client` from 9.4.55.v20240627 to 9.4.56.v20240826 Updates `org.

Re: [PR] CSVRecordReader. Refactor init and line iterator parsing logic [pinot]

2024-09-04 Thread via GitHub
suvodeep-pyne commented on code in PR #13913: URL: https://github.com/apache/pinot/pull/13913#discussion_r1743956015 ## pinot-plugins/pinot-input-format/pinot-csv/src/main/java/org/apache/pinot/plugin/inputformat/csv/CSVRecordReader.java: ## @@ -58,112 +59,127 @@ public class CS

Re: [PR] CSVRecordReader. Refactor init and line iterator parsing logic [pinot]

2024-09-04 Thread via GitHub
Jackie-Jiang merged PR #13913: URL: https://github.com/apache/pinot/pull/13913 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Short circuit the deleteSegments method when segmentNames is empty [pinot]

2024-09-04 Thread via GitHub
codecov-commenter commented on PR #13937: URL: https://github.com/apache/pinot/pull/13937#issuecomment-2329751841 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13937?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] [Backfill] flink based upsert table backfill support [pinot]

2024-09-04 Thread via GitHub
rohityadav1993 commented on code in PR #13837: URL: https://github.com/apache/pinot/pull/13837#discussion_r1744308078 ## pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/FlinkSegmentWriter.java: ## @@ -124,12 +135,26 @@ public void init(

Re: [PR] Bump software.amazon.awssdk:bom from 2.27.17 to 2.27.18 [pinot]

2024-09-04 Thread via GitHub
Jackie-Jiang merged PR #13935: URL: https://github.com/apache/pinot/pull/13935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Bump eclipse.jetty.version from 9.4.55.v20240627 to 9.4.56.v20240826 [pinot]

2024-09-04 Thread via GitHub
Jackie-Jiang merged PR #13936: URL: https://github.com/apache/pinot/pull/13936 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] add metric for time retention failing due to end time [pinot]

2024-09-04 Thread via GitHub
Jackie-Jiang commented on code in PR #13879: URL: https://github.com/apache/pinot/pull/13879#discussion_r1744366830 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/SegmentStatusChecker.java: ## @@ -318,6 +321,17 @@ private void updateSegmentMetrics(String ta

Re: [PR] Upgrade Helix dependency to 1.4.0 [pinot]

2024-09-04 Thread via GitHub
jackjlli commented on PR #13486: URL: https://github.com/apache/pinot/pull/13486#issuecomment-2329912019 @Jackie-Jiang If you check the failed messages from the Github actions, it shows that the exception was thrown when trying to update the table config (not trying to list the table config

Re: [PR] Allows multiple requests per server per request ID [pinot]

2024-09-04 Thread via GitHub
jackjlli commented on code in PR #13742: URL: https://github.com/apache/pinot/pull/13742#discussion_r1744379495 ## pinot-core/src/main/java/org/apache/pinot/core/transport/AsyncQueryResponse.java: ## @@ -50,21 +52,31 @@ public class AsyncQueryResponse implements QueryResponse {

Re: [PR] Kafka3 support [pinot]

2024-09-04 Thread via GitHub
abhioncbr commented on code in PR #13891: URL: https://github.com/apache/pinot/pull/13891#discussion_r1744689447 ## pom.xml: ## @@ -1579,17 +1580,6 @@ ${scala.version} - Review Comment: reverted. Thanks -- This is an automated message from the Ap

Re: [PR] Add broker API to run a query on both query engines and compare results [pinot]

2024-09-05 Thread via GitHub
vrajat commented on code in PR #13746: URL: https://github.com/apache/pinot/pull/13746#discussion_r1745157640 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java: ## @@ -236,6 +243,76 @@ public void processSqlWithMultiStageQueryEnginePost(

Re: [I] MinionTenant as a table config [pinot]

2024-09-05 Thread via GitHub
tarun11Mavani commented on issue #12698: URL: https://github.com/apache/pinot/issues/12698#issuecomment-2331638479 @tibrewalpratik17 created a issue for Add validation of instance tag provided in task-config in TableConfigUtils. Please link the same to this issue description. https:

Re: [PR] Multi stage explain [pinot]

2024-09-05 Thread via GitHub
yashmayya commented on code in PR #13733: URL: https://github.com/apache/pinot/pull/13733#discussion_r1741452894 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -1192,6 +1209,9 @@ public enum WindowOverFlowMode { public static class PlanVer

Re: [PR] Bump org.checkerframework:checker-qual from 3.46.0 to 3.47.0 [pinot]

2024-09-05 Thread via GitHub
Jackie-Jiang merged PR #13938: URL: https://github.com/apache/pinot/pull/13938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] colocated-without-hints: First commit with the proposed code [pinot]

2024-09-05 Thread via GitHub
ankitsultana commented on PR #13943: URL: https://github.com/apache/pinot/pull/13943#issuecomment-2332383406 @gortiz are you aiming to make it so that the entire plan can be colocated when possible? From Uber side we were planning to add this feature back again this year. For our cur

Re: [PR] [Spark Connector] Write support for creating Pinot segments [pinot]

2024-09-05 Thread via GitHub
cbalci commented on code in PR #13748: URL: https://github.com/apache/pinot/pull/13748#discussion_r1745988697 ## .github/workflows/pinot_tests.yml: ## @@ -123,6 +123,11 @@ jobs: --add-exports=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED --add-exp

Re: [PR] Bump io.netty:netty-bom from 4.1.112.Final to 4.1.113.Final [pinot]

2024-09-05 Thread via GitHub
Jackie-Jiang merged PR #13940: URL: https://github.com/apache/pinot/pull/13940 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Part-1: Pinot Timeseries Engine SPI [pinot]

2024-09-05 Thread via GitHub
Jackie-Jiang commented on code in PR #13885: URL: https://github.com/apache/pinot/pull/13885#discussion_r1746027496 ## pinot-timeseries/pinot-timeseries-spi/src/main/java/org/apache/pinot/tsdb/spi/PinotTimeSeriesConfiguration.java: ## @@ -0,0 +1,57 @@ +/** + * Licensed to the Ap

Re: [PR] Add support for configuring aggregation function parameters in the star-tree index [pinot]

2024-09-05 Thread via GitHub
yashmayya commented on code in PR #13835: URL: https://github.com/apache/pinot/pull/13835#discussion_r1746502018 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/aggregator/DistinctCountCPCSketchValueAggregator.java: ## @@ -34,11 +35,11 @@ public class Distinc

Re: [PR] [Backfill] flink based upsert table backfill support [pinot]

2024-09-05 Thread via GitHub
klsince commented on code in PR #13837: URL: https://github.com/apache/pinot/pull/13837#discussion_r1746526919 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/IngestionUtils.java: ## @@ -169,6 +170,16 @@ private static SegmentNameGenerator getSegmentNa

Re: [PR] [DRAFT] custom partial upsert row merger [pinot]

2024-09-05 Thread via GitHub
rohityadav1993 closed pull request #11584: [DRAFT] custom partial upsert row merger URL: https://github.com/apache/pinot/pull/11584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [I] DISCOUNTHLL function returns an error when value of log2m is not 8 [pinot]

2024-09-06 Thread via GitHub
yashmayya commented on issue #12839: URL: https://github.com/apache/pinot/issues/12839#issuecomment-2333707862 Will be fixed by https://github.com/apache/pinot/pull/13835. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[PR] Acquire IdealStateUpdaterLock for PinotLLCRealtimeSegmentManager IdealState update [pinot]

2024-09-06 Thread via GitHub
xiangfu0 opened a new pull request, #13947: URL: https://github.com/apache/pinot/pull/13947 Acquire IdealStateUpdaterLock for PinotLLCRealtimeSegmentManager IdealState update -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] Multi stage explain [pinot]

2024-09-06 Thread via GitHub
gortiz commented on code in PR #13733: URL: https://github.com/apache/pinot/pull/13733#discussion_r1747183652 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MultiStageOperator.java: ## @@ -167,6 +173,26 @@ protected TransferableBlock updateEosBlock

Re: [PR] Multi stage explain [pinot]

2024-09-06 Thread via GitHub
gortiz commented on code in PR #13733: URL: https://github.com/apache/pinot/pull/13733#discussion_r1747183652 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MultiStageOperator.java: ## @@ -167,6 +173,26 @@ protected TransferableBlock updateEosBlock

Re: [PR] Multi stage explain [pinot]

2024-09-06 Thread via GitHub
gortiz commented on code in PR #13733: URL: https://github.com/apache/pinot/pull/13733#discussion_r1747183652 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MultiStageOperator.java: ## @@ -167,6 +173,26 @@ protected TransferableBlock updateEosBlock

Re: [PR] Multi stage explain [pinot]

2024-09-06 Thread via GitHub
gortiz commented on code in PR #13733: URL: https://github.com/apache/pinot/pull/13733#discussion_r1747199174 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/explain/ExplainNodeSimplifier.java: ## @@ -0,0 +1,169 @@ +/** + * Licensed to the Apache Software Fou

Re: [PR] Multi stage explain [pinot]

2024-09-06 Thread via GitHub
gortiz commented on code in PR #13733: URL: https://github.com/apache/pinot/pull/13733#discussion_r1747205731 ## pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java: ## @@ -691,4 +662,132 @@ private void addPrunerStats(InstanceResponseBlo

Re: [PR] Acquire IdealStateUpdaterLock for PinotLLCRealtimeSegmentManager IdealState update [pinot]

2024-09-06 Thread via GitHub
codecov-commenter commented on PR #13947: URL: https://github.com/apache/pinot/pull/13947#issuecomment-2334170267 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13947?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Multi stage explain [pinot]

2024-09-06 Thread via GitHub
gortiz commented on code in PR #13733: URL: https://github.com/apache/pinot/pull/13733#discussion_r1747210742 ## pinot-core/src/main/java/org/apache/pinot/core/plan/PinotExplainedRelNode.java: ## @@ -0,0 +1,146 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Bump software.amazon.awssdk:bom from 2.27.19 to 2.27.20 [pinot]

2024-09-06 Thread via GitHub
Jackie-Jiang merged PR #13945: URL: https://github.com/apache/pinot/pull/13945 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Allows multiple requests per server per request ID [pinot]

2024-09-06 Thread via GitHub
egalpin commented on code in PR #13742: URL: https://github.com/apache/pinot/pull/13742#discussion_r1747732334 ## pinot-core/src/main/java/org/apache/pinot/core/transport/QueryResponse.java: ## @@ -49,12 +50,12 @@ enum Status { /** * Returns the current server responses w

Re: [PR] Add support for configuring aggregation function parameters in the star-tree index [pinot]

2024-09-06 Thread via GitHub
Jackie-Jiang merged PR #13835: URL: https://github.com/apache/pinot/pull/13835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] add metric for time retention failing due to end time [pinot]

2024-09-06 Thread via GitHub
Jackie-Jiang merged PR #13879: URL: https://github.com/apache/pinot/pull/13879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [I] Controller host parameter isn't work [pinot]

2024-09-06 Thread via GitHub
Jackie-Jiang commented on issue #12209: URL: https://github.com/apache/pinot/issues/12209#issuecomment-2334908652 I see. @sachinshakya507 Do you want to help contribute a fix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] Kafka3 support [pinot]

2024-09-06 Thread via GitHub
Jackie-Jiang commented on PR #13891: URL: https://github.com/apache/pinot/pull/13891#issuecomment-2334910543 @swaminathanmanish @xiangfu0 Can you help review this PR? Once we verify Kafka3 consumer is backward compatible with Kafka2 producer, we can clean up Kafka2 code since it exposes som

Re: [PR] Store index metadata file for Lucene text indexes [pinot]

2024-09-06 Thread via GitHub
codecov-commenter commented on PR #13948: URL: https://github.com/apache/pinot/pull/13948#issuecomment-2334918659 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13948?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Return correct dataschema for empty results [pinot]

2024-09-06 Thread via GitHub
vvivekiyer commented on PR #13831: URL: https://github.com/apache/pinot/pull/13831#issuecomment-2334928869 I'm working on the broker side changes as well. I'll create that as a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Fix TextMatchFilterOptimizer `or not` behavior [pinot]

2024-09-06 Thread via GitHub
itschrispeck commented on code in PR #13533: URL: https://github.com/apache/pinot/pull/13533#discussion_r1747820425 ## pinot-core/src/test/java/org/apache/pinot/core/query/optimizer/QueryOptimizerTest.java: ## @@ -293,6 +293,11 @@ public void testQueries() { + "AND

Re: [PR] Add @JsonProperty for LeadControllerResponse & LeadControllerEntry [pinot]

2024-09-06 Thread via GitHub
deepthi912 closed pull request #13949: Add @JsonProperty for LeadControllerResponse & LeadControllerEntry URL: https://github.com/apache/pinot/pull/13949 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Add @JsonProperty annotation to LeadControllerEntry & LeadControllerResponse [pinot]

2024-09-06 Thread via GitHub
codecov-commenter commented on PR #13950: URL: https://github.com/apache/pinot/pull/13950#issuecomment-2334993139 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13950?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

<    5   6   7   8   9   10   11   12   13   14   >