gortiz commented on code in PR #13930:
URL: https://github.com/apache/pinot/pull/13930#discussion_r1742087623
##########
pinot-spi/src/test/java/org/apache/pinot/spi/plugin/PluginManagerTest.java:
##########
@@ -195,6 +199,116 @@ public void testBackwardCompatible() {
"org.apache.pinot.plugin.stream.kafka20.KafkaConsumerFactory");
}
+ @Test
+ public void classRealms() throws Exception {
Review Comment:
It is not necessary to have one test per assert, but it would be great to
split this single test method into at least 5 or so test methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
