vrajat commented on code in PR #13746:
URL: https://github.com/apache/pinot/pull/13746#discussion_r1745157640
##########
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java:
##########
@@ -236,6 +243,76 @@ public void processSqlWithMultiStageQueryEnginePost(String
query, @Suspended Asy
}
}
+ @POST
+ @Produces(MediaType.APPLICATION_JSON)
+ @Path("query/compare")
+ @ApiOperation(value = "Query Pinot using both the single stage query engine
and the multi stage query engine and "
Review Comment:
I am using swagger APIs quite a bit today. Setting `sql` vs `v1Sql/v2Sql`
maybe confusing. Majority of users will only use the doc in the swagger page to
use the API. There are a couple of options to reduce confusion:
* Only provide `v1Sql`/`v2Sql`. Its not that hard to copy paste twice.
* Change the one-line documentation to add more info. There is precedence to
multi-line description in swagger page. For example:
> Query Pinot using both the single stage query engine and the multi stage
query engine and compare the results. Set sql field to run the same query in
both engines. Set v1Sql & v2Sql instead if query text is different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
