gortiz commented on code in PR #13930:
URL: https://github.com/apache/pinot/pull/13930#discussion_r1742084366


##########
pinot-spi/src/test/java/org/apache/pinot/spi/plugin/PluginManagerTest.java:
##########
@@ -195,6 +199,116 @@ public void testBackwardCompatible() {
         "org.apache.pinot.plugin.stream.kafka20.KafkaConsumerFactory");
   }
 
+  @Test
+  public void classRealms() throws Exception {

Review Comment:
   I find this test a bit difficult to read. Can we split it in different tests 
and/or add some message to be show in case the assertion fail? That is 
specially useful to make life easier for readers even when the tests do not fail



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to