rfscholte commented on code in PR #13930:
URL: https://github.com/apache/pinot/pull/13930#discussion_r1743220334
##########
pinot-spi/src/test/java/org/apache/pinot/spi/plugin/PluginManagerTest.java:
##########
@@ -195,6 +199,116 @@ public void testBackwardCompatible() {
"org.apache.pinot.plugin.stream.kafka20.KafkaConsumerFactory");
}
+ @Test
+ public void classRealms() throws Exception {
Review Comment:
I've split it up into 3: limited plugin, unlimited plugin and shaded.
I could also do it the other way around: a test per class(resource) and
verify from which classloader it is coming from (so you can see the differences
per type plugin in 1 test).
What do you prefer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
