jadami10 commented on PR #13879: URL: https://github.com/apache/pinot/pull/13879#issuecomment-2327888469
> We do have a check in `TimeValidationTransformer` to check if the time value is in valid range. Can you double check why it is not triggered since you don't have `continueOnError` set to true? Because there's no `ingestionConfig` set, we hit [this branch](https://github.com/apache/pinot/blob/master/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/TimeValidationTransformer.java#L60) that sets `_enableTimeValueCheck` to false. But this code also has a similar problem. https://github.com/apache/pinot/blob/master/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/TimeValidationTransformer.java#L93 sets the time value to null without incrementing any metrics. Pinot is basically failing to do something quite important (ingest the data) without offering any way to alert users. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
