suvodeep-pyne commented on PR #13913: URL: https://github.com/apache/pinot/pull/13913#issuecomment-2327274122
@swaminathanmanish > Curious how you plan to extend this? I'm not planning to extend the iterator. Rather I am trying to reach a simple code path. One example enhancement is having a `hasHeader` boolean which would ask the reader to assume that a header is present or not present. Any config adds complexity since now, you have to support both the default `CSVParser` and the line iterator based parsing logic. Objective is to be able to support both flows and test both flows. > Would you be adding different iterator implementations and make it pluggable in CSVRecordreader? No. Ideally we would want to consolidate this to 1 iterator. 1 plan here is to contribute to commons CSV so that this complexity can be removed if it is a common requirement to do line by line parsing. And if it is not, does pinot need to continue to support this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
