Re: [PR] Move Table Routing logic in SSE to TableRoute class [pinot]

2025-04-23 Thread via GitHub
vrajat commented on code in PR #15388: URL: https://github.com/apache/pinot/pull/15388#discussion_r2057663499 ## pinot-core/src/main/java/org/apache/pinot/core/transport/TableRouteInfo.java: ## @@ -0,0 +1,198 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Move Table Routing logic in SSE to TableRoute class [pinot]

2025-04-23 Thread via GitHub
vrajat commented on code in PR #15388: URL: https://github.com/apache/pinot/pull/15388#discussion_r2057511664 ## pinot-core/src/main/java/org/apache/pinot/core/transport/TableRouteInfo.java: ## @@ -0,0 +1,198 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Move Table Routing logic in SSE to TableRoute class [pinot]

2025-04-23 Thread via GitHub
vrajat commented on code in PR #15388: URL: https://github.com/apache/pinot/pull/15388#discussion_r2057658818 ## pinot-query-planner/src/main/java/org/apache/pinot/query/routing/table/TableRouteProvider.java: ## @@ -0,0 +1,49 @@ +/** + * Licensed to the Apache Software Foundatio

(pinot) branch master updated (08f6155cad -> 83d4fae2f2)

2025-04-23 Thread kharekartik
This is an automated email from the ASF dual-hosted git repository. kharekartik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 08f6155cad [multistage] Minor Changes to Support Physical Optimizer Related Changes (#15562) add 83d4fae2f2

Re: [PR] Add button to repair realtime table by triggering RealtimeSegmentValidationManager [pinot]

2025-04-23 Thread via GitHub
KKcorps merged PR #15584: URL: https://github.com/apache/pinot/pull/15584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

Re: [PR] Move Table Routing logic in SSE to TableRoute class [pinot]

2025-04-23 Thread via GitHub
vrajat commented on code in PR #15388: URL: https://github.com/apache/pinot/pull/15388#discussion_r2057656005 ## pinot-query-planner/src/main/java/org/apache/pinot/query/routing/table/TableRouteProvider.java: ## @@ -0,0 +1,49 @@ +/** + * Licensed to the Apache Software Foundatio

Re: [PR] Pass Table Config to timeSeries Plugin to use in logical plan phase. [pinot]

2025-04-23 Thread via GitHub
ankitsultana commented on code in PR #15604: URL: https://github.com/apache/pinot/pull/15604#discussion_r2057503988 ## pinot-plugins/pinot-timeseries-lang/pinot-timeseries-m3ql/src/main/java/org/apache/pinot/tsdb/m3ql/M3TimeSeriesPlanner.java: ## @@ -48,7 +49,7 @@ public void in

Re: [I] Pushing the segment files generated through spark with cluster mode/standalone job are failing with "Could not find paramName tableName in path or query params of the API v2/segmments" with s3

2025-04-23 Thread via GitHub
chrajeshbabu commented on issue #14407: URL: https://github.com/apache/pinot/issues/14407#issuecomment-2826396894 @PiyushGoyal443 not yet. Will check again and try to find the root cause. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Move Query Execution Planning to TableExecutionInfo in SSE [pinot]

2025-04-23 Thread via GitHub
vrajat commented on code in PR #15523: URL: https://github.com/apache/pinot/pull/15523#discussion_r2057525988 ## pinot-core/src/main/java/org/apache/pinot/core/query/executor/TableExecutionInfo.java: ## @@ -0,0 +1,211 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Move Query Execution Planning to TableExecutionInfo in SSE [pinot]

2025-04-23 Thread via GitHub
yashmayya commented on code in PR #15523: URL: https://github.com/apache/pinot/pull/15523#discussion_r2057524805 ## pinot-core/src/main/java/org/apache/pinot/core/query/executor/TableExecutionInfo.java: ## @@ -0,0 +1,211 @@ +/** + * Licensed to the Apache Software Foundation (AS

Re: [PR] Move Table Routing logic in SSE to TableRoute class [pinot]

2025-04-23 Thread via GitHub
vrajat commented on code in PR #15388: URL: https://github.com/apache/pinot/pull/15388#discussion_r2057524176 ## pinot-query-planner/src/main/java/org/apache/pinot/query/routing/table/TableRouteProvider.java: ## @@ -0,0 +1,49 @@ +/** + * Licensed to the Apache Software Foundatio

Re: [PR] Move Table Routing logic in SSE to TableRoute class [pinot]

2025-04-23 Thread via GitHub
vrajat commented on code in PR #15388: URL: https://github.com/apache/pinot/pull/15388#discussion_r2057512832 ## pinot-core/src/main/java/org/apache/pinot/core/transport/TableRouteInfo.java: ## @@ -0,0 +1,198 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Move Table Routing logic in SSE to TableRoute class [pinot]

2025-04-23 Thread via GitHub
vrajat commented on code in PR #15388: URL: https://github.com/apache/pinot/pull/15388#discussion_r2057511664 ## pinot-core/src/main/java/org/apache/pinot/core/transport/TableRouteInfo.java: ## @@ -0,0 +1,198 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Move Table Routing logic in SSE to TableRoute class [pinot]

2025-04-23 Thread via GitHub
vrajat commented on PR #15388: URL: https://github.com/apache/pinot/pull/15388#issuecomment-2826348084 > `TableRouteInfo` is not really general. Is it introduced just for refactoring purpose? If so, let's only add the implementation for now without the interface because interface should be

Re: [PR] Move Query Execution Planning to TableExecutionInfo in SSE [pinot]

2025-04-23 Thread via GitHub
vrajat commented on code in PR #15523: URL: https://github.com/apache/pinot/pull/15523#discussion_r2057507548 ## pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java: ## @@ -199,128 +191,37 @@ private InstanceResponseBlock executeInternal

Re: [PR] Move Query Execution Planning to TableExecutionInfo in SSE [pinot]

2025-04-23 Thread via GitHub
vrajat commented on code in PR #15523: URL: https://github.com/apache/pinot/pull/15523#discussion_r2057492572 ## pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java: ## @@ -199,128 +190,36 @@ private InstanceResponseBlock executeInternal

Re: [I] Error when using LEFT JOIN with json_extract_scalar function in SELECT clause and WHERE clause on right table column [pinot]

2025-04-23 Thread via GitHub
yashmayya commented on issue #15566: URL: https://github.com/apache/pinot/issues/15566#issuecomment-2826231005 @Jackie-Jiang yeah, that's right. Looking at the transform function implementation, I think it should be feasible to add a scalar function implementation as well that can be used i

(pinot) branch master updated (72dfdedf34 -> 43630fdfb4)

2025-04-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 72dfdedf34 Replace RebalanceConfig.MinimizeDataMovementOptions with Enablement (#15619) add 43630fdfb4 Log query

Re: [PR] Ensure allocator is applied to accepted connections in QueryServer [pinot]

2025-04-23 Thread via GitHub
codecov-commenter commented on PR #15628: URL: https://github.com/apache/pinot/pull/15628#issuecomment-2825925125 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15628?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] [multistage] Minor Changes to Support Physical Optimizer Related Changes [pinot]

2025-04-23 Thread via GitHub
ankitsultana merged PR #15562: URL: https://github.com/apache/pinot/pull/15562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: [multistage] Minor Changes to Support Physical Optimizer Related Changes (#15562)

2025-04-23 Thread ankitsultana
This is an automated email from the ASF dual-hosted git repository. ankitsultana pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 08f6155cad [multistage] Minor Changes to Su

[PR] Ensure allocator is applied to accepted connections in QueryServer [pinot]

2025-04-23 Thread via GitHub
rhodo opened a new pull request, #15628: URL: https://github.com/apache/pinot/pull/15628 This fixes a misconfiguration where `bufAllocatorWithLimits` was set using `.option(ChannelOption.ALLOCATOR, ...)` but not applied via `.childOption(ChannelOption.ALLOCATOR, ...)`. Setting the al

Re: [PR] Add hooks to service starters to apply custom cluster and instance configs [pinot]

2025-04-23 Thread via GitHub
Jackie-Jiang commented on code in PR #15595: URL: https://github.com/apache/pinot/pull/15595#discussion_r2057074045 ## pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java: ## @@ -162,10 +162,10 @@ public void init(PinotConfiguration brokerConf)

Re: [PR] Move hasTableAccess and hasExceededQPSQuota to BaseBrokerRequestHandler [pinot]

2025-04-23 Thread via GitHub
Jackie-Jiang merged PR #15547: URL: https://github.com/apache/pinot/pull/15547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [I] Move hasTableAccess and hasExceededQPSQuota to BaseBrokerRequestHandler [pinot]

2025-04-23 Thread via GitHub
Jackie-Jiang closed issue #15574: Move hasTableAccess and hasExceededQPSQuota to BaseBrokerRequestHandler URL: https://github.com/apache/pinot/issues/15574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(pinot) branch master updated (43630fdfb4 -> c2dfce5c24)

2025-04-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 43630fdfb4 Log query exceptions in query runner perf tool (#15572) add c2dfce5c24 Move hasTableAccess and hasExcee

Re: [PR] Log query exceptions in query runner perf tool [pinot]

2025-04-23 Thread via GitHub
Jackie-Jiang merged PR #15572: URL: https://github.com/apache/pinot/pull/15572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [I] Error when using LEFT JOIN with json_extract_scalar function in SELECT clause and WHERE clause on right table column [pinot]

2025-04-23 Thread via GitHub
Jackie-Jiang commented on issue #15566: URL: https://github.com/apache/pinot/issues/15566#issuecomment-2825787646 I believe the reason is that there is no scalar function version of `json_extract_scalar`. cc @gortiz @yashmayya -- This is an automated message from the Apache Git Service.

Re: [I] Support for multi path data directories per server to utilize multiple disks present in a node [pinot]

2025-04-23 Thread via GitHub
Jackie-Jiang commented on issue #14461: URL: https://github.com/apache/pinot/issues/14461#issuecomment-2825632300 Hmm, this would be tricky because we need some special logic to decide where to land the data. If any disk fails, the handling will also be tricky. Ideally this should be handle

(pinot) branch master updated: Bump org.apache.commons:commons-collections4 from 4.4 to 4.5.0 (#15620)

2025-04-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 41b14088fd Bump org.apache.commons:commons-collec

Re: [PR] Move Table Routing logic in SSE to TableRoute class [pinot]

2025-04-23 Thread via GitHub
Jackie-Jiang commented on code in PR #15388: URL: https://github.com/apache/pinot/pull/15388#discussion_r2056924417 ## pinot-query-planner/src/main/java/org/apache/pinot/query/routing/table/TableRouteProvider.java: ## @@ -0,0 +1,49 @@ +/** + * Licensed to the Apache Software Fou

[PR] Add memory related metrics for grpc query server [pinot]

2025-04-23 Thread via GitHub
rhodo opened a new pull request, #15625: URL: https://github.com/apache/pinot/pull/15625 First this PR refactor our current server init logic a bit. `ServerBuilder.forPort(port)` will load the first implementation in the classpath which is almost always to be NettyServerBuilder but it is go

Re: [PR] Revert SecretStore interface [pinot]

2025-04-23 Thread via GitHub
codecov-commenter commented on PR #15627: URL: https://github.com/apache/pinot/pull/15627#issuecomment-2825554111 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15627?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Revert SecretStore interface [pinot]

2025-04-23 Thread via GitHub
Jackie-Jiang opened a new pull request, #15627: URL: https://github.com/apache/pinot/pull/15627 This PR reverts #15226 as we are not sure if this is the correct approach to manage secret. Will re-introduce it if necessary. -- This is an automated message from the Apache Git Service. To re

Re: [PR] Add memory related metrics for grpc servers [pinot]

2025-04-23 Thread via GitHub
codecov-commenter commented on PR #15625: URL: https://github.com/apache/pinot/pull/15625#issuecomment-2825482326 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15625?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Replace RebalanceConfig.MinimizeDataMovementOptions with Enablement [pinot]

2025-04-23 Thread via GitHub
Jackie-Jiang merged PR #15619: URL: https://github.com/apache/pinot/pull/15619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Metrics for Segment Upload/Download [pinot]

2025-04-23 Thread via GitHub
siddharthteotia merged PR #15585: URL: https://github.com/apache/pinot/pull/15585 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pi

(pinot) branch master updated: Metrics for Segment Upload/Download (#15585)

2025-04-23 Thread siddteotia
This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new fc8ee6a09c Metrics for Segment Upload/Downloa

Re: [PR] Move Query Execution Planning to TableExecutionInfo in SSE [pinot]

2025-04-23 Thread via GitHub
vrajat commented on code in PR #15523: URL: https://github.com/apache/pinot/pull/15523#discussion_r2056548535 ## pinot-core/src/main/java/org/apache/pinot/core/query/executor/TableExecutionInfo.java: ## @@ -0,0 +1,197 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add memory related metrics for grpc servers [pinot]

2025-04-23 Thread via GitHub
rhodo commented on code in PR #15625: URL: https://github.com/apache/pinot/pull/15625#discussion_r2056810259 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/channel/GrpcMailboxServer.java: ## @@ -49,24 +50,22 @@ public class GrpcMailboxServer extends PinotMa

Re: [PR] Optimize memory usage on SchemaConformingTransformer [pinot]

2025-04-23 Thread via GitHub
codecov-commenter commented on PR #15624: URL: https://github.com/apache/pinot/pull/15624#issuecomment-2825387325 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15624?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Implementation of SPI_change_checker Github action [pinot]

2025-04-23 Thread via GitHub
matvj250 opened a new pull request, #15626: URL: https://github.com/apache/pinot/pull/15626 Adding a Github action that automatically checks PRs for incompatible changes to SPI files, primarily changes to SPI method signatures. Implementation involves looking at the output of `git diff` bet

Re: [PR] Move Query Execution Planning to TableExecutionInfo in SSE [pinot]

2025-04-23 Thread via GitHub
Jackie-Jiang commented on code in PR #15523: URL: https://github.com/apache/pinot/pull/15523#discussion_r2056686085 ## pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java: ## @@ -199,128 +190,36 @@ private InstanceResponseBlock executeIn

Re: [PR] Add memory related metrics for grpc query server [pinot]

2025-04-23 Thread via GitHub
rhodo commented on code in PR #15625: URL: https://github.com/apache/pinot/pull/15625#discussion_r2056736182 ## pinot-core/src/main/java/org/apache/pinot/core/transport/grpc/GrpcQueryServer.java: ## @@ -107,17 +113,36 @@ public GrpcQueryServer(int port, GrpcConfig config, TlsCo

Re: [PR] Replace RebalanceConfig.MinimizeDataMovementOptions with Enablement [pinot]

2025-04-23 Thread via GitHub
Jackie-Jiang commented on code in PR #15619: URL: https://github.com/apache/pinot/pull/15619#discussion_r2056669231 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -104,17 +106,15 @@ public Instanc

[PR] Optimize memory usage on SchemaConformingTransformer [pinot]

2025-04-23 Thread via GitHub
lnbest0707-uber opened a new pull request, #15624: URL: https://github.com/apache/pinot/pull/15624 `real-time` `ingestion` `performance` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Bump org.apache.commons:commons-collections4 from 4.4 to 4.5.0 [pinot]

2025-04-23 Thread via GitHub
Jackie-Jiang merged PR #15620: URL: https://github.com/apache/pinot/pull/15620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] [multistage] Minor Changes to Support Physical Optimizer Related Changes [pinot]

2025-04-23 Thread via GitHub
Jackie-Jiang commented on code in PR #15562: URL: https://github.com/apache/pinot/pull/15562#discussion_r2056678166 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/exchange/SingletonExchange.java: ## @@ -38,9 +37,7 @@ class SingletonExchange extends

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.31.27 deleted (was 5812fc0309)

2025-04-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.31.27 in repository https://gitbox.apache.org/repos/asf/pinot.git was 5812fc0309 Bump software.amazon.awssdk:bom from 2.31.26 to 2.31.27 The r

(pinot) branch dependabot/maven/org.apache.commons-commons-collections4-4.5.0 deleted (was c90b132b0e)

2025-04-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/org.apache.commons-commons-collections4-4.5.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was c90b132b0e Bump org.apache.commons:commons-collections4 from 4

(pinot) branch master updated: Bump software.amazon.awssdk:bom from 2.31.26 to 2.31.27 (#15621)

2025-04-23 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 5b55f63188 Bump software.amazon.awssdk:bom from 2

Re: [PR] Bump software.amazon.awssdk:bom from 2.31.26 to 2.31.27 [pinot]

2025-04-23 Thread via GitHub
Jackie-Jiang merged PR #15621: URL: https://github.com/apache/pinot/pull/15621 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Move Query Execution Planning to TableExecutionInfo in SSE [pinot]

2025-04-23 Thread via GitHub
vrajat commented on code in PR #15523: URL: https://github.com/apache/pinot/pull/15523#discussion_r2056539639 ## pinot-core/src/main/java/org/apache/pinot/core/query/executor/TableExecutionInfo.java: ## @@ -0,0 +1,197 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Move Query Execution Planning to TableExecutionInfo in SSE [pinot]

2025-04-23 Thread via GitHub
vrajat commented on code in PR #15523: URL: https://github.com/apache/pinot/pull/15523#discussion_r2056543692 ## pinot-core/src/main/java/org/apache/pinot/core/query/executor/TableExecutionInfo.java: ## @@ -0,0 +1,197 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Move Query Execution Planning to TableExecutionInfo in SSE [pinot]

2025-04-23 Thread via GitHub
vrajat commented on code in PR #15523: URL: https://github.com/apache/pinot/pull/15523#discussion_r2056542955 ## pinot-core/src/main/java/org/apache/pinot/core/query/executor/TableExecutionInfo.java: ## @@ -0,0 +1,197 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Move Query Execution Planning to TableExecutionInfo in SSE [pinot]

2025-04-23 Thread via GitHub
vrajat commented on code in PR #15523: URL: https://github.com/apache/pinot/pull/15523#discussion_r2056520779 ## pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java: ## @@ -199,128 +191,37 @@ private InstanceResponseBlock executeInternal

Re: [PR] Move Table Routing logic in SSE to TableRoute class [pinot]

2025-04-23 Thread via GitHub
vrajat commented on PR #15388: URL: https://github.com/apache/pinot/pull/15388#issuecomment-2824949540 Test failure is not related to the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[PR] Broker selection for logical tables [pinot]

2025-04-23 Thread via GitHub
abhishekbafna opened a new pull request, #15622: URL: https://github.com/apache/pinot/pull/15622 Implementation for broker selection for logical tables. For the logical tables, it adds an entry into brokerResource node under ideal state which is transitioned to external view node usin

Re: [PR] Allow configuring NOW() return type in the multi-stage engine [pinot]

2025-04-23 Thread via GitHub
yashmayya closed pull request #15610: Allow configuring NOW() return type in the multi-stage engine URL: https://github.com/apache/pinot/pull/15610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Add a button to view consuming segments info directly in table UI [pinot]

2025-04-23 Thread via GitHub
codecov-commenter commented on PR #15623: URL: https://github.com/apache/pinot/pull/15623#issuecomment-2824415780 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15623?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] byte-based splitting for mse query blocks [pinot]

2025-04-23 Thread via GitHub
albertobastos commented on code in PR #15571: URL: https://github.com/apache/pinot/pull/15571#discussion_r2055538832 ## pinot-common/src/main/java/org/apache/pinot/common/datablock/DataBlockUtils.java: ## @@ -230,6 +230,28 @@ public static ByteString toByteString(DataBlock dataB

[PR] Add a button to view consuming segments info directly in table UI [pinot]

2025-04-23 Thread via GitHub
KKcorps opened a new pull request, #15623: URL: https://github.com/apache/pinot/pull/15623 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] Move Query Execution Planning to TableExecutionInfo in SSE [pinot]

2025-04-23 Thread via GitHub
yashmayya commented on code in PR #15523: URL: https://github.com/apache/pinot/pull/15523#discussion_r2055953278 ## pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java: ## @@ -199,128 +191,37 @@ private InstanceResponseBlock executeInter

Re: [PR] Broker selection for logical tables [pinot]

2025-04-23 Thread via GitHub
codecov-commenter commented on PR #15622: URL: https://github.com/apache/pinot/pull/15622#issuecomment-2824057805 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15622?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Allow configuring NOW() return type in the multi-stage engine [pinot]

2025-04-23 Thread via GitHub
yashmayya commented on PR #15610: URL: https://github.com/apache/pinot/pull/15610#issuecomment-2823995571 Closing this PR for now since we might want an alternate cleaner solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] Bump software.amazon.awssdk:bom from 2.31.26 to 2.31.27 [pinot]

2025-04-23 Thread via GitHub
codecov-commenter commented on PR #15621: URL: https://github.com/apache/pinot/pull/15621#issuecomment-2824027606 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15621?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Bump org.apache.commons:commons-collections4 from 4.4 to 4.5.0 [pinot]

2025-04-23 Thread via GitHub
codecov-commenter commented on PR #15620: URL: https://github.com/apache/pinot/pull/15620#issuecomment-2824022618 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15620?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Bump org.apache.commons:commons-collections4 from 4.4 to 4.5.0 [pinot]

2025-04-23 Thread via GitHub
dependabot[bot] opened a new pull request, #15620: URL: https://github.com/apache/pinot/pull/15620 Bumps org.apache.commons:commons-collections4 from 4.4 to 4.5.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name

[PR] Bump software.amazon.awssdk:bom from 2.31.26 to 2.31.27 [pinot]

2025-04-23 Thread via GitHub
dependabot[bot] opened a new pull request, #15621: URL: https://github.com/apache/pinot/pull/15621 Bumps software.amazon.awssdk:bom from 2.31.26 to 2.31.27. Most Recent Ignore Conditions Applied to This Pull Request | Dependency Name | Ignore Conditions | | --- | --- |

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.31.27 created (now 5812fc0309)

2025-04-23 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.31.27 in repository https://gitbox.apache.org/repos/asf/pinot.git at 5812fc0309 Bump software.amazon.awssdk:bom from 2.31.26 to 2.31.27 N

(pinot) branch dependabot/maven/org.apache.commons-commons-collections4-4.5.0 created (now c90b132b0e)

2025-04-23 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.commons-commons-collections4-4.5.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at c90b132b0e Bump org.apache.commons:commons-collections4 fr

(pinot) branch master updated (9f030bb0f2 -> 5d46d8c10d)

2025-04-23 Thread kharekartik
This is an automated email from the ASF dual-hosted git repository. kharekartik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 9f030bb0f2 Metrics that Tracks the Number of Table Rebalance Job In Progress (#15517) add 5d46d8c10d fix (#1

Re: [PR] Fixes a condition in ensureAllPartitionsConsuming to handle committing segment [pinot]

2025-04-23 Thread via GitHub
KKcorps merged PR #15552: URL: https://github.com/apache/pinot/pull/15552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

Re: [PR] Move Table Routing logic in SSE to TableRoute class [pinot]

2025-04-23 Thread via GitHub
vrajat commented on code in PR #15388: URL: https://github.com/apache/pinot/pull/15388#discussion_r2055752097 ## pinot-query-planner/src/main/java/org/apache/pinot/query/routing/table/TableRouteProvider.java: ## @@ -0,0 +1,135 @@ +/** + * Licensed to the Apache Software Foundati

Re: [PR] Kinesis partition split fixes [pinot]

2025-04-23 Thread via GitHub
krishan1390 commented on code in PR #15563: URL: https://github.com/apache/pinot/pull/15563#discussion_r2055639102 ## pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisStreamMetadataProvider.java: ## @@ -197,6 +197,14

Re: [PR] Kinesis partition split fixes [pinot]

2025-04-23 Thread via GitHub
krishan1390 commented on code in PR #15563: URL: https://github.com/apache/pinot/pull/15563#discussion_r2055316372 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -475,7 +475,10 @@ protected boolean consumeLoop()

Re: [PR] Add button to repair realtime table by triggering RealtimeSegmentValidationManager [pinot]

2025-04-23 Thread via GitHub
codecov-commenter commented on PR #15584: URL: https://github.com/apache/pinot/pull/15584#issuecomment-2823636064 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15584?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Adds Intgeration tests for Dedup and Pauseless [pinot]

2025-04-23 Thread via GitHub
KKcorps commented on code in PR #15398: URL: https://github.com/apache/pinot/pull/15398#discussion_r2055597335 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/PauselessRealtimeIngestionWithDedupIntegrationTest.java: ## @@ -0,0 +1,33 @@ +/** + * Licens

Re: [PR] Add button to repair realtime table by triggering RealtimeSegmentValidationManager [pinot]

2025-04-23 Thread via GitHub
KKcorps commented on code in PR #15584: URL: https://github.com/apache/pinot/pull/15584#discussion_r2055524139 ## pinot-controller/src/main/resources/app/pages/TenantDetails.tsx: ## @@ -466,6 +466,20 @@ const TenantPageDetails = ({ match }: RouteComponentProps) => { const

Re: [PR] Add button to repair realtime table by triggering RealtimeSegmentValidationManager [pinot]

2025-04-23 Thread via GitHub
KKcorps commented on code in PR #15584: URL: https://github.com/apache/pinot/pull/15584#discussion_r2055523642 ## pinot-controller/src/main/resources/app/utils/PinotMethodUtils.ts: ## @@ -1008,6 +1009,12 @@ const rebalanceBrokersForTableOp = (tableName) => { return response

Re: [PR] Add button to repair realtime table by triggering RealtimeSegmentValidationManager [pinot]

2025-04-23 Thread via GitHub
KKcorps commented on code in PR #15584: URL: https://github.com/apache/pinot/pull/15584#discussion_r2055531571 ## pinot-controller/src/main/resources/app/pages/TenantDetails.tsx: ## @@ -558,6 +572,13 @@ const TenantPageDetails = ({ match }: RouteComponentProps) => {

Re: [PR] byte-based splitting for mse query blocks [pinot]

2025-04-23 Thread via GitHub
codecov-commenter commented on PR #15571: URL: https://github.com/apache/pinot/pull/15571#issuecomment-2823434303 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15571?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Include stats on cancel [pinot]

2025-04-23 Thread via GitHub
gortiz commented on code in PR #15609: URL: https://github.com/apache/pinot/pull/15609#discussion_r2055487926 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java: ## @@ -443,11 +443,27 @@ private BrokerResponse query(QueryEnv

Re: [PR] Include stats on cancel [pinot]

2025-04-23 Thread via GitHub
gortiz commented on code in PR #15609: URL: https://github.com/apache/pinot/pull/15609#discussion_r2055477662 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java: ## @@ -443,11 +443,27 @@ private BrokerResponse query(QueryEnv

Re: [PR] Allow configuring NOW() return type in the multi-stage engine [pinot]

2025-04-23 Thread via GitHub
gortiz commented on code in PR #15610: URL: https://github.com/apache/pinot/pull/15610#discussion_r2055437922 ## pinot-query-planner/src/main/java/org/apache/pinot/calcite/sql/fun/PinotOperatorTable.java: ## @@ -67,10 +67,11 @@ */ @SuppressWarnings("unused") // unused fields