vrajat commented on PR #15388: URL: https://github.com/apache/pinot/pull/15388#issuecomment-2826348084
> `TableRouteInfo` is not really general. Is it introduced just for refactoring purpose? If so, let's only add the implementation for now without the interface because interface should be the general abstraction which also applies to the logical table It does apply to LogicalTable as well. Also an interface is required because `TableRouteInfo.getRequestMap` have different implementations and the two different implementations of that function is the core piece of that support. I can walk you through the implementation for logical tables if that will help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
