Jackie-Jiang commented on code in PR #15523:
URL: https://github.com/apache/pinot/pull/15523#discussion_r2056686085
##########
pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java:
##########
@@ -199,128 +190,36 @@ private InstanceResponseBlock
executeInternal(ServerQueryRequest queryRequest, E
return instanceResponse;
}
- TableDataManager tableDataManager =
_instanceDataManager.getTableDataManager(tableNameWithType);
- if (tableDataManager == null) {
- String errorMessage = "Failed to find table: " + tableNameWithType + "
on server: "
- + _instanceDataManager.getInstanceId();
+ TableExecutionInfo executionInfo =
+ SingleTableExecutionInfo.create(_instanceDataManager,
tableNameWithType, queryRequest.getSegmentsToQuery(),
+ queryRequest.getOptionalSegments(), queryContext);
+
+ if (executionInfo == null) {
Review Comment:
Suggest not using `null` to indicate table not found. We can first get the
`TableDataManager` here, then pass it into the
`SingleTableExecutionInfo.create()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
