rhodo commented on code in PR #15625:
URL: https://github.com/apache/pinot/pull/15625#discussion_r2056810259
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/channel/GrpcMailboxServer.java:
##########
@@ -49,24 +50,22 @@ public class GrpcMailboxServer extends
PinotMailboxGrpc.PinotMailboxImplBase {
public GrpcMailboxServer(MailboxService mailboxService, PinotConfiguration
config, @Nullable TlsConfig tlsConfig) {
_mailboxService = mailboxService;
int port = mailboxService.getPort();
+
+ PooledByteBufAllocator bufAllocator = PooledByteBufAllocator.DEFAULT;
Review Comment:
Since we are passing the same instance of allocator as GrpcQueryServer or
GrpcBorkerServer to GrpcMailboxServer. Either when GrpcMailboxServer running in
server or broker, its memory usage will automatically taken into account for
that component's grpc memory usage and we we don't need to register metrics
here again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
