vrajat commented on code in PR #15523:
URL: https://github.com/apache/pinot/pull/15523#discussion_r2056520779
##########
pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java:
##########
@@ -199,128 +191,37 @@ private InstanceResponseBlock
executeInternal(ServerQueryRequest queryRequest, E
return instanceResponse;
}
- TableDataManager tableDataManager =
_instanceDataManager.getTableDataManager(tableNameWithType);
- if (tableDataManager == null) {
- String errorMessage = "Failed to find table: " + tableNameWithType + "
on server: "
- + _instanceDataManager.getInstanceId();
+ TableExecutionInfo executionInfo;
+ try {
+ executionInfo =
Review Comment:
This is the whole block. `ServerQueryRequest` will have either `segments`
(and others) OR `TableRouteInfo` list. If `TableRoutInfo` list is available,
then logical table objects are created.
```
TableExecutionInfo executionInfo;
try {
if (queryRequest.getTableRouteInfos() != null &&
!queryRequest.getTableRouteInfos().isEmpty()) {
executionInfo =
LogicalTableExecutionInfo.create(_instanceDataManager, queryRequest,
queryContext);
} else {
executionInfo =
SingleTableExecutionInfo.create(_instanceDataManager,
tableNameWithType, queryRequest.getSegmentsToQuery(),
queryRequest.getOptionalSegments(), queryContext);
}
} catch (NoSuchElementException ne) {
String errorMessage =
"Failed to find table: " + ne.getMessage() + " on server: " +
_instanceDataManager.getInstanceId();
InstanceResponseBlock instanceResponse = new InstanceResponseBlock();
instanceResponse.addException(QueryErrorCode.SERVER_TABLE_MISSING,
errorMessage);
LOGGER.error("{} while processing requestId: {}", errorMessage,
requestId);
return instanceResponse;
}
```
The POC is in https://github.com/apache/pinot/pull/15151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
