ankitsultana commented on code in PR #15604:
URL: https://github.com/apache/pinot/pull/15604#discussion_r2057503988
##########
pinot-plugins/pinot-timeseries-lang/pinot-timeseries-m3ql/src/main/java/org/apache/pinot/tsdb/m3ql/M3TimeSeriesPlanner.java:
##########
@@ -48,7 +49,7 @@ public void init(PinotConfiguration pinotConfiguration) {
}
@Override
- public TimeSeriesLogicalPlanResult plan(RangeTimeSeriesRequest request) {
+ public TimeSeriesLogicalPlanResult plan(RangeTimeSeriesRequest request,
List<TableConfig> tableConfigs) {
Review Comment:
I think the right way to do this is to add a Function<String, TableConfig>
which can return tableConfigs for a given raw table name.
This is because RangeTimeSeriesRequest is not aware of the tables being
queried and that is only known once you parse the query out using language
specific parsers.
However, using Function directly is quite limiting and not a great idea, so
we can create a new `MetadataProvider` interface which has a single method
`List<TableConfig> getTableConfigs(String rawTableName)`. Later we can add more
methods to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
