rhodo opened a new pull request, #15625: URL: https://github.com/apache/pinot/pull/15625
First this PR refactor our current server init logic a bit. `ServerBuilder.forPort(port)` will load the first implementation in the classpath which is almost always to be NettyServerBuilder but it is good to make it more deterministic. Also we don't really enforce `maxInboundMessageSize` when using ServerBuilder so fix this small bug along the way. Adding metrics for grpc server similar as we did for query server ([ref](https://sourcegraph.com/github.com/apache/pinot/-/blob/pinot-core/src/main/java/org/apache/pinot/core/transport/QueryServer.java?L125-132)), right now we pass in default pooled allocator but can later use a different implementation. I am also using a dedicate set of metrics for grpc netty, but can also reuse the same set of metrics from query server. ## testing send a query that shall return large grpc response. Can see the newly added direct memory goes up  meanwhile old direct memory metrics for query server is still flat.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
