Re: [PR] Allow configuring NOW() return type in the multi-stage engine [pinot]

2025-04-22 Thread via GitHub
gortiz commented on PR #15610: URL: https://github.com/apache/pinot/pull/15610#issuecomment-2823158541 Having the query option is required because it allows users to try both versions of the query in the same cluster. Otherwise, they would need to either have two clusters or change the opti

Re: [PR] Add TableSegmentsInfo to Thrift and Proto to broker/server messages [pinot]

2025-04-22 Thread via GitHub
vrajat commented on code in PR #15573: URL: https://github.com/apache/pinot/pull/15573#discussion_r2055259012 ## pinot-common/src/main/proto/server.proto: ## @@ -25,11 +25,18 @@ service PinotQueryServer { rpc Submit(ServerRequest) returns (stream ServerResponse); } +messag

Re: [PR] [multistage] Minor Changes to Support Physical Optimizer Related Changes [pinot]

2025-04-22 Thread via GitHub
ankitsultana commented on code in PR #15562: URL: https://github.com/apache/pinot/pull/15562#discussion_r2055258636 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/exchange/SingletonExchange.java: ## @@ -38,9 +37,7 @@ class SingletonExchange extends

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

2025-04-22 Thread via GitHub
somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2055214455 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -598,9 +611,12 @@ private RebalanceResult doRebalance(Ta

Re: [PR] Metrics for Segment Upload/Download [pinot]

2025-04-22 Thread via GitHub
praveenc7 commented on PR #15585: URL: https://github.com/apache/pinot/pull/15585#issuecomment-2822985353 > lgtm, here are some suggestions for the metric names `DEEP_STORE_WRITE_BYTES_IN_PROGRESS DEEP_STORE_WRITE_OPS_IN_PROGRESS DEEP_STORE_READ_OPS_IN_PROGRESS DEEP_STORE_READ_BYTES_IN_PROG

Re: [PR] Metrics for Segment Upload/Download [pinot]

2025-04-22 Thread via GitHub
praveenc7 commented on PR #15585: URL: https://github.com/apache/pinot/pull/15585#issuecomment-2822811704 @jackjlli @mcvsubbu Updated the code to reflect the new metrics as discussed, it is ready for another round of review. -- This is an automated message from the Apache Git Service. To

Re: [PR] Metrics for Segment Upload/Download [pinot]

2025-04-22 Thread via GitHub
praveenc7 commented on code in PR #15585: URL: https://github.com/apache/pinot/pull/15585#discussion_r2055097104 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java: ## @@ -214,8 +217,19 @@ public Response do

Re: [PR] Metrics for Segment Upload/Download [pinot]

2025-04-22 Thread via GitHub
praveenc7 commented on code in PR #15585: URL: https://github.com/apache/pinot/pull/15585#discussion_r2055097387 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/Server2ControllerSegmentUploader.java: ## @@ -91,6 +92,8 @@ private SegmentCompletionProtocol.

Re: [PR] Metrics for Segment Upload/Download [pinot]

2025-04-22 Thread via GitHub
praveenc7 commented on code in PR #15585: URL: https://github.com/apache/pinot/pull/15585#discussion_r2055095131 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerTimer.java: ## @@ -43,8 +43,13 @@ public enum ServerTimer implements AbstractMetrics.Timer {

Re: [PR] Metrics for Segment Upload/Download [pinot]

2025-04-22 Thread via GitHub
praveenc7 commented on code in PR #15585: URL: https://github.com/apache/pinot/pull/15585#discussion_r2055094779 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerTimer.java: ## @@ -43,8 +43,13 @@ public enum ServerTimer implements AbstractMetrics.Timer {

Re: [PR] Metrics for Segment Upload/Download [pinot]

2025-04-22 Thread via GitHub
praveenc7 commented on code in PR #15585: URL: https://github.com/apache/pinot/pull/15585#discussion_r2055094931 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerTimer.java: ## @@ -43,8 +43,13 @@ public enum ServerTimer implements AbstractMetrics.Timer {

Re: [PR] Replace RebalanceConfig.MinimizeDataMovementOptions with Enablement [pinot]

2025-04-22 Thread via GitHub
somandal commented on code in PR #15619: URL: https://github.com/apache/pinot/pull/15619#discussion_r2055077997 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -104,17 +106,15 @@ public InstancePar

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

2025-04-22 Thread via GitHub
somandal commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2055075416 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -479,6 +482,16 @@ private RebalanceResult doRebalance(Ta

Re: [PR] Replace RebalanceConfig.MinimizeDataMovementOptions with Enablement [pinot]

2025-04-22 Thread via GitHub
codecov-commenter commented on PR #15619: URL: https://github.com/apache/pinot/pull/15619#issuecomment-2822752566 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15619?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] WIP: Dynamic timeout for EV convergence in table rebalance [pinot]

2025-04-22 Thread via GitHub
codecov-commenter commented on PR #15618: URL: https://github.com/apache/pinot/pull/15618#issuecomment-2822736029 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15618?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add TableSegmentsInfo to Thrift and Proto to broker/server messages [pinot]

2025-04-22 Thread via GitHub
Jackie-Jiang commented on code in PR #15573: URL: https://github.com/apache/pinot/pull/15573#discussion_r2055052401 ## pinot-common/src/main/proto/server.proto: ## @@ -25,11 +25,18 @@ service PinotQueryServer { rpc Submit(ServerRequest) returns (stream ServerResponse); } +

Re: [PR] Move Table Routing logic in SSE to TableRoute class [pinot]

2025-04-22 Thread via GitHub
Jackie-Jiang commented on code in PR #15388: URL: https://github.com/apache/pinot/pull/15388#discussion_r2055048738 ## pinot-query-planner/src/main/java/org/apache/pinot/query/routing/table/TableRouteProvider.java: ## @@ -0,0 +1,135 @@ +/** + * Licensed to the Apache Software Fo

[PR] Replace RebalanceConfig.MinimizeDataMovementOptions with Enablement [pinot]

2025-04-22 Thread via GitHub
Jackie-Jiang opened a new pull request, #15619: URL: https://github.com/apache/pinot/pull/15619 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] WIP: Dynamic timeout for EV convergence in table rebalance [pinot]

2025-04-22 Thread via GitHub
J-HowHuang opened a new pull request, #15618: URL: https://github.com/apache/pinot/pull/15618 ## Description It is usually difficult to decide the timeout (`externalViewStabilizationTimeoutInMs`). Consequently, some larger tables fail to finish a rebalance job because they take longer th

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

2025-04-22 Thread via GitHub
Jackie-Jiang commented on code in PR #15617: URL: https://github.com/apache/pinot/pull/15617#discussion_r2054996050 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -479,6 +482,16 @@ private RebalanceResult doRebalanc

Re: [PR] Metrics that Tracks the Progress of each Table Rebalance Job [pinot]

2025-04-22 Thread via GitHub
somandal commented on code in PR #15518: URL: https://github.com/apache/pinot/pull/15518#discussion_r2054989895 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/ControllerGauge.java: ## @@ -207,7 +207,12 @@ public enum ControllerGauge implements AbstractMetrics.Gau

Re: [PR] Metrics that Tracks the Progress of each Table Rebalance Job [pinot]

2025-04-22 Thread via GitHub
J-HowHuang commented on code in PR #15518: URL: https://github.com/apache/pinot/pull/15518#discussion_r2054988786 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/ControllerGauge.java: ## @@ -207,7 +207,12 @@ public enum ControllerGauge implements AbstractMetrics.G

Re: [PR] [multistage] Minor Changes to Support Physical Optimizer Related Changes [pinot]

2025-04-22 Thread via GitHub
Jackie-Jiang commented on code in PR #15562: URL: https://github.com/apache/pinot/pull/15562#discussion_r2054981900 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/exchange/SingletonExchange.java: ## @@ -38,9 +37,7 @@ class SingletonExchange extends

Re: [PR] Add a New Pre-check Item for Replica Groups Info [pinot]

2025-04-22 Thread via GitHub
J-HowHuang commented on code in PR #15575: URL: https://github.com/apache/pinot/pull/15575#discussion_r2054977045 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/TableRebalanceIntegrationTest.java: ## @@ -0,0 +1,1170 @@ +/** + * Licensed to the Apache

Re: [PR] Adding variation to segment flush size [pinot]

2025-04-22 Thread via GitHub
Jackie-Jiang commented on PR #14170: URL: https://github.com/apache/pinot/pull/14170#issuecomment-2822612105 @lnbest0707-uber Good catch! I've fixed the description for this PR. Do you want to help fix the test? Seems the javadoc is of the valid range is also incorrect. Based on the code it

Re: [PR] Include stats on cancel [pinot]

2025-04-22 Thread via GitHub
Jackie-Jiang commented on code in PR #15609: URL: https://github.com/apache/pinot/pull/15609#discussion_r2054972689 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java: ## @@ -443,11 +443,27 @@ private BrokerResponse query(Qu

Re: [PR] Add a New Pre-check Item for Replica Groups Info [pinot]

2025-04-22 Thread via GitHub
somandal commented on code in PR #15575: URL: https://github.com/apache/pinot/pull/15575#discussion_r2054954239 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/TableRebalanceIntegrationTest.java: ## @@ -0,0 +1,1170 @@ +/** + * Licensed to the Apache S

Re: [PR] Add a New Pre-check Item for Replica Groups Info [pinot]

2025-04-22 Thread via GitHub
J-HowHuang commented on code in PR #15575: URL: https://github.com/apache/pinot/pull/15575#discussion_r2054952109 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/TableRebalanceIntegrationTest.java: ## @@ -0,0 +1,1170 @@ +/** + * Licensed to the Apache

Re: [PR] Metrics that Tracks the Progress of each Table Rebalance Job [pinot]

2025-04-22 Thread via GitHub
somandal commented on code in PR #15518: URL: https://github.com/apache/pinot/pull/15518#discussion_r2054944838 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/ControllerGauge.java: ## @@ -207,7 +207,12 @@ public enum ControllerGauge implements AbstractMetrics.Gau

Re: [PR] Metrics that Tracks the Progress of each Table Rebalance Job [pinot]

2025-04-22 Thread via GitHub
somandal commented on code in PR #15518: URL: https://github.com/apache/pinot/pull/15518#discussion_r2054935551 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalanceProgressStats.java: ## @@ -234,8 +236,13 @@ public void updateOverallA

Re: [PR] Add a New Pre-check Item for Replica Groups Info [pinot]

2025-04-22 Thread via GitHub
somandal commented on code in PR #15575: URL: https://github.com/apache/pinot/pull/15575#discussion_r2054920341 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/TableRebalanceIntegrationTest.java: ## @@ -0,0 +1,1170 @@ +/** + * Licensed to the Apache S

Re: [PR] Add a New Pre-check Item for Replica Groups Info [pinot]

2025-04-22 Thread via GitHub
somandal commented on code in PR #15575: URL: https://github.com/apache/pinot/pull/15575#discussion_r2054868409 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/TableRebalanceIntegrationTest.java: ## @@ -0,0 +1,1170 @@ +/** + * Licensed to the Apache S

Re: [PR] Adding variation to segment flush size [pinot]

2025-04-22 Thread via GitHub
lnbest0707-uber commented on code in PR #14170: URL: https://github.com/apache/pinot/pull/14170#discussion_r2054919563 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/realtime/segment/SegmentFlushThresholdComputerTest.java: ## @@ -302,4 +304,27 @@ public

Re: [PR] Adding variation to segment flush size [pinot]

2025-04-22 Thread via GitHub
lnbest0707-uber commented on code in PR #14170: URL: https://github.com/apache/pinot/pull/14170#discussion_r2054918406 ## pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamConfigProperties.java: ## @@ -111,6 +111,13 @@ private StreamConfigProperties() { public static

Re: [PR] Add a New Pre-check Item for Replica Groups Info [pinot]

2025-04-22 Thread via GitHub
J-HowHuang commented on code in PR #15575: URL: https://github.com/apache/pinot/pull/15575#discussion_r2054914910 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/TableRebalanceIntegrationTest.java: ## @@ -0,0 +1,1170 @@ +/** + * Licensed to the Apache

Re: [PR] Allow configuring NOW() return type in the multi-stage engine [pinot]

2025-04-22 Thread via GitHub
Jackie-Jiang commented on PR #15610: URL: https://github.com/apache/pinot/pull/15610#issuecomment-2822476703 Let's hold off a little bit on this PR. In the long term we want to move to standard (PostgreSQL) behavior, so the question is how to provide smooth migration. Having a cluster confi

Re: [PR] Metrics for Segment Upload/Download [pinot]

2025-04-22 Thread via GitHub
jackjlli commented on code in PR #15585: URL: https://github.com/apache/pinot/pull/15585#discussion_r2054775407 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java: ## @@ -214,8 +217,19 @@ public Response dow

Re: [PR] Table Rebalance: Add support for server-level segment batching [pinot]

2025-04-22 Thread via GitHub
codecov-commenter commented on PR #15617: URL: https://github.com/apache/pinot/pull/15617#issuecomment-2822368891 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15617?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Metrics for Segment Upload/Download [pinot]

2025-04-22 Thread via GitHub
mcvsubbu commented on PR #15585: URL: https://github.com/apache/pinot/pull/15585#issuecomment-2822356613 We chatted briefly, and decided the following metrics should be good for now, all at controller level: - A gauge that is bumped up before we start copying from PinotFS to localFS, and

Re: [PR] [Do Not Merge] Add logs for testing / debugging [pinot]

2025-04-22 Thread via GitHub
somandal closed pull request #15551: [Do Not Merge] Add logs for testing / debugging URL: https://github.com/apache/pinot/pull/15551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[PR] Table Rebalance: Add support for server-level batching [pinot]

2025-04-22 Thread via GitHub
somandal opened a new pull request, #15617: URL: https://github.com/apache/pinot/pull/15617 This PR adds support for server-level batching (i.e. how many segment adds to batch at a server level) in Table rebalance. A new `RebalanceConfig` called `batchSizePerServer` has also been added. By

Re: [PR] Kinesis partition split fixes [pinot]

2025-04-22 Thread via GitHub
KKcorps commented on code in PR #15563: URL: https://github.com/apache/pinot/pull/15563#discussion_r2054658526 ## pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisStreamMetadataProvider.java: ## @@ -197,6 +197,14 @@ p

Re: [PR] Kinesis partition split fixes [pinot]

2025-04-22 Thread via GitHub
KKcorps commented on code in PR #15563: URL: https://github.com/apache/pinot/pull/15563#discussion_r2054663147 ## pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisConsumer.java: ## @@ -93,11 +93,31 @@ private KinesisM

Re: [PR] Kinesis partition split fixes [pinot]

2025-04-22 Thread via GitHub
KKcorps commented on code in PR #15563: URL: https://github.com/apache/pinot/pull/15563#discussion_r2054656170 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -994,15 +994,17 @@ Set getPartitionIds(Stre

Re: [PR] Kinesis partition split fixes [pinot]

2025-04-22 Thread via GitHub
KKcorps commented on code in PR #15563: URL: https://github.com/apache/pinot/pull/15563#discussion_r2054650757 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -475,7 +475,10 @@ protected boolean consumeLoop()

Re: [PR] Metrics for Segment Upload/Download [pinot]

2025-04-22 Thread via GitHub
mcvsubbu commented on PR #15585: URL: https://github.com/apache/pinot/pull/15585#issuecomment-2822103228 Most, if not all of these should be gauges right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Metrics that Tracks the Number of Table Rebalance Job In Progress [pinot]

2025-04-22 Thread via GitHub
somandal merged PR #15517: URL: https://github.com/apache/pinot/pull/15517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

(pinot) branch master updated (2fbde65027 -> 9f030bb0f2)

2025-04-22 Thread somandal
This is an automated email from the ASF dual-hosted git repository. somandal pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 2fbde65027 Bump org.webjars:swagger-ui from 5.20.7 to 5.21.0 (#15613) add 9f030bb0f2 Metrics that Tracks the Num

Re: [PR] Metrics for Segment Upload/Download [pinot]

2025-04-22 Thread via GitHub
siddharthteotia commented on code in PR #15585: URL: https://github.com/apache/pinot/pull/15585#discussion_r2054581153 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/ControllerTimer.java: ## @@ -30,7 +30,16 @@ public enum ControllerTimer implements AbstractMetrics

Re: [PR] Metrics for Segment Upload/Download [pinot]

2025-04-22 Thread via GitHub
siddharthteotia commented on code in PR #15585: URL: https://github.com/apache/pinot/pull/15585#discussion_r2054572856 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerTimer.java: ## @@ -43,8 +43,13 @@ public enum ServerTimer implements AbstractMetrics.Timer {

Re: [PR] Metrics for Segment Upload/Download [pinot]

2025-04-22 Thread via GitHub
siddharthteotia commented on code in PR #15585: URL: https://github.com/apache/pinot/pull/15585#discussion_r2054580241 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/ControllerTimer.java: ## @@ -30,7 +30,16 @@ public enum ControllerTimer implements AbstractMetrics

Re: [PR] Metrics for Segment Upload/Download [pinot]

2025-04-22 Thread via GitHub
siddharthteotia commented on code in PR #15585: URL: https://github.com/apache/pinot/pull/15585#discussion_r2054579306 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerTimer.java: ## @@ -43,8 +43,13 @@ public enum ServerTimer implements AbstractMetrics.Timer {

Re: [PR] Metrics for Segment Upload/Download [pinot]

2025-04-22 Thread via GitHub
siddharthteotia commented on code in PR #15585: URL: https://github.com/apache/pinot/pull/15585#discussion_r2054575939 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerTimer.java: ## @@ -43,8 +43,13 @@ public enum ServerTimer implements AbstractMetrics.Timer {

Re: [PR] Metrics for Segment Upload/Download [pinot]

2025-04-22 Thread via GitHub
siddharthteotia commented on code in PR #15585: URL: https://github.com/apache/pinot/pull/15585#discussion_r2054575185 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerTimer.java: ## @@ -43,8 +43,13 @@ public enum ServerTimer implements AbstractMetrics.Timer {

Re: [PR] Metrics for Segment Upload/Download [pinot]

2025-04-22 Thread via GitHub
siddharthteotia commented on code in PR #15585: URL: https://github.com/apache/pinot/pull/15585#discussion_r2054569260 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerTimer.java: ## @@ -43,8 +43,13 @@ public enum ServerTimer implements AbstractMetrics.Timer {

Re: [PR] Metrics for Segment Upload/Download [pinot]

2025-04-22 Thread via GitHub
siddharthteotia commented on code in PR #15585: URL: https://github.com/apache/pinot/pull/15585#discussion_r2054567589 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerTimer.java: ## @@ -43,8 +43,13 @@ public enum ServerTimer implements AbstractMetrics.Timer {

Re: [PR] Metrics for Segment Upload/Download [pinot]

2025-04-22 Thread via GitHub
siddharthteotia commented on code in PR #15585: URL: https://github.com/apache/pinot/pull/15585#discussion_r2054565571 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerTimer.java: ## @@ -43,8 +43,13 @@ public enum ServerTimer implements AbstractMetrics.Timer {

(pinot) branch dependabot/maven/org.webjars-swagger-ui-5.21.0 deleted (was 6283d966ad)

2025-04-22 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a change to branch dependabot/maven/org.webjars-swagger-ui-5.21.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was 6283d966ad Bump org.webjars:swagger-ui from 5.20.7 to 5.21.0 The revisions

(pinot) branch master updated: Bump software.amazon.awssdk:bom from 2.31.25 to 2.31.26 (#15614)

2025-04-22 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 7c33ada540 Bump software.amazon.awssdk:bom fro

(pinot) branch master updated (7c33ada540 -> 2fbde65027)

2025-04-22 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 7c33ada540 Bump software.amazon.awssdk:bom from 2.31.25 to 2.31.26 (#15614) add 2fbde65027 Bump org.webjars:sw

Re: [PR] Bump org.webjars:swagger-ui from 5.20.7 to 5.21.0 [pinot]

2025-04-22 Thread via GitHub
yashmayya merged PR #15613: URL: https://github.com/apache/pinot/pull/15613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.31.26 deleted (was 93c3e4db66)

2025-04-22 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.31.26 in repository https://gitbox.apache.org/repos/asf/pinot.git was 93c3e4db66 Bump software.amazon.awssdk:bom from 2.31.25 to 2.31.26 Th

Re: [PR] Bump software.amazon.awssdk:bom from 2.31.25 to 2.31.26 [pinot]

2025-04-22 Thread via GitHub
yashmayya merged PR #15614: URL: https://github.com/apache/pinot/pull/15614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

Re: [PR] Fix JsonExtractIndex with null handling enabled [pinot]

2025-04-22 Thread via GitHub
codecov-commenter commented on PR #15616: URL: https://github.com/apache/pinot/pull/15616#issuecomment-2821550236 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15616?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [I] JSON_EXTRACT_INDEX null pointer exception, this._arguments is null [pinot]

2025-04-22 Thread via GitHub
yashmayya commented on issue #15516: URL: https://github.com/apache/pinot/issues/15516#issuecomment-2821413109 Yeah, this is reproducible on both SSE and MSE via this query in a quickstart: ``` SET enableNullHandling=true; select JSON_EXTRACT_INDEX(actor, '$.id', 'LONG') from gi

Re: [PR] Modify parser to support type aliases like LONG for BIGINT in MSE [pinot]

2025-04-22 Thread via GitHub
codecov-commenter commented on PR #15615: URL: https://github.com/apache/pinot/pull/15615#issuecomment-2821413086 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15615?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Fix JsonExtractIndex with null handling enabled [pinot]

2025-04-22 Thread via GitHub
yashmayya opened a new pull request, #15616: URL: https://github.com/apache/pinot/pull/15616 - Fixes https://github.com/apache/pinot/issues/15516 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [I] JSON_EXTRACT_INDEX null pointer exception, this._arguments is null [pinot]

2025-04-22 Thread via GitHub
yashmayya commented on issue #15516: URL: https://github.com/apache/pinot/issues/15516#issuecomment-2821326706 Strange, there aren't any commits on `JsonExtractIndexTransformFunction` between the two versions - https://github.com/apache/pinot/commits/release-1.2.0/pinot-core/src/main/java/o

[PR] Modify parser to support type aliases like LONG for BIGINT in MSE [pinot]

2025-04-22 Thread via GitHub
yashmayya opened a new pull request, #15615: URL: https://github.com/apache/pinot/pull/15615 - This patch updates the parser to support the following type aliases: - `BIG_DECIMAL` for `DECIMAL` - `BYTES` for `VARBINARY` - `LONG` for `BIGINT` - `STRING` for `VARCHAR` - T

Re: [PR] Bump software.amazon.awssdk:bom from 2.31.25 to 2.31.26 [pinot]

2025-04-22 Thread via GitHub
codecov-commenter commented on PR #15614: URL: https://github.com/apache/pinot/pull/15614#issuecomment-2821172586 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15614?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Bump org.webjars:swagger-ui from 5.20.7 to 5.21.0 [pinot]

2025-04-22 Thread via GitHub
codecov-commenter commented on PR #15613: URL: https://github.com/apache/pinot/pull/15613#issuecomment-2821172321 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15613?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Bump com.adobe.testing:s3mock-testcontainers from 2.17.0 to 4.1.1 [pinot]

2025-04-22 Thread via GitHub
codecov-commenter commented on PR #15612: URL: https://github.com/apache/pinot/pull/15612#issuecomment-2821166510 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15612?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Bump com.adobe.testing:s3mock-testcontainers from 2.17.0 to 4.0.0 [pinot]

2025-04-22 Thread via GitHub
dependabot[bot] closed pull request #15505: Bump com.adobe.testing:s3mock-testcontainers from 2.17.0 to 4.0.0 URL: https://github.com/apache/pinot/pull/15505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] Reduce segment metadata memory overhead. [pinot]

2025-04-22 Thread via GitHub
bziobrowski commented on code in PR #15591: URL: https://github.com/apache/pinot/pull/15591#discussion_r2053962702 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/column/PhysicalColumnIndexContainer.java: ## @@ -39,7 +39,11 @@ public final clas

Re: [PR] Reduce segment metadata memory overhead. [pinot]

2025-04-22 Thread via GitHub
bziobrowski commented on code in PR #15591: URL: https://github.com/apache/pinot/pull/15591#discussion_r2053962702 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/column/PhysicalColumnIndexContainer.java: ## @@ -39,7 +39,11 @@ public final clas

Re: [I] Multi-stage: Perf issue when IN expression has a lot of entries [pinot]

2025-04-22 Thread via GitHub
yashmayya closed issue #13617: Multi-stage: Perf issue when IN expression has a lot of entries URL: https://github.com/apache/pinot/issues/13617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

(pinot) branch master updated: Upgrade Calcite to 1.39.0 (#15263)

2025-04-22 Thread yashmayya
This is an automated email from the ASF dual-hosted git repository. yashmayya pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new ceee8c59aa Upgrade Calcite to 1.39.0 (#15263)

Re: [PR] Upgrade Calcite to 1.39.0 [pinot]

2025-04-22 Thread via GitHub
yashmayya merged PR #15263: URL: https://github.com/apache/pinot/pull/15263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

Re: [PR] Fix multi-stage case insensitiveness [pinot]

2025-04-22 Thread via GitHub
codecov-commenter commented on PR #15611: URL: https://github.com/apache/pinot/pull/15611#issuecomment-2821079714 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15611?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) branch dependabot/maven/org.webjars-swagger-ui-5.21.0 created (now 6283d966ad)

2025-04-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.webjars-swagger-ui-5.21.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at 6283d966ad Bump org.webjars:swagger-ui from 5.20.7 to 5.21.0 No new revis

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.31.26 created (now 93c3e4db66)

2025-04-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.31.26 in repository https://gitbox.apache.org/repos/asf/pinot.git at 93c3e4db66 Bump software.amazon.awssdk:bom from 2.31.25 to 2.31.26 N

[PR] Bump software.amazon.awssdk:bom from 2.31.25 to 2.31.26 [pinot]

2025-04-22 Thread via GitHub
dependabot[bot] opened a new pull request, #15614: URL: https://github.com/apache/pinot/pull/15614 Bumps software.amazon.awssdk:bom from 2.31.25 to 2.31.26. Most Recent Ignore Conditions Applied to This Pull Request | Dependency Name | Ignore Conditions | | --- | --- |

[PR] Bump org.webjars:swagger-ui from 5.20.7 to 5.21.0 [pinot]

2025-04-22 Thread via GitHub
dependabot[bot] opened a new pull request, #15613: URL: https://github.com/apache/pinot/pull/15613 Bumps [org.webjars:swagger-ui](https://github.com/swagger-api/swagger-ui) from 5.20.7 to 5.21.0. Release notes Sourced from https://github.com/swagger-api/swagger-ui/releases";>org.we

(pinot) branch dependabot/maven/com.adobe.testing-s3mock-testcontainers-4.0.0 deleted (was e2e272a8f5)

2025-04-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.adobe.testing-s3mock-testcontainers-4.0.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was e2e272a8f5 Bump com.adobe.testing:s3mock-testcontainers fr

(pinot) branch dependabot/maven/com.adobe.testing-s3mock-testcontainers-4.1.1 created (now c22352d2f5)

2025-04-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.adobe.testing-s3mock-testcontainers-4.1.1 in repository https://gitbox.apache.org/repos/asf/pinot.git at c22352d2f5 Bump com.adobe.testing:s3mock-testcontainers fr

Re: [PR] Bump com.adobe.testing:s3mock-testcontainers from 2.17.0 to 4.0.0 [pinot]

2025-04-22 Thread via GitHub
dependabot[bot] commented on PR #15505: URL: https://github.com/apache/pinot/pull/15505#issuecomment-2821061624 Superseded by #15612. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Bump com.adobe.testing:s3mock-testcontainers from 2.17.0 to 4.1.1 [pinot]

2025-04-22 Thread via GitHub
dependabot[bot] opened a new pull request, #15612: URL: https://github.com/apache/pinot/pull/15612 Bumps com.adobe.testing:s3mock-testcontainers from 2.17.0 to 4.1.1. Most Recent Ignore Conditions Applied to This Pull Request | Dependency Name | Ignore Conditions | | ---

Re: [PR] Kinesis partition split fixes [pinot]

2025-04-22 Thread via GitHub
krishan1390 commented on code in PR #15563: URL: https://github.com/apache/pinot/pull/15563#discussion_r2053925767 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -994,15 +994,17 @@ Set getPartitionIds(

Re: [PR] Kinesis partition split fixes [pinot]

2025-04-22 Thread via GitHub
Copilot commented on code in PR #15563: URL: https://github.com/apache/pinot/pull/15563#discussion_r2053894693 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -994,15 +994,17 @@ Set getPartitionIds(Stre

Re: [PR] reverse MSE case-insensitive capabilities [pinot]

2025-04-22 Thread via GitHub
albertobastos closed pull request #15565: reverse MSE case-insensitive capabilities URL: https://github.com/apache/pinot/pull/15565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Upgrade Calcite to 1.39.0 [pinot]

2025-04-22 Thread via GitHub
yashmayya commented on code in PR #15263: URL: https://github.com/apache/pinot/pull/15263#discussion_r2053818467 ## pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotEvaluateLiteralRule.java: ## @@ -258,13 +275,18 @@ private static Object convertResultVal

Re: [PR] PINOT-17: Fix baseURL for Knox Gateway compatibility [pinot]

2025-04-22 Thread via GitHub
userhimanshuverma commented on PR #15596: URL: https://github.com/apache/pinot/pull/15596#issuecomment-2820922961 Hi @yashmayya @jayeshchoudhary Could you please look into this and let me know if any clarification is required. -- This is an automated message from the Apache Git Service.

Re: [PR] Reduce segment metadata memory overhead. [pinot]

2025-04-22 Thread via GitHub
bziobrowski commented on code in PR #15591: URL: https://github.com/apache/pinot/pull/15591#discussion_r2053820854 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/metadata/ColumnMetadataImpl.java: ## @@ -164,10 +172,40 @@ public Set getPartitions() { r

Re: [PR] Upgrade Calcite to 1.39.0 [pinot]

2025-04-22 Thread via GitHub
yashmayya commented on code in PR #15263: URL: https://github.com/apache/pinot/pull/15263#discussion_r2053818467 ## pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotEvaluateLiteralRule.java: ## @@ -258,13 +275,18 @@ private static Object convertResultVal

Re: [PR] Reduce segment metadata memory overhead. [pinot]

2025-04-22 Thread via GitHub
bziobrowski commented on code in PR #15591: URL: https://github.com/apache/pinot/pull/15591#discussion_r2053811235 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/column/PhysicalColumnIndexContainer.java: ## @@ -39,7 +39,11 @@ public final clas

Re: [PR] Allow configuring NOW() return type in the multi-stage engine [pinot]

2025-04-22 Thread via GitHub
codecov-commenter commented on PR #15610: URL: https://github.com/apache/pinot/pull/15610#issuecomment-2820826613 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15610?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Kinesis partition split fixes [pinot]

2025-04-22 Thread via GitHub
krishan1390 commented on code in PR #15563: URL: https://github.com/apache/pinot/pull/15563#discussion_r2052306825 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1651,13 +1655,17 @@ private void creat

Re: [PR] Kinesis partition split fixes [pinot]

2025-04-22 Thread via GitHub
krishan1390 commented on code in PR #15563: URL: https://github.com/apache/pinot/pull/15563#discussion_r2052300098 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PauseStatusDetails.java: ## @@ -65,4 +66,11 @@ public String getComment() { public St

[PR] Allow configuring NOW() return type in the multi-stage engine [pinot]

2025-04-22 Thread via GitHub
yashmayya opened a new pull request, #15610: URL: https://github.com/apache/pinot/pull/15610 - https://github.com/apache/pinot/pull/14614 updated the return type of `NOW()` from `LONG` / `BIGINT` to `TIMESTAMP`. This was done in order to allow usage of `NOW()` with functions that expect tim

Re: [PR] Include stats on cancel [pinot]

2025-04-22 Thread via GitHub
codecov-commenter commented on PR #15609: URL: https://github.com/apache/pinot/pull/15609#issuecomment-2820372082 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15609?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

  1   2   >