somandal commented on code in PR #15518:
URL: https://github.com/apache/pinot/pull/15518#discussion_r2054989895
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ControllerGauge.java:
##########
@@ -207,7 +207,12 @@ public enum ControllerGauge implements
AbstractMetrics.Gauge {
PAUSELESS_SEGMENTS_IN_UNRECOVERABLE_ERROR_COUNT("pauselessSegmentsInUnrecoverableErrorCount",
false),
// ZK JUTE max buffer size in bytes
- ZK_JUTE_MAX_BUFFER("zkJuteMaxBuffer", true);
+ ZK_JUTE_MAX_BUFFER("zkJuteMaxBuffer", true),
+
+ // The progress of a certain table rebalance job of a table
+ TABLE_REBALANCE_JOB_ADDITION_PROGRESS_PERCENT("percent", false),
+ TABLE_REBALANCE_JOB_DELETION_PROGRESS_PERCENT("percent", false);
Review Comment:
yeah i guess it is fine. if we make these metrics "progress remaining" then
it could be confusing. fine with leaving as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
