somandal commented on code in PR #15518:
URL: https://github.com/apache/pinot/pull/15518#discussion_r2054935551
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalanceProgressStats.java:
##########
@@ -234,8 +236,13 @@ public void updateOverallAndStepStatsFromLatestStepStats(
}
public static double calculatePercentageChange(int totalSegmentsToChange,
int remainingSegmentsToChange) {
- return totalSegmentsToChange == 0
- ? 0.0 : (double) remainingSegmentsToChange / (double)
totalSegmentsToChange * 100.0;
+ if (totalSegmentsToChange == 0) {
Review Comment:
oh can we not change the progress stats themselves and only have the metric
emit progress done instead of remaining?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
