somandal commented on code in PR #15617:
URL: https://github.com/apache/pinot/pull/15617#discussion_r2055214455
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -598,9 +611,12 @@ private RebalanceResult doRebalance(TableConfig
tableConfig, RebalanceConfig reb
"Rebalance has stopped already before updating the IdealState",
instancePartitionsMap,
tierToInstancePartitionsMap, targetAssignment, preChecksResult,
summaryResult);
}
+ String partitionColumn =
TableConfigUtils.getPartitionColumn(tableConfig);
Map<String, Map<String, String>> nextAssignment =
getNextAssignment(currentAssignment, targetAssignment,
minAvailableReplicas, enableStrictReplicaGroup,
Review Comment:
done
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##########
@@ -624,6 +624,13 @@ public RebalanceResult rebalance(
+ "more servers.") @DefaultValue("false") @QueryParam("lowDiskMode")
boolean lowDiskMode,
@ApiParam(value = "Whether to use best-efforts to rebalance (not fail
the rebalance when the no-downtime "
+ "contract cannot be achieved)") @DefaultValue("false")
@QueryParam("bestEfforts") boolean bestEfforts,
+ @ApiParam(value = "How many maximum segment adds per server to update in
the IdealState in each step. For "
+ + "non-strict replica group based assignment, this number will be
the closest possible without splitting up "
+ + "a single segment's step's replicas across steps (so some servers
may get fewer segments). For strict "
+ + "replica group based assignment, this is a per-server best effort
value since each partition of a replica "
+ + "group must be moved as a whole and at least one partition in a
replica group should be moved. A value of "
+ + "Integer.MAX_VALUE is used to indicate an unlimited batch size,
which is the non-batching behavior.")
+ @DefaultValue("2147483647") @QueryParam("batchSizePerServer") int
batchSizePerServer,
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
