siddharthteotia commented on code in PR #15585:
URL: https://github.com/apache/pinot/pull/15585#discussion_r2054575185
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerTimer.java:
##########
@@ -43,8 +43,13 @@ public enum ServerTimer implements AbstractMetrics.Timer {
RESPONSE_SER_CPU_TIME_NS("nanoseconds", false, "Query cost (response
serialization cpu time) "
+ "for query processing on server. Computed as the time spent in
serializing query response on servers"),
-
- SEGMENT_UPLOAD_TIME_MS("milliseconds", false),
+ // Measures only the time taken to upload the segment to the deep store,
doesn't include server processing time
+ SEGMENT_UPLOAD_TIME_MS("milliseconds", true),
+ // Measures the total time taken to upload the segment to the deep store,
including server processing time
+ SEGMENT_TOTAL_DOWNLOAD_TIME_MS("milliseconds", true),
+ SEGMENT_DEEP_STORE_DOWNLOAD_TIME_MS("milliseconds", true),
Review Comment:
OR if you are trying to distinguish between deep-store download vs peer
download, then may be just have the following 2 ?
SEGMENT_DEEP_STORE_DOWNLOAD_TIME_MS
SEGMENT_PEER_DOWNLOAD_TIME_MS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
