mcvsubbu commented on PR #15585: URL: https://github.com/apache/pinot/pull/15585#issuecomment-2822356613
We chatted briefly, and decided the following metrics should be good for now, all at controller level: - A gauge that is bumped up before we start copying from PinotFS to localFS, and bumped back down after the copy. This gives us the bytes requested from deep store. A suggested metric name is DeepStoreBytesRequested or some such - A gauge on the time taken to download from deep store. It is SET (not added) when the copy above completes. We can possibly set alerts on p95 or p99 value of this metric. - A meter of the number of the total number of bytes we request from deep store. this can be additive meter before we issue the copy operation above. A similar set of metrics can be there for download as well. In addition, it may be useful to add the number of parallel reads or writes from deep store that are ongoing (again, a gauge). We do have a metric today on this but that covers the other operations (e.g. zk) that a controller may be waiting on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
