J-HowHuang commented on code in PR #15110:
URL: https://github.com/apache/pinot/pull/15110#discussion_r1985895623
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##
@@ -612,9 +612,9 @@ public RebalanceResult rebalance(
codecov-commenter commented on PR #15225:
URL: https://github.com/apache/pinot/pull/15225#issuecomment-2707863459
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15225?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
xiangfu0 commented on PR #15192:
URL: https://github.com/apache/pinot/pull/15192#issuecomment-2702867770
Removed the query option and make it happen to all the explain query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
codecov-commenter commented on PR #15211:
URL: https://github.com/apache/pinot/pull/15211#issuecomment-2703726403
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15211?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
mayankshriv commented on code in PR #15206:
URL: https://github.com/apache/pinot/pull/15206#discussion_r1982754431
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java:
##
@@ -204,7 +205,11 @@ Map>
computeOperations(S
J-HowHuang commented on code in PR #15110:
URL: https://github.com/apache/pinot/pull/15110#discussion_r1985901053
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceConfig.java:
##
@@ -83,6 +83,13 @@ public class RebalanceConfig {
@Api
somandal commented on code in PR #15110:
URL: https://github.com/apache/pinot/pull/15110#discussion_r1985893639
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##
@@ -612,9 +612,9 @@ public RebalanceResult rebalance(
ankitsultana commented on code in PR #15225:
URL: https://github.com/apache/pinot/pull/15225#discussion_r1985891334
##
pinot-query-planner/src/test/java/org/apache/pinot/query/QueryCompilationTest.java:
##
@@ -529,13 +529,13 @@ private Object[][]
provideQueriesWithExplainedLogi
ankitsultana opened a new pull request, #15225:
URL: https://github.com/apache/pinot/pull/15225
`LogicalTableScan` drops traits in the `copy` method, and the copy method is
used often during calcite planning to copy the `RelNode` in a type agnostic
manner.
Hence introducing a new nod
somandal commented on code in PR #15110:
URL: https://github.com/apache/pinot/pull/15110#discussion_r1985859192
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##
@@ -615,6 +615,9 @@ public RebalanceResult rebalance(
codecov-commenter commented on PR #15223:
URL: https://github.com/apache/pinot/pull/15223#issuecomment-2707678827
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15223?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
somandal commented on code in PR #15110:
URL: https://github.com/apache/pinot/pull/15110#discussion_r1985799022
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java:
##
@@ -55,40 +55,65 @@ public InstanceAssig
J-HowHuang commented on code in PR #15110:
URL: https://github.com/apache/pinot/pull/15110#discussion_r1985774736
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java:
##
@@ -55,40 +55,65 @@ public InstanceAss
Jackie-Jiang opened a new issue, #15224:
URL: https://github.com/apache/pinot/issues/15224
Follow up from #15223
Currently there is only query plan test but no query test for LOOKUP join.
In order to test LOOKUP join, we can consider adding a dimension table into
`MultiStageEngineInt
somandal commented on code in PR #15110:
URL: https://github.com/apache/pinot/pull/15110#discussion_r1985795069
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceConfig.java:
##
@@ -83,6 +83,13 @@ public class RebalanceConfig {
@ApiMo
J-HowHuang commented on code in PR #15110:
URL: https://github.com/apache/pinot/pull/15110#discussion_r1985796437
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java:
##
@@ -55,40 +55,65 @@ public InstanceAss
Jackie-Jiang opened a new pull request, #15223:
URL: https://github.com/apache/pinot/pull/15223
#14893 accidentally removed the `workerIdToSegmentsMap` and broke LOOKUP
join. This PR adds that back.
TODO: Add a query test for LOOKUP join
--
This is an automated message from the Apa
somandal commented on code in PR #15110:
URL: https://github.com/apache/pinot/pull/15110#discussion_r1985795968
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -191,17 +191,21 @@ private RebalanceResult doRebalance(T
somandal commented on code in PR #15110:
URL: https://github.com/apache/pinot/pull/15110#discussion_r1985790604
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java:
##
@@ -55,40 +55,65 @@ public InstanceAssig
J-HowHuang commented on code in PR #15110:
URL: https://github.com/apache/pinot/pull/15110#discussion_r1985758187
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java:
##
@@ -55,40 +55,65 @@ public InstanceAss
J-HowHuang commented on code in PR #15110:
URL: https://github.com/apache/pinot/pull/15110#discussion_r1985772549
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -191,17 +191,21 @@ private RebalanceResult doRebalance
J-HowHuang commented on code in PR #15110:
URL: https://github.com/apache/pinot/pull/15110#discussion_r1985770339
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceConfig.java:
##
@@ -83,6 +83,13 @@ public class RebalanceConfig {
@Api
somandal commented on code in PR #15110:
URL: https://github.com/apache/pinot/pull/15110#discussion_r1985741776
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceConfig.java:
##
@@ -83,6 +83,13 @@ public class RebalanceConfig {
@ApiMo
J-HowHuang commented on code in PR #15110:
URL: https://github.com/apache/pinot/pull/15110#discussion_r1985760510
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java:
##
@@ -55,40 +55,65 @@ public InstanceAss
J-HowHuang commented on code in PR #15110:
URL: https://github.com/apache/pinot/pull/15110#discussion_r1985759022
##
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentTest.java:
##
@@ -51,9 +51,7 @@
import org.apache.pin
Jackie-Jiang commented on issue #15215:
URL: https://github.com/apache/pinot/issues/15215#issuecomment-2707481502
Since `1.3.0` is already released, you'll probably need to wait for `1.4.0`
to include this change. Are you able to cherry-pick and custom build an image?
--
This is an automa
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from a39ad22d7a Change Pre-filter logic in MergeRollup task (#15177)
add 631833a996 [HELM]: Fix file compression (#1521
Jackie-Jiang merged PR #15217:
URL: https://github.com/apache/pinot/pull/15217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
sajjad-moradi merged PR #15177:
URL: https://github.com/apache/pinot/pull/15177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pino
Jackie-Jiang commented on code in PR #15221:
URL: https://github.com/apache/pinot/pull/15221#discussion_r1985720997
##
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##
@@ -378,6 +378,14 @@ protected BrokerResponse handleRe
This is an automated email from the ASF dual-hosted git repository.
sajjad pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new a39ad22d7a Change Pre-filter logic in MergeRollup
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch dependabot/maven/com.azure-azure-sdk-bom-1.2.32
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 4da37d7e05 Bump com.azure:azure-sdk-bom from 1.2.31 to 1.2.32
The revisions t
Jackie-Jiang merged PR #15218:
URL: https://github.com/apache/pinot/pull/15218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 4678b0b2a1 Bump software.amazon.awssdk:bom from 2.30.33 to 2.30.35
(#15220)
add 5311289238 Bump curator.version f
codecov-commenter commented on PR #15221:
URL: https://github.com/apache/pinot/pull/15221#issuecomment-2706958850
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15221?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/npm_and_yarn/pinot-controller/src/main/resources/axios-1.8.2
in repository https://gitbox.apache.org/repos/asf/pinot.git
at e522a3b28b Bump axios from 0.27.2 to 1.8.2 in
/p
Jackie-Jiang merged PR #15219:
URL: https://github.com/apache/pinot/pull/15219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.30.35
in repository https://gitbox.apache.org/repos/asf/pinot.git
was b5c596d878 Merge branch 'master' into
dependabot/maven/software.amazon.a
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 5ad0ed2402 Fix HDFS as Deep Storage issue by adjusting dependencies in
pom.xml (#15215) (#15216)
add 1bd3dc8548 B
dependabot[bot] opened a new pull request, #15222:
URL: https://github.com/apache/pinot/pull/15222
Bumps [axios](https://github.com/axios/axios) from 0.27.2 to 1.8.2.
Release notes
Sourced from https://github.com/axios/axios/releases";>axios's releases.
Release v1.8.2
Rele
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 1bd3dc8548 Bump com.azure:azure-sdk-bom from 1.2.31 to 1.2.32 (#15218)
add 4678b0b2a1 Bump software.amazon.awssdk:
Jackie-Jiang merged PR #15220:
URL: https://github.com/apache/pinot/pull/15220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
klsince commented on code in PR #15142:
URL: https://github.com/apache/pinot/pull/15142#discussion_r1985496441
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java:
##
@@ -136,11 +166,101 @@ private void manageRetentionForOffli
somandal commented on code in PR #15175:
URL: https://github.com/apache/pinot/pull/15175#discussion_r1985468516
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##
@@ -271,23 +271,25 @@ public String load(String instanceId)
Jackie-Jiang commented on code in PR #14385:
URL: https://github.com/apache/pinot/pull/14385#discussion_r1984393385
##
pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/filter/TimePredicateFilterOptimizer.java:
##
@@ -411,6 +427,108 @@ && isStringLiteral(dateTimeCon
jadami10 opened a new pull request, #15221:
URL: https://github.com/apache/pinot/pull/15221
We're realizing a lot of the existing metric in single stage
1. are missing multistage
2. don't quite make sense with multiple tables
This increments the `BROKER_RESPONSES_WITH_NUM_GROUPS_
Jackie-Jiang merged PR #15214:
URL: https://github.com/apache/pinot/pull/15214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
davecromberge commented on PR #12685:
URL: https://github.com/apache/pinot/pull/12685#issuecomment-2703505620
@itschrispeck you are correct - the runtime type check at query time has
already been introduced. I'm not quite sure how the index table works - I
misunderstood your use case and I
NihalJain commented on code in PR #15216:
URL: https://github.com/apache/pinot/pull/15216#discussion_r1984513783
##
pom.xml:
##
@@ -1375,8 +1375,8 @@
org.apache.hadoop.thirdparty
Review Comment:
Not related to change but should not we let this come t
xiangfu0 commented on code in PR #15192:
URL: https://github.com/apache/pinot/pull/15192#discussion_r1983127288
##
pinot-query-planner/src/main/java/org/apache/pinot/query/context/RuleTimingPlannerListener.java:
##
@@ -0,0 +1,89 @@
+package org.apache.pinot.query.context;
+
+/**
9aman commented on code in PR #15142:
URL: https://github.com/apache/pinot/pull/15142#discussion_r1984976288
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/strategy/RetentionStrategy.java:
##
@@ -34,4 +34,14 @@ public interface RetentionStrate
9aman commented on code in PR #15142:
URL: https://github.com/apache/pinot/pull/15142#discussion_r1984975628
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java:
##
@@ -136,11 +164,86 @@ private void manageRetentionForOfflineT
PovilasV1 opened a new pull request, #15217:
URL: https://github.com/apache/pinot/pull/15217
Issue - https://github.com/apache/pinot/issues/15194
File was compressed in the wrong format.
cc @Jackie-Jiang
--
This is an automated message from the Apache Git Service.
To respond
codecov-commenter commented on PR #15217:
URL: https://github.com/apache/pinot/pull/15217#issuecomment-2706280622
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15217?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
9aman commented on code in PR #15142:
URL: https://github.com/apache/pinot/pull/15142#discussion_r1984935551
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java:
##
@@ -136,11 +164,86 @@ private void manageRetentionForOfflineT
dependabot[bot] closed pull request #15209: Bump software.amazon.awssdk:bom
from 2.30.33 to 2.30.34
URL: https://github.com/apache/pinot/pull/15209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
dependabot[bot] opened a new pull request, #15220:
URL: https://github.com/apache/pinot/pull/15220
Bumps software.amazon.awssdk:bom from 2.30.33 to 2.30.35.
Most Recent Ignore Conditions Applied to This Pull Request
| Dependency Name | Ignore Conditions |
| --- | --- |
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.30.34
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 339e5b3654 Bump software.amazon.awssdk:bom from 2.30.33 to 2.30.34
T
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.30.35
in repository https://gitbox.apache.org/repos/asf/pinot.git
at ef0c25aa63 Bump software.amazon.awssdk:bom from 2.30.33 to 2.30.35
N
dependabot[bot] commented on PR #15209:
URL: https://github.com/apache/pinot/pull/15209#issuecomment-2706204698
Superseded by #15220.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch dependabot/maven/curator.version-5.8.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 9166245171 Bump curator.version from 5.7.1 to 5.8.0
No new revisions were added by
dependabot[bot] opened a new pull request, #15219:
URL: https://github.com/apache/pinot/pull/15219
Bumps `curator.version` from 5.7.1 to 5.8.0.
Updates `org.apache.curator:curator-client` from 5.7.1 to 5.8.0
Release notes
Sourced from https://github.com/apache/curator/releases";>
dependabot[bot] opened a new pull request, #15218:
URL: https://github.com/apache/pinot/pull/15218
Bumps [com.azure:azure-sdk-bom](https://github.com/azure/azure-sdk-for-java)
from 1.2.31 to 1.2.32.
Commits
https://github.com/Azure/azure-sdk-for-java/commit/63382225ace94d902bcd
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/com.azure-azure-sdk-bom-1.2.32
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 4da37d7e05 Bump com.azure:azure-sdk-bom from 1.2.31 to 1.2.32
No new rev
Jackie-Jiang closed issue #15162: Consuming Segments going into BAD State after
forceCommit when dedup is enabled since version 1.3.0
URL: https://github.com/apache/pinot/issues/15162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
9aman commented on code in PR #15142:
URL: https://github.com/apache/pinot/pull/15142#discussion_r1984793317
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java:
##
@@ -136,11 +164,86 @@ private void manageRetentionForOfflineT
NihalJain commented on code in PR #15216:
URL: https://github.com/apache/pinot/pull/15216#discussion_r1984513783
##
pom.xml:
##
@@ -1375,8 +1375,8 @@
org.apache.hadoop.thirdparty
Review Comment:
Not related to change but should not we let this come t
9aman commented on code in PR #15142:
URL: https://github.com/apache/pinot/pull/15142#discussion_r1984788298
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java:
##
@@ -77,6 +88,7 @@ protected void processTable(String tableNam
9aman commented on code in PR #15142:
URL: https://github.com/apache/pinot/pull/15142#discussion_r1984787547
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/SegmentDeletionManager.java:
##
@@ -221,6 +221,7 @@ private void deleteSegmentMetadataFromStore(P
9aman commented on code in PR #15142:
URL: https://github.com/apache/pinot/pull/15142#discussion_r1984783168
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/strategy/RetentionStrategy.java:
##
@@ -34,4 +34,14 @@ public interface RetentionStrate
klsince commented on code in PR #15206:
URL: https://github.com/apache/pinot/pull/15206#discussion_r1983828064
##
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##
@@ -1340,6 +1341,7 @@ public static class BuiltInVirtualColumn {
public static fin
9aman commented on code in PR #15142:
URL: https://github.com/apache/pinot/pull/15142#discussion_r1984776827
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java:
##
@@ -124,8 +138,19 @@ private void manageRetentionForTable(Tab
vrajat commented on code in PR #15037:
URL: https://github.com/apache/pinot/pull/15037#discussion_r1984731573
##
pinot-common/src/main/java/org/apache/pinot/common/response/BrokerResponse.java:
##
@@ -76,6 +76,7 @@ default void toOutputStream(OutputStream outputStream)
/**
Jackie-Jiang commented on code in PR #15130:
URL: https://github.com/apache/pinot/pull/15130#discussion_r1984387023
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java:
##
@@ -110,11 +127,19 @@ protected void doInit() {
}
albertobastos commented on code in PR #15208:
URL: https://github.com/apache/pinot/pull/15208#discussion_r1984646907
##
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##
@@ -309,18 +309,19 @@ protected BrokerResponse handle
somandal commented on code in PR #15110:
URL: https://github.com/apache/pinot/pull/15110#discussion_r1984400252
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##
@@ -615,6 +615,9 @@ public RebalanceResult rebalance(
bziobrowski commented on code in PR #15130:
URL: https://github.com/apache/pinot/pull/15130#discussion_r1984651226
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java:
##
@@ -110,11 +127,19 @@ protected void doInit() {
}
codecov-commenter commented on PR #15216:
URL: https://github.com/apache/pinot/pull/15216#issuecomment-2705827530
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15216?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
gortiz commented on code in PR #15180:
URL: https://github.com/apache/pinot/pull/15180#discussion_r1984644395
##
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##
@@ -947,6 +950,7 @@ static String addRoutingPolicyInErr
gortiz commented on code in PR #15180:
URL: https://github.com/apache/pinot/pull/15180#discussion_r1984641541
##
pinot-spi/src/main/java/org/apache/pinot/spi/query/QueryThreadContext.java:
##
@@ -0,0 +1,614 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+
80 matches
Mail list logo
