vrajat commented on code in PR #15037:
URL: https://github.com/apache/pinot/pull/15037#discussion_r1984731573
##########
pinot-common/src/main/java/org/apache/pinot/common/response/BrokerResponse.java:
##########
@@ -76,6 +76,7 @@ default void toOutputStream(OutputStream outputStream)
/**
* Returns the processing exceptions encountered during the query execution.
*/
+ // TODO: Rename this method
Review Comment:
Left by mistake or did you mean to add this comment ?
##########
pinot-spi/src/main/java/org/apache/pinot/spi/exception/EarlyTerminationException.java:
##########
@@ -22,17 +22,17 @@
* The {@code EarlyTerminationException} can be thrown from
{Operator#nextBlock()} when the operator is early
* terminated (interrupted).
*/
-public class EarlyTerminationException extends RuntimeException {
+public class EarlyTerminationException extends QueryException {
public EarlyTerminationException() {
- super();
+ super(QueryErrorCode.INTERNAL);
Review Comment:
I do see the exception leaking in error messages. Example:
https://github.com/apache/pinot/issues/14999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
