NihalJain commented on code in PR #15216:
URL: https://github.com/apache/pinot/pull/15216#discussion_r1984513783


##########
pom.xml:
##########
@@ -1375,8 +1375,8 @@
       </dependency>
       <dependency>
         <groupId>org.apache.hadoop.thirdparty</groupId>

Review Comment:
   Not related to change but should not we let this come transitively from 
hadoop? I am not sure why we are version managing this. Is there a specific 
reason for doing so?
   
   With current code, pinot cannot build (and then work smoothly) with multiple 
versions of hadoop. We will hit the same issue which @minwoo-jung is facing 
today. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to