Jackie-Jiang commented on code in PR #15221:
URL: https://github.com/apache/pinot/pull/15221#discussion_r1985720997
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -378,6 +378,14 @@ protected BrokerResponse handleRequest(long requestId,
String query, SqlNodeAndO
fillOldBrokerResponseStats(brokerResponse, queryResults.getQueryStats(),
dispatchableSubPlan);
+ // Track number of queries with number of groups limit reached
+ for (String table : tableNames) {
+ if (brokerResponse.isNumGroupsLimitReached()) {
Review Comment:
Can we reverse the if and for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
