gortiz commented on code in PR #15180:
URL: https://github.com/apache/pinot/pull/15180#discussion_r1984644395
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -947,6 +950,7 @@ static String addRoutingPolicyInErrMsg(String errorMessage,
String realtimeRouti
@Override
protected void onQueryStart(long requestId, String clientRequestId, String
query, Object... extras) {
super.onQueryStart(requestId, clientRequestId, query, extras);
+ QueryThreadContext.setQueryEngine("sse");
Review Comment:
I think I added a GH discussion explaining why I didn't do that, but it
could be hidden after my latest changes in the code.
I though about using the enum, but decided against just because enums are
not extensible and we may be adding more engines (maybe as SPI) in the future.
This is especially true for TSE, which seems to be following that path. Anyway,
I'm open to use an enum right now and change it back to a String or another
class in future if we find it problematic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
