somandal commented on code in PR #15110:
URL: https://github.com/apache/pinot/pull/15110#discussion_r1985859192
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##########
@@ -615,6 +615,9 @@ public RebalanceResult rebalance(
@QueryParam("reassignInstances") boolean reassignInstances,
@ApiParam(value = "Whether to reassign CONSUMING segments for real-time
table") @DefaultValue("false")
@QueryParam("includeConsuming") boolean includeConsuming,
+ @ApiParam(value = "If `minimizeDataMovement` is set to false in the
table config, set this to true to enforce"
+ + " minimizeDataMovement during the rebalance.")
@DefaultValue("true")
+ @QueryParam("forceMinimizeDataMovement") boolean
forceMinimizeDataMovement,
Review Comment:
Discussed with @J-HowHuang and recommended exploring enum (ENABLE, DISABLE,
DEFAULT) instead of this string boolean thing.
cc @Jackie-Jiang any thoughts on modeling the API to take 3 values? I kind
of think string is clunky here, but I'm okay with keeping this as string if
there isn't a better way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
