somandal commented on code in PR #15110:
URL: https://github.com/apache/pinot/pull/15110#discussion_r1985795069
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceConfig.java:
##########
@@ -83,6 +83,13 @@ public class RebalanceConfig {
@ApiModelProperty(example = "false")
private boolean _bestEfforts = false;
+ // Whether to enforce Minimal Data Movement Algorithm (only effective if
instance assignment config is set, and if
+ // bootstrap is false). If set to false, the minimizeDataMovement flag in
the table config will be used to determine
+ // whether to run the Minimal Data Movement Algorithm.
+ @JsonProperty("minimizeDataMovement")
+ @ApiModelProperty(example = "TRUE")
+ private String _minimizeDataMovement = "TRUE";
Review Comment:
I just tried this locally and it works fine (and correctly converts the
string and sets it as a Boolean in the RebalanceConfig). `ApiModel` is for
annotating the parameters to be passed in. `ApiModelProperty` is for the model
used to hold the properties. I don't believe there has to be a 1-1 mapping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
