Re: [PR] [timeseries] Add Support for limit and numGroupsLimit [pinot]

2025-01-29 Thread via GitHub
codecov-commenter commented on PR #14945: URL: https://github.com/apache/pinot/pull/14945#issuecomment-2623678152 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14945?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] [timeseries] Add Support for limit and numGroupsLimit [pinot]

2025-01-29 Thread via GitHub
ankitsultana opened a new pull request, #14945: URL: https://github.com/apache/pinot/pull/14945 TODO: Integrates with V1 Engine's limit and numGroupsLimit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[I] Facing issue while removing pinot server [pinot]

2025-01-29 Thread via GitHub
rohitraj-carousellgroup opened a new issue, #14944: URL: https://github.com/apache/pinot/issues/14944 We want to remove one pinot server from our pinot cluster. We have removed the tags and when we are trying to rebalance segments, the segments were not moving to other pinot server. Ki

Re: [PR] Add segment StarTree index rebuild throttler configurable via ZK cluster configs [pinot]

2025-01-29 Thread via GitHub
codecov-commenter commented on PR #14943: URL: https://github.com/apache/pinot/pull/14943#issuecomment-2623467208 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14943?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Add ZK cluster configurable segment StarTree index rebuild throttler [pinot]

2025-01-29 Thread via GitHub
somandal opened a new pull request, #14943: URL: https://github.com/apache/pinot/pull/14943 Rebuilding the StarTree indexes can be more resource intensive than rebuilding other indexes. This PR adds a specific StarTree index rebuild throttler as a safety net to limit the parallel StarTree i

Re: [PR] Fixes Helix threads getting blocked for Realtime Tables [pinot]

2025-01-29 Thread via GitHub
mcvsubbu commented on PR #14771: URL: https://github.com/apache/pinot/pull/14771#issuecomment-2623404879 > > The cathcup is allowed only for 30 seconds post which the segment is downloaded. Correct me if I am wrong. How is that blocking everything ? > > Yes, correct but these threads

Re: [I] Improve GroupIdGenerators performance for high cardinality group by keys [pinot]

2025-01-29 Thread via GitHub
shauryachats commented on issue #14685: URL: https://github.com/apache/pinot/issues/14685#issuecomment-2623339115 Alternatively instead of introducing `pinot.server.query.executor.group.generator.reserveMap` to set the `GroupIdGenerator` initial size to `numGroupsLimit`, we can have a separ

Re: [PR] Separate NonEquiJoinOperator from HashJoinOperator [pinot]

2025-01-29 Thread via GitHub
codecov-commenter commented on PR #14942: URL: https://github.com/apache/pinot/pull/14942#issuecomment-2623311817 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14942?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Support FunnelEventsFunctionEvalAggregationFunction and FunnelStepDurationStatsAggregationFunction functions [pinot]

2025-01-29 Thread via GitHub
codecov-commenter commented on PR #14941: URL: https://github.com/apache/pinot/pull/14941#issuecomment-2623311279 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14941?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) branch master updated (156be808f5 -> 7293122c4f)

2025-01-29 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 156be808f5 Fix condition check while fetching instance partitions (#14910) add 7293122c4f Skip block split for lo

Re: [PR] Skip block split for local exchange [pinot]

2025-01-29 Thread via GitHub
Jackie-Jiang merged PR #14940: URL: https://github.com/apache/pinot/pull/14940 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[PR] Separate NonEquiJoinOperator from HashJoinOperator [pinot]

2025-01-29 Thread via GitHub
Jackie-Jiang opened a new pull request, #14942: URL: https://github.com/apache/pinot/pull/14942 Close #9728 Currently non-equi join is also executed with `HashJoinOperator` which is very inefficient because we can short-circuit a lot of places as there is no join key. This PR ext

Re: [I] Improve GroupIdGenerators performance for high cardinality group by keys [pinot]

2025-01-29 Thread via GitHub
shauryachats commented on issue #14685: URL: https://github.com/apache/pinot/issues/14685#issuecomment-2623264110 `numGroupsLimit` defines the maximum number of distinct groups that can be present in the GroupBy at a server level, whereas `maxInitialResultHolderCapacity` sets the initial ca

[PR] Support FunnelEventsFunctionEvalAggregationFunction and FunnelStepDurationStatsAggregationFunction functions [pinot]

2025-01-29 Thread via GitHub
xiangfu0 opened a new pull request, #14941: URL: https://github.com/apache/pinot/pull/14941 Support two more funnel functions: - FunnelEventsFunctionEvalAggregationFunction - FunnelStepDurationStatsAggregationFunction -- This is an automated message from the Apache Git Service. To re

Re: [PR] Fix condition check while fetching instance partitions [pinot]

2025-01-29 Thread via GitHub
EndZhu commented on code in PR #14910: URL: https://github.com/apache/pinot/pull/14910#discussion_r1934752771 ## pinot-common/src/main/java/org/apache/pinot/common/assignment/InstancePartitionsUtils.java: ## @@ -59,13 +59,13 @@ public static String getInstancePartitionsName(Stri

Re: [PR] Fix condition check while fetching instance partitions [pinot]

2025-01-29 Thread via GitHub
EndZhu commented on code in PR #14910: URL: https://github.com/apache/pinot/pull/14910#discussion_r1934749410 ## pinot-common/src/main/java/org/apache/pinot/common/assignment/InstancePartitionsUtils.java: ## @@ -59,13 +59,13 @@ public static String getInstancePartitionsName(Stri

(pinot) branch master updated (bfe572840d -> 156be808f5)

2025-01-29 Thread jiaguo
This is an automated email from the ASF dual-hosted git repository. jiaguo pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from bfe572840d Map BadQueryRequestException to QueryException.QUERY_VALIDATION_ERROR (#14917) add 156be808f5 Fix cond

Re: [PR] Fix condition check while fetching instance partitions [pinot]

2025-01-29 Thread via GitHub
jasperjiaguo merged PR #14910: URL: https://github.com/apache/pinot/pull/14910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (2f4a2d5be5 -> bfe572840d)

2025-01-29 Thread vvivekiyer
This is an automated email from the ASF dual-hosted git repository. vvivekiyer pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 2f4a2d5be5 Allow optional second argument (max map size) for FREQUENTSTRINGSSKETCH / FREQUENTLONGSSKETCH in the mu

Re: [PR] Map BadQueryRequestException to QueryException.QUERY_VALIDATION_ERROR [pinot]

2025-01-29 Thread via GitHub
vvivekiyer merged PR #14917: URL: https://github.com/apache/pinot/pull/14917 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

Re: [PR] Skip block split for local exchange [pinot]

2025-01-29 Thread via GitHub
codecov-commenter commented on PR #14940: URL: https://github.com/apache/pinot/pull/14940#issuecomment-2622803169 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14940?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add predownload functionality to Pinot [pinot]

2025-01-29 Thread via GitHub
lnbest0707-uber commented on code in PR #14686: URL: https://github.com/apache/pinot/pull/14686#discussion_r1934500253 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java: ## @@ -79,7 +79,9 @@ public enum ServerGauge implements AbstractMetrics.Gauge {

Re: [PR] Add predownload functionality to Pinot [pinot]

2025-01-29 Thread via GitHub
lnbest0707-uber commented on code in PR #14686: URL: https://github.com/apache/pinot/pull/14686#discussion_r1934497416 ## pinot-server/src/main/java/org/apache/pinot/server/predownload/PredownloadScheduler.java: ## @@ -0,0 +1,423 @@ +/** + * Licensed to the Apache Software Found

Re: [PR] Add predownload functionality to Pinot [pinot]

2025-01-29 Thread via GitHub
lnbest0707-uber commented on code in PR #14686: URL: https://github.com/apache/pinot/pull/14686#discussion_r1934495974 ## pinot-server/src/main/java/org/apache/pinot/server/predownload/TableInfo.java: ## @@ -0,0 +1,105 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[PR] Skip block split for local exchange [pinot]

2025-01-29 Thread via GitHub
Jackie-Jiang opened a new pull request, #14940: URL: https://github.com/apache/pinot/pull/14940 - Skip splitting block for local exchange where block can be directly passed as in-memory object - Enhance split when block is small -- This is an automated message from the Apache Git Servi

Re: [PR] Add predownload functionality to Pinot [pinot]

2025-01-29 Thread via GitHub
lnbest0707-uber commented on code in PR #14686: URL: https://github.com/apache/pinot/pull/14686#discussion_r1934488467 ## pinot-server/src/main/java/org/apache/pinot/server/predownload/ZKClient.java: ## @@ -0,0 +1,185 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add predownload functionality to Pinot [pinot]

2025-01-29 Thread via GitHub
lnbest0707-uber commented on code in PR #14686: URL: https://github.com/apache/pinot/pull/14686#discussion_r1934448578 ## pinot-server/src/main/java/org/apache/pinot/server/predownload/StatusRecorder.java: ## @@ -0,0 +1,226 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] Add predownload functionality to Pinot [pinot]

2025-01-29 Thread via GitHub
lnbest0707-uber commented on code in PR #14686: URL: https://github.com/apache/pinot/pull/14686#discussion_r1934479163 ## pinot-server/src/main/java/org/apache/pinot/server/predownload/PredownloadScheduler.java: ## @@ -0,0 +1,423 @@ +/** + * Licensed to the Apache Software Found

Re: [PR] Add predownload functionality to Pinot [pinot]

2025-01-29 Thread via GitHub
lnbest0707-uber commented on code in PR #14686: URL: https://github.com/apache/pinot/pull/14686#discussion_r1934470142 ## pinot-server/src/main/java/org/apache/pinot/server/predownload/ZKClient.java: ## @@ -0,0 +1,185 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add predownload functionality to Pinot [pinot]

2025-01-29 Thread via GitHub
lnbest0707-uber commented on code in PR #14686: URL: https://github.com/apache/pinot/pull/14686#discussion_r1934453166 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerMeter.java: ## @@ -169,7 +169,13 @@ public enum ServerMeter implements AbstractMetrics.Meter

Re: [PR] Add predownload functionality to Pinot [pinot]

2025-01-29 Thread via GitHub
lnbest0707-uber commented on code in PR #14686: URL: https://github.com/apache/pinot/pull/14686#discussion_r1934451713 ## pinot-server/src/main/java/org/apache/pinot/server/predownload/ZKClient.java: ## @@ -0,0 +1,185 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add predownload functionality to Pinot [pinot]

2025-01-29 Thread via GitHub
lnbest0707-uber commented on code in PR #14686: URL: https://github.com/apache/pinot/pull/14686#discussion_r193701 ## pinot-server/src/main/java/org/apache/pinot/server/predownload/PredownloadScheduler.java: ## @@ -0,0 +1,423 @@ +/** + * Licensed to the Apache Software Found

Re: [PR] Add predownload functionality to Pinot [pinot]

2025-01-29 Thread via GitHub
lnbest0707-uber commented on code in PR #14686: URL: https://github.com/apache/pinot/pull/14686#discussion_r1934441447 ## pinot-server/src/main/java/org/apache/pinot/server/predownload/PredownloadScheduler.java: ## @@ -0,0 +1,423 @@ +/** + * Licensed to the Apache Software Found

Re: [PR] Add predownload functionality to Pinot [pinot]

2025-01-29 Thread via GitHub
lnbest0707-uber commented on code in PR #14686: URL: https://github.com/apache/pinot/pull/14686#discussion_r1934426279 ## pinot-server/src/main/java/org/apache/pinot/server/predownload/PredownloadScheduler.java: ## @@ -0,0 +1,423 @@ +/** + * Licensed to the Apache Software Found

[I] Remove Google Analytics from the Pinot Website [pinot]

2025-01-29 Thread via GitHub
niallkp opened a new issue, #14840: URL: https://github.com/apache/pinot/issues/14840 Hi Pinot Team The ASF **_Privacy Policy_**[1][2] does not permit the use of **_Google Analytics_** on any ASF websites and the ASF Infra team will soon enforce a **_Content Security Policy_**(CSP) t

Re: [PR] Allow optional second argument (max map size) for FREQUENTSTRINGSSKETCH / FREQUENTLONGSSKETCH in the multi-stage engine [pinot]

2025-01-29 Thread via GitHub
Jackie-Jiang merged PR #14939: URL: https://github.com/apache/pinot/pull/14939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (3525116ac2 -> 2f4a2d5be5)

2025-01-29 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 3525116ac2 Pauseless Ingestion #2: Handle Failure scenarios without DR (#14798) add 2f4a2d5be5 Allow optional sec

Re: [PR] Include information on whether a query is using SSQE or MSQE in QueryLogger [pinot]

2025-01-29 Thread via GitHub
Jackie-Jiang commented on code in PR #14938: URL: https://github.com/apache/pinot/pull/14938#discussion_r1934404441 ## pinot-broker/src/main/java/org/apache/pinot/broker/querylog/QueryLogger.java: ## @@ -120,17 +120,19 @@ public static class QueryLogParams { private final R

Re: [I] Issue with NULL storage in column with 1.4.0 (must be there earlier versions too) [pinot]

2025-01-29 Thread via GitHub
Jackie-Jiang commented on issue #14922: URL: https://github.com/apache/pinot/issues/14922#issuecomment-2622536731 @raghukn When you create the table, do you have `nullHandlingEnabled` set to true in the `TableConfig` under `IndexingConfig`? -- This is an automated message from the Apache

Re: [PR] Allow optional second argument (max map size) for FREQUENTSTRINGSSKETCH / FREQUENTLONGSSKETCH in the multi-stage engine [pinot]

2025-01-29 Thread via GitHub
codecov-commenter commented on PR #14939: URL: https://github.com/apache/pinot/pull/14939#issuecomment-2622516876 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14939?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Allow optional second argument (max map size) for FREQUENTSTRINGSSKETCH / FREQUENTLONGSSKETCH in the multi-stage engine [pinot]

2025-01-29 Thread via GitHub
yashmayya opened a new pull request, #14939: URL: https://github.com/apache/pinot/pull/14939 - Currently, attempting to use `FREQUENTSTRINGSSKETCH` / `FREQUENTLONGSSKETCH` with the optional second argument that determines the max map size causes a query compilation failure in the multi-stag

Re: [PR] Include information on whether a query is using SSQE or MSQE in QueryLogger [pinot]

2025-01-29 Thread via GitHub
codecov-commenter commented on PR #14938: URL: https://github.com/apache/pinot/pull/14938#issuecomment-2622374093 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14938?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add broker setting to override default implicit query response limit [pinot]

2025-01-29 Thread via GitHub
gortiz commented on code in PR #14452: URL: https://github.com/apache/pinot/pull/14452#discussion_r1934290382 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -255,7 +255,14 @@ public static class Broker { public static final String CONFIG

Re: [PR] Add `DATE_TRUNC` Optimizer [pinot]

2025-01-29 Thread via GitHub
jadami10 commented on PR #14385: URL: https://github.com/apache/pinot/pull/14385#issuecomment-262516 Yup we can meet. I have work obligations this week, so likely next week. What timezone are you? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Include information on whether a query is using SSQE or MSQE in QueryLogger [pinot]

2025-01-29 Thread via GitHub
yashmayya commented on code in PR #14938: URL: https://github.com/apache/pinot/pull/14938#discussion_r1934242669 ## pinot-broker/src/main/java/org/apache/pinot/broker/querylog/QueryLogger.java: ## @@ -255,6 +257,12 @@ void doFormat(StringBuilder builder, QueryLogger logger, Que

[PR] Include information on whether a query is using SSQE or MSQE in QueryLogger [pinot]

2025-01-29 Thread via GitHub
yashmayya opened a new pull request, #14938: URL: https://github.com/apache/pinot/pull/14938 - Currently, the only way to distinguish between SSQE and MSQE queries via query logs in Pinot brokers is to check whether `serverStats` is empty (MSQE) or not (SSQE). - This isn't reliable or co

(pinot) branch release-1.3.0-rc1 created (now bae3fcc899)

2025-01-29 Thread abhioncbr
This is an automated email from the ASF dual-hosted git repository. abhioncbr pushed a change to branch release-1.3.0-rc1 in repository https://gitbox.apache.org/repos/asf/pinot.git at bae3fcc899 feat(ui): add option to show visualized query stats (#14848) This branch includes the followi

(pinot) 02/02: feat(ui): add option to show visualized query stats (#14848)

2025-01-29 Thread abhioncbr
This is an automated email from the ASF dual-hosted git repository. abhioncbr pushed a commit to branch release-1.3.0-rc1 in repository https://gitbox.apache.org/repos/asf/pinot.git commit bae3fcc899be84fb965e2774f9134577e20d67e3 Author: Jayesh Choudhary AuthorDate: Wed Jan 22 06:14:00 2025 -080

(pinot) 01/02: remove unsupported compress option from src binary release (#14842)

2025-01-29 Thread abhioncbr
This is an automated email from the ASF dual-hosted git repository. abhioncbr pushed a commit to branch release-1.3.0-rc1 in repository https://gitbox.apache.org/repos/asf/pinot.git commit 8a67e2b7395aecc7d8d93c6c66cfd9cffa113282 Author: Abhishek Sharma AuthorDate: Mon Jan 27 11:09:32 2025 -0500

Re: [I] Remove Google Analytics from the Pinot Website [pinot]

2025-01-29 Thread via GitHub
niallkp commented on issue #14840: URL: https://github.com/apache/pinot/issues/14840#issuecomment-2621469137 Thanks for merging the PR - much appreciated. However, I have just re-scanned the _**new-static-prod**_ branch of the [pinot](https://github.com/apache/pinot-site/tree/new-static-pro

Re: [I] [question] reuse subtree for follow-up query of same user [pinot]

2025-01-29 Thread via GitHub
hpvd commented on issue #14937: URL: https://github.com/apache/pinot/issues/14937#issuecomment-2621466047 Is this maybe some how related to pagination support as described here by @siddharthteotia https://github.com/apache/pinot/issues/5246#issuecomment-1183488539 where the first q

Re: [PR] Pauseless Consumption #3: Disaster Recovery with Reingestion [pinot]

2025-01-29 Thread via GitHub
codecov-commenter commented on PR #14920: URL: https://github.com/apache/pinot/pull/14920#issuecomment-2621270356 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14920?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Fix application qps quota stalls. [pinot]

2025-01-29 Thread via GitHub
bziobrowski commented on PR #14859: URL: https://github.com/apache/pinot/pull/14859#issuecomment-2621075293 > I feel the general logic introduced in #14226 needs to be improved. All the quota updates should be done via the `processApplicationQueryRateLimitingClusterConfigChange()` callback,

Re: [PR] Fix application qps quota stalls. [pinot]

2025-01-29 Thread via GitHub
bziobrowski commented on code in PR #14859: URL: https://github.com/apache/pinot/pull/14859#discussion_r1933517138 ## pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java: ## @@ -348,16 +355,38 @@ private synchronized void c

Re: [PR] Fix application qps quota stalls. [pinot]

2025-01-29 Thread via GitHub
bziobrowski commented on code in PR #14859: URL: https://github.com/apache/pinot/pull/14859#discussion_r1933514934 ## pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java: ## @@ -130,9 +136,10 @@ private void initializeApplic

Re: [PR] Fix application qps quota stalls. [pinot]

2025-01-29 Thread via GitHub
bziobrowski commented on code in PR #14859: URL: https://github.com/apache/pinot/pull/14859#discussion_r1933515235 ## pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java: ## @@ -130,9 +136,10 @@ private void initializeApplic

Re: [PR] Fix application qps quota stalls. [pinot]

2025-01-29 Thread via GitHub
bziobrowski commented on code in PR #14859: URL: https://github.com/apache/pinot/pull/14859#discussion_r1933514126 ## pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java: ## @@ -74,6 +74,12 @@ * - broker added or removed f

Re: [I] [proposal] Reuse common expressions in a query [pinot]

2025-01-29 Thread via GitHub
gortiz closed issue #14196: [proposal] Reuse common expressions in a query URL: https://github.com/apache/pinot/issues/14196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] [proposal] Reuse common expressions in a query [pinot]

2025-01-29 Thread via GitHub
gortiz commented on issue #14196: URL: https://github.com/apache/pinot/issues/14196#issuecomment-2620938530 closing as done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.