lnbest0707-uber commented on code in PR #14686:
URL: https://github.com/apache/pinot/pull/14686#discussion_r1934500253
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java:
##########
@@ -79,7 +79,9 @@ public enum ServerGauge implements AbstractMetrics.Gauge {
REALTIME_INGESTION_OFFSET_LAG("offsetLag", false),
REALTIME_INGESTION_UPSTREAM_OFFSET("upstreamOffset", false),
REALTIME_INGESTION_CONSUMING_OFFSET("consumingOffset", false),
- REALTIME_CONSUMER_DIR_USAGE("bytes", true);
+ REALTIME_CONSUMER_DIR_USAGE("bytes", true),
+ SEGMENT_DOWNLOAD_SPEED("bytes", true),
Review Comment:
It is only called once in preDownloadSucceed. We only report this once per
thread. So this value would not be overriden. Emitting this value here is to
have better aggregation view among 100s servers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
