shauryachats commented on issue #14685: URL: https://github.com/apache/pinot/issues/14685#issuecomment-2623339115
Alternatively instead of introducing `pinot.server.query.executor.group.generator.reserveMap` to set the `GroupIdGenerator` initial size to `numGroupsLimit`, we can have a separate configuration for multi-stage engine solely to reserve the minimum size of the `GroupIdGenerator` namely: `pinot.server.query.executor.multistage.group.id.generator.initial.size` and we can assign a default value of say `1000` so that it does not impact any current multi-stage engine use cases but also can help tune the `GroupIdGenerator` sizes for high cardinality use cases. @Jackie-Jiang do let me know if this approach suits you more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
