bziobrowski commented on PR #14859: URL: https://github.com/apache/pinot/pull/14859#issuecomment-2621075293
> I feel the general logic introduced in #14226 needs to be improved. All the quota updates should be done via the `processApplicationQueryRateLimitingClusterConfigChange()` callback, and from query path it should call a real-only method which doesn't do any update logic. That method is applied only when default value changes. createOrUpdateApplicationRateLimiter() for a specific app name is called when RefreshApplicationQpsQuotaMessageHandler is received. There's one exception to the the 'read-only-nees' and that is when an unknown app name is detected and default app quota is enabled. In such case we've to create rate-limiter on the spot, but without querying ZK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
