bziobrowski commented on code in PR #14859: URL: https://github.com/apache/pinot/pull/14859#discussion_r1933514126
########## pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java: ########## @@ -74,6 +74,12 @@ * - broker added or removed from cluster */ public class HelixExternalViewBasedQueryQuotaManager implements ClusterChangeHandler, QueryQuotaManager { + + // Minimum 'working' value for app quota. If actual value is less than this (e.g. 0.0), it is considered as disabled. + private static final double MIN_APP_QUOTA = Math.nextUp(0.0); Review Comment: I changed the value and hid logic behind isDisabled(), isEnabled() methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org