gortiz commented on code in PR #14452:
URL: https://github.com/apache/pinot/pull/14452#discussion_r1934290382
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -255,7 +255,14 @@ public static class Broker {
public static final String CONFIG_OF_BROKER_QUERY_REWRITER_CLASS_NAMES =
"pinot.broker.query.rewriter.class.names";
public static final String CONFIG_OF_BROKER_QUERY_RESPONSE_LIMIT =
"pinot.broker.query.response.limit";
- public static final int DEFAULT_BROKER_QUERY_RESPONSE_LIMIT =
Integer.MAX_VALUE;
+ public static final String CONFIG_OF_BROKER_DEFAULT_QUERY_LIMIT =
+ "pinot.broker.default.query.limit";
+
+ public static final int DEFAULT_BROKER_QUERY_LIMIT_OVERRIDE =
Integer.MAX_VALUE;
+
+ // -1 means no limit; value of 10 aligns limit with PinotQuery's defaults.
Review Comment:
@bziobrowski can you change this name? I think we can merge this once that
change is done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
