bziobrowski commented on code in PR #14859:
URL: https://github.com/apache/pinot/pull/14859#discussion_r1933517138
##########
pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java:
##########
@@ -348,16 +355,38 @@ private synchronized void
createOrUpdateDatabaseRateLimiter(List<String> databas
}
public synchronized void createOrUpdateApplicationRateLimiter(String
applicationName) {
-
createOrUpdateApplicationRateLimiter(Collections.singletonList(applicationName));
+
createOrUpdateApplicationRateLimiter(Collections.singletonList(applicationName),
DISABLED_APP_QUOTA);
+ }
+
+ public synchronized void createOrUpdateApplicationRateLimiter(String
applicationName, double override) {
+
createOrUpdateApplicationRateLimiter(Collections.singletonList(applicationName),
override);
}
// Caller method need not worry about getting lock on
_applicationRateLimiterMap
// as this method will do idempotent updates to the application rate limiters
- private synchronized void createOrUpdateApplicationRateLimiter(List<String>
applicationNames) {
+ private synchronized void createOrUpdateApplicationRateLimiter(List<String>
applicationNames, double override) {
Review Comment:
I added more method to hide the override when it's not needed but kept it as
primitive because null is not necessarily more readable and would trigger
boxing/unboxing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
