Re: [PR] [spool] Define equivalence between stages [pinot]

2024-10-29 Thread via GitHub
yashmayya commented on code in PR #14296: URL: https://github.com/apache/pinot/pull/14296#discussion_r1821907223 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/readerwriter/ValueReaderComparisonTest.java: ## @@ -52,6 +53,9 @@ public class Value

Re: [PR] Add bucketing time zone paramter to dateTimeConvert() function [pinot]

2024-10-29 Thread via GitHub
bziobrowski commented on code in PR #14298: URL: https://github.com/apache/pinot/pull/14298#discussion_r1820514060 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DateTimeConvert.java: ## @@ -83,4 +99,67 @@ public Object dateTimeConvert(String timeValueStr,

Re: [PR] Add bucketing time zone paramter to dateTimeConvert() function [pinot]

2024-10-29 Thread via GitHub
bziobrowski commented on code in PR #14298: URL: https://github.com/apache/pinot/pull/14298#discussion_r1821926342 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/transformer/datetime/EpochToEpochTransformer.java: ## @@ -29,14 +31,20 @@ public class EpochTo

Re: [PR] Add bucketing time zone paramter to dateTimeConvert() function [pinot]

2024-10-29 Thread via GitHub
bziobrowski commented on code in PR #14298: URL: https://github.com/apache/pinot/pull/14298#discussion_r1821926342 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/transformer/datetime/EpochToEpochTransformer.java: ## @@ -29,14 +31,20 @@ public class EpochTo

Re: [PR] Add bucketing time zone paramter to dateTimeConvert() function [pinot]

2024-10-29 Thread via GitHub
bziobrowski commented on code in PR #14298: URL: https://github.com/apache/pinot/pull/14298#discussion_r1821927612 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DateTimeConvert.java: ## @@ -42,36 +51,43 @@ public Object dateTimeConvert(String timeValueStr

Re: [PR] Add bucketing time zone paramter to dateTimeConvert() function [pinot]

2024-10-29 Thread via GitHub
bziobrowski commented on code in PR #14298: URL: https://github.com/apache/pinot/pull/14298#discussion_r1821927449 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/transformer/datetime/BaseDateTimeTransformer.java: ## @@ -58,41 +74,145 @@ public BaseDateTimeT

Re: [PR] Add bucketing time zone paramter to dateTimeConvert() function [pinot]

2024-10-29 Thread via GitHub
bziobrowski commented on code in PR #14298: URL: https://github.com/apache/pinot/pull/14298#discussion_r1821926342 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/transformer/datetime/EpochToEpochTransformer.java: ## @@ -29,14 +31,20 @@ public class EpochTo

Re: [PR] Set skipUnparseableLines to true by default in CSV reader [pinot]

2024-10-29 Thread via GitHub
KKcorps commented on PR #14311: URL: https://github.com/apache/pinot/pull/14311#issuecomment-2445753611 @Jackie-Jiang the difference is this doesn't throw exception when the line is corrupt there still might be rare case when it fails but its much much safer than existing iterator

Re: [PR] Add Wait Time to Fix Local `SparkSegmentMetadataPushIntegrationTest` [pinot]

2024-10-29 Thread via GitHub
ashishjayamohan closed pull request #14322: Add Wait Time to Fix Local `SparkSegmentMetadataPushIntegrationTest` URL: https://github.com/apache/pinot/pull/14322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Add Wait Time to Fix Local `SparkSegmentMetadataPushIntegrationTest` [pinot]

2024-10-29 Thread via GitHub
ashishjayamohan commented on PR #14322: URL: https://github.com/apache/pinot/pull/14322#issuecomment-2445641840 Yep, that PR fixes the issue. I'm going to go ahead and close this PR then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Enhance table deletion on server to prevent accessing old table data manager [pinot]

2024-10-29 Thread via GitHub
codecov-commenter commented on PR #14334: URL: https://github.com/apache/pinot/pull/14334#issuecomment-2445619071 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14334?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Enhance table deletion on server to prevent accessing old table data manager [pinot]

2024-10-29 Thread via GitHub
Jackie-Jiang opened a new pull request, #14334: URL: https://github.com/apache/pinot/pull/14334 In #11380 we introduced the mechanism to handle the case when a table is deleted then immediately recreated. Even though it can prevent adding segment to the old table data manager, it sti

Re: [PR] Adjust JsonExtractScalarTest to show failure of reading LONGs [pinot]

2024-10-29 Thread via GitHub
codecov-commenter commented on PR #14332: URL: https://github.com/apache/pinot/pull/14332#issuecomment-2445597213 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14332?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add Wait Time to Fix Local `SparkSegmentMetadataPushIntegrationTest` [pinot]

2024-10-29 Thread via GitHub
Jackie-Jiang commented on PR #14322: URL: https://github.com/apache/pinot/pull/14322#issuecomment-2445579218 I'm not able to reproduce this locally. Can you try if #14334 can fix this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Stop table data manager before shutdown [pinot]

2024-10-29 Thread via GitHub
Jackie-Jiang closed pull request #11358: Stop table data manager before shutdown URL: https://github.com/apache/pinot/pull/11358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

(pinot) branch master updated: Add partial unnest array test in ComplexTypeTransformerTest (#14333)

2024-10-29 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new ae9bd336ed Add partial unnest array test in Comp

Re: [PR] Add partial unnest array test in ComplexTypeTransformerTest [pinot]

2024-10-29 Thread via GitHub
xiangfu0 merged PR #14333: URL: https://github.com/apache/pinot/pull/14333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] [timeseries] Use Num Docs from Value Block in Time Series Aggregation Operator [pinot]

2024-10-29 Thread via GitHub
ankitsultana merged PR #14331: URL: https://github.com/apache/pinot/pull/14331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[PR] Add partial unnest array test in ComplexTypeTransformerTest [pinot]

2024-10-29 Thread via GitHub
xiangfu0 opened a new pull request, #14333: URL: https://github.com/apache/pinot/pull/14333 so we can just unnest one level of nest structure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] [timeseries] Use Num Docs from Value Block in Time Series Aggregation Operator [pinot]

2024-10-29 Thread via GitHub
ankitsultana commented on PR #14331: URL: https://github.com/apache/pinot/pull/14331#issuecomment-2445504701 I'll follow-up with a refactor of this operator since the code is not clean at all and the allocations should be optimized. -- This is an automated message from the Apache Git Serv

(pinot) branch master updated: [timeseries] Use Num Docs from Value Block in Time Series Agg (#14331)

2024-10-29 Thread ankitsultana
This is an automated email from the ASF dual-hosted git repository. ankitsultana pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 702dfc3692 [timeseries] Use Num Docs from V

Re: [PR] Add partial unnest array test in ComplexTypeTransformerTest [pinot]

2024-10-29 Thread via GitHub
codecov-commenter commented on PR #14333: URL: https://github.com/apache/pinot/pull/14333#issuecomment-2445500756 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14333?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Bump com.azure:azure-sdk-bom from 1.2.28 to 1.2.29 [pinot]

2024-10-29 Thread via GitHub
Jackie-Jiang merged PR #14330: URL: https://github.com/apache/pinot/pull/14330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [I] Gracefully handle reading size for disabled table [pinot]

2024-10-29 Thread via GitHub
Jackie-Jiang commented on issue #14279: URL: https://github.com/apache/pinot/issues/14279#issuecomment-2445450018 IMO, the root problem is not the log level, but Pinot not able to gracefully handle reading size for disabled tables. I've updated the title to reflect this. -- This is an aut

Re: [PR] Add partial unnest array test in ComplexTypeTransformerTest [pinot]

2024-10-29 Thread via GitHub
Jackie-Jiang commented on code in PR #14333: URL: https://github.com/apache/pinot/pull/14333#discussion_r1821611903 ## pinot-segment-local/src/test/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformerTest.java: ## @@ -244,6 +244,22 @@ public void testUnne

(pinot) branch dependabot/maven/com.azure-azure-sdk-bom-1.2.29 deleted (was 2011771662)

2024-10-29 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/com.azure-azure-sdk-bom-1.2.29 in repository https://gitbox.apache.org/repos/asf/pinot.git was 2011771662 Bump com.azure:azure-sdk-bom from 1.2.28 to 1.2.29 The revisions t

(pinot) branch master updated (4bafac8439 -> 3854807534)

2024-10-29 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 4bafac8439 Add minor optimization for FIRST_VALUE / LAST_VALUE with IGNORE NULLS and unbounded ROWS window frame (#143

Re: [PR] [timeseries] Use Num Docs from Value Block in Time Series Aggregation Operator [pinot]

2024-10-29 Thread via GitHub
codecov-commenter commented on PR #14331: URL: https://github.com/apache/pinot/pull/14331#issuecomment-2445236010 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/14331?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add IGNORE NULLS option to FIRST_VALUE and LAST_VALUE window functions [pinot]

2024-10-29 Thread via GitHub
Jackie-Jiang commented on code in PR #14264: URL: https://github.com/apache/pinot/pull/14264#discussion_r1821370446 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/window/value/FirstValueWindowFunction.java: ## @@ -78,12 +86,73 @@ private List proces

[PR] Adjust JsonExtractScalarTest to show failure of reading LONGs [pinot]

2024-10-29 Thread via GitHub
AlexanderKM opened a new pull request, #14332: URL: https://github.com/apache/pinot/pull/14332 Instructions: 1. The PR has to be tagged with at least one of the following labels (*): 1. `feature` 2. `bugfix` 3. `performance` 4. `ui` 5. `backward-incompat`

[PR] [timeseries] Use Num Docs from Value Block in Time Series Aggregation Operator [pinot]

2024-10-29 Thread via GitHub
ankitsultana opened a new pull request, #14331: URL: https://github.com/apache/pinot/pull/14331 Data is cached in fixed sized arrays, and using array length for inferring the number of documents to process in a query is incorrect. This PR switches to numDocs instead. Detected t

Re: [I] Correct loglevel when a table is disabled [pinot]

2024-10-29 Thread via GitHub
piby180 commented on issue #14279: URL: https://github.com/apache/pinot/issues/14279#issuecomment-2445127054 Hi @Jackie-Jiang Yes, I think it is the controller UI. I have a couple of colleagues, who frequently use controller UI and with every refresh, we see these logs on broker pods. W

Re: [PR] Add minor optimization for FIRST_VALUE / LAST_VALUE with IGNORE NULLS and unbounded ROWS window frame [pinot]

2024-10-29 Thread via GitHub
Jackie-Jiang merged PR #14324: URL: https://github.com/apache/pinot/pull/14324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: Add minor optimization for FIRST_VALUE / LAST_VALUE with IGNORE NULLS and unbounded ROWS window frame (#14324)

2024-10-29 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 4bafac8439 Add minor optimization for FIRST_VALUE

Re: [PR] Add bucketing time zone paramter to dateTimeConvert() function [pinot]

2024-10-29 Thread via GitHub
Jackie-Jiang commented on code in PR #14298: URL: https://github.com/apache/pinot/pull/14298#discussion_r1821361962 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/transformer/datetime/BaseDateTimeTransformer.java: ## @@ -58,41 +74,145 @@ public BaseDateTime

Re: [I] Lucene 9.12.0 upgrade [pinot]

2024-10-29 Thread via GitHub
Jackie-Jiang commented on issue #14232: URL: https://github.com/apache/pinot/issues/14232#issuecomment-2445065306 @hpvd We have changed the topic to upgrade to `9.12.0`. Can you help create an extra issue for `10.0` upgrade and link that to the parent issue? -- This is an automated messag

Re: [PR] Add bucketing time zone paramter to dateTimeConvert() function [pinot]

2024-10-29 Thread via GitHub
Jackie-Jiang commented on code in PR #14298: URL: https://github.com/apache/pinot/pull/14298#discussion_r1821363779 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/transformer/datetime/EpochToEpochTransformer.java: ## @@ -29,14 +31,20 @@ public class EpochT

Re: [PR] Add bucketing time zone paramter to dateTimeConvert() function [pinot]

2024-10-29 Thread via GitHub
Jackie-Jiang commented on code in PR #14298: URL: https://github.com/apache/pinot/pull/14298#discussion_r1821359686 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/transformer/datetime/BaseDateTimeTransformer.java: ## @@ -42,14 +46,26 @@ public abstract clas

Re: [PR] Add bucketing time zone paramter to dateTimeConvert() function [pinot]

2024-10-29 Thread via GitHub
Jackie-Jiang commented on code in PR #14298: URL: https://github.com/apache/pinot/pull/14298#discussion_r1821358252 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DateTimeConvert.java: ## @@ -42,36 +51,43 @@ public Object dateTimeConvert(String timeValueSt

(pinot) branch master updated: Bump com.fasterxml.jackson:jackson-bom from 2.17.2 to 2.18.1 (#14328)

2024-10-29 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 657ae69d59 Bump com.fasterxml.jackson:jackson-bom

(pinot) branch dependabot/maven/com.fasterxml.jackson-jackson-bom-2.18.1 deleted (was d183494f36)

2024-10-29 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/com.fasterxml.jackson-jackson-bom-2.18.1 in repository https://gitbox.apache.org/repos/asf/pinot.git was d183494f36 Bump com.fasterxml.jackson:jackson-bom from 2.17.2 to 2.

Re: [PR] Bump software.amazon.awssdk:bom from 2.29.0 to 2.29.2 [pinot]

2024-10-29 Thread via GitHub
Jackie-Jiang merged PR #14329: URL: https://github.com/apache/pinot/pull/14329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch dependabot/maven/com.azure-azure-sdk-bom-1.2.29 updated (4065f9570b -> 2011771662)

2024-10-29 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.azure-azure-sdk-bom-1.2.29 in repository https://gitbox.apache.org/repos/asf/pinot.git discard 4065f9570b Bump com.azure:azure-sdk-bom from 1.2.28 to 1.2.29 add 83

Re: [PR] Bump com.fasterxml.jackson:jackson-bom from 2.17.2 to 2.18.1 [pinot]

2024-10-29 Thread via GitHub
Jackie-Jiang merged PR #14328: URL: https://github.com/apache/pinot/pull/14328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: Bump software.amazon.awssdk:bom from 2.29.0 to 2.29.2 (#14329)

2024-10-29 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 32ab11aa15 Bump software.amazon.awssdk:bom from 2

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.29.2 deleted (was 54a3f75561)

2024-10-29 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.29.2 in repository https://gitbox.apache.org/repos/asf/pinot.git was 54a3f75561 Bump software.amazon.awssdk:bom from 2.29.0 to 2.29.2 The revi

Re: [I] Support seamless TLS certificate rotation [pinot]

2024-10-29 Thread via GitHub
ilamhs commented on issue #12107: URL: https://github.com/apache/pinot/issues/12107#issuecomment-2444962687 @zhtaoxiang I see that all the listed PRs are merged now, let me know if that is complete or need any help testing this patch out in our cluster. Thanks! -- This is an automated mes

(pinot) branch dependabot/maven/io.grpc-grpc-bom-1.68.1 deleted (was 020cd8d8ad)

2024-10-29 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/io.grpc-grpc-bom-1.68.1 in repository https://gitbox.apache.org/repos/asf/pinot.git was 020cd8d8ad Bump io.grpc:grpc-bom from 1.68.0 to 1.68.1 The revisions that were on th

(pinot) branch master updated: Bump io.grpc:grpc-bom from 1.68.0 to 1.68.1 (#14326)

2024-10-29 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 83c5ef6d1d Bump io.grpc:grpc-bom from 1.68.0 to 1

Re: [PR] Bump io.grpc:grpc-bom from 1.68.0 to 1.68.1 [pinot]

2024-10-29 Thread via GitHub
Jackie-Jiang merged PR #14326: URL: https://github.com/apache/pinot/pull/14326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] [spool] Define equivalence between stages [pinot]

2024-10-29 Thread via GitHub
gortiz commented on code in PR #14296: URL: https://github.com/apache/pinot/pull/14296#discussion_r1820955377 ## pinot-query-planner/src/test/java/org/apache/pinot/query/planner/logical/GroupedStagesTest.java: ## @@ -0,0 +1,73 @@ +/** + * Licensed to the Apache Software Foundati

Re: [PR] [spool] Define equivalence between stages [pinot]

2024-10-29 Thread via GitHub
gortiz commented on code in PR #14296: URL: https://github.com/apache/pinot/pull/14296#discussion_r1820964793 ## pinot-query-planner/src/test/java/org/apache/pinot/query/planner/logical/StagesTestBase.java: ## @@ -0,0 +1,230 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] [spool] Define equivalence between stages [pinot]

2024-10-29 Thread via GitHub
gortiz commented on code in PR #14296: URL: https://github.com/apache/pinot/pull/14296#discussion_r1820999204 ## pinot-query-planner/src/test/java/org/apache/pinot/query/planner/logical/StagesTestBase.java: ## @@ -0,0 +1,230 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] [spool] Define equivalence between stages [pinot]

2024-10-29 Thread via GitHub
gortiz commented on code in PR #14296: URL: https://github.com/apache/pinot/pull/14296#discussion_r1820998104 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/EquivalentStagesFinder.java: ## @@ -0,0 +1,339 @@ +/** + * Licensed to the Apache Software Fo

Re: [PR] [spool] Define equivalence between stages [pinot]

2024-10-29 Thread via GitHub
gortiz commented on code in PR #14296: URL: https://github.com/apache/pinot/pull/14296#discussion_r1820995751 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/GroupedStages.java: ## @@ -0,0 +1,177 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] [spool] Define equivalence between stages [pinot]

2024-10-29 Thread via GitHub
gortiz commented on code in PR #14296: URL: https://github.com/apache/pinot/pull/14296#discussion_r1820992666 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/ParentToChildrenCalculator.java: ## @@ -0,0 +1,56 @@ +/** + * Licensed to the Apache Software

Re: [PR] [spool] Define equivalence between stages [pinot]

2024-10-29 Thread via GitHub
gortiz commented on code in PR #14296: URL: https://github.com/apache/pinot/pull/14296#discussion_r1820990594 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/GroupedStages.java: ## @@ -0,0 +1,177 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] [spool] Define equivalence between stages [pinot]

2024-10-29 Thread via GitHub
gortiz commented on code in PR #14296: URL: https://github.com/apache/pinot/pull/14296#discussion_r1820978884 ## pinot-query-planner/src/test/java/org/apache/pinot/query/planner/logical/StagesTestBase.java: ## @@ -0,0 +1,230 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] [spool] Define equivalence between stages [pinot]

2024-10-29 Thread via GitHub
gortiz commented on code in PR #14296: URL: https://github.com/apache/pinot/pull/14296#discussion_r1820974630 ## pinot-query-planner/src/test/java/org/apache/pinot/query/planner/logical/StagesTestBase.java: ## @@ -0,0 +1,230 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] [spool] Define equivalence between stages [pinot]

2024-10-29 Thread via GitHub
gortiz commented on code in PR #14296: URL: https://github.com/apache/pinot/pull/14296#discussion_r1820949703 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/plannode/PlanNodeVisitor.java: ## @@ -63,4 +63,150 @@ public interface PlanNodeVisitor { T visitEx

Re: [I] [Multi Stage] Add ROWS support for aggregation window functions [pinot]

2024-10-29 Thread via GitHub
yashmayya commented on issue #11406: URL: https://github.com/apache/pinot/issues/11406#issuecomment-2444302969 > We should add support for ROWS type frames for the aggregation window functions as well. For now we will do this for the default frame boundaries since sliding window support has

Re: [PR] [spool] Define equivalence between stages [pinot]

2024-10-29 Thread via GitHub
yashmayya commented on PR #14296: URL: https://github.com/apache/pinot/pull/14296#issuecomment-2444274215 I think this branch needs to be rebased / merged with `master`, all the builds are currently failing (at least one reason seems to be conflict with https://github.com/apache/pinot/pull/

Re: [PR] [spool] Define equivalence between stages [pinot]

2024-10-29 Thread via GitHub
yashmayya commented on code in PR #14296: URL: https://github.com/apache/pinot/pull/14296#discussion_r1820632275 ## pinot-query-planner/src/test/java/org/apache/pinot/query/planner/logical/StagesTestBase.java: ## @@ -0,0 +1,230 @@ +/** + * Licensed to the Apache Software Foundat

Re: [I] Support for S3A Connector [pinot]

2024-10-29 Thread via GitHub
alguiguilo098 commented on issue #14312: URL: https://github.com/apache/pinot/issues/14312#issuecomment-2444181517 @Jackie-Jiang @mayankshriv help me contribute to this community -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [I] Support for S3A Connector [pinot]

2024-10-29 Thread via GitHub
alguiguilo098 commented on issue #14312: URL: https://github.com/apache/pinot/issues/14312#issuecomment-2444163368 @chrajeshbabu Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Add optional 5th parameter - bucketing time zone - to dateTimeConvet() function [pinot]

2024-10-29 Thread via GitHub
bziobrowski commented on code in PR #14298: URL: https://github.com/apache/pinot/pull/14298#discussion_r1820433444 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/transformer/datetime/BaseDateTimeTransformer.java: ## @@ -58,41 +74,145 @@ public BaseDateTimeT

Re: [PR] Add optional 5th parameter - bucketing time zone - to dateTimeConvet() function [pinot]

2024-10-29 Thread via GitHub
bziobrowski commented on code in PR #14298: URL: https://github.com/apache/pinot/pull/14298#discussion_r1820370579 ## pinot-perf/src/main/java/org/apache/pinot/perf/LazyDataList.java: ## @@ -0,0 +1,163 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [I] sum-up: things older java versions are blocking [pinot]

2024-10-29 Thread via GitHub
gortiz commented on issue #14325: URL: https://github.com/apache/pinot/issues/14325#issuecomment-2444016421 Also notice that it may be acceptable to increase the minimum Java runtime version for Pinot processes (servers, brokers, controllers and minions), but increasing the minimum version

Re: [PR] Rename multi-stage engine's explain asking servers to explain include segment plan [pinot]

2024-10-29 Thread via GitHub
yashmayya commented on PR #14193: URL: https://github.com/apache/pinot/pull/14193#issuecomment-2443660379 I think that might be a good option given the proliferation of the different kinds of explain plans in Pinot. But we should probably discuss and come to a consensus on the best way forw

Re: [I] sum-up: things older java versions are blocking [pinot]

2024-10-29 Thread via GitHub
gortiz commented on issue #14325: URL: https://github.com/apache/pinot/issues/14325#issuecomment-2444003219 You can add https://github.com/apache/pinot/issues/12809 (although it requires Java 22). IMHO the target should not be to drop Java < 21 support but start using multi-release j

Re: [PR] Bump software.amazon.awssdk:bom from 2.29.0 to 2.29.1 [pinot]

2024-10-29 Thread via GitHub
dependabot[bot] closed pull request #14314: Bump software.amazon.awssdk:bom from 2.29.0 to 2.29.1 URL: https://github.com/apache/pinot/pull/14314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

(pinot) branch dependabot/maven/com.fasterxml.jackson-jackson-bom-2.18.1 created (now d183494f36)

2024-10-29 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.fasterxml.jackson-jackson-bom-2.18.1 in repository https://gitbox.apache.org/repos/asf/pinot.git at d183494f36 Bump com.fasterxml.jackson:jackson-bom from 2.17.2 t

Re: [PR] Bump org.apache.httpcomponents.client5:httpclient5 from 5.3.1 to 5.4 [pinot]

2024-10-29 Thread via GitHub
dependabot[bot] commented on PR #14045: URL: https://github.com/apache/pinot/pull/14045#issuecomment-2443951669 Superseded by #14327. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Bump io.grpc:grpc-bom from 1.68.0 to 1.68.1 [pinot]

2024-10-29 Thread via GitHub
dependabot[bot] opened a new pull request, #14326: URL: https://github.com/apache/pinot/pull/14326 Bumps [io.grpc:grpc-bom](https://github.com/grpc/grpc-java) from 1.68.0 to 1.68.1. Release notes Sourced from https://github.com/grpc/grpc-java/releases";>io.grpc:grpc-bom's releases

(pinot) branch dependabot/maven/com.azure-azure-sdk-bom-1.2.29 created (now 4065f9570b)

2024-10-29 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.azure-azure-sdk-bom-1.2.29 in repository https://gitbox.apache.org/repos/asf/pinot.git at 4065f9570b Bump com.azure:azure-sdk-bom from 1.2.28 to 1.2.29 No new rev

[PR] Bump com.azure:azure-sdk-bom from 1.2.28 to 1.2.29 [pinot]

2024-10-29 Thread via GitHub
dependabot[bot] opened a new pull request, #14330: URL: https://github.com/apache/pinot/pull/14330 Bumps [com.azure:azure-sdk-bom](https://github.com/azure/azure-sdk-for-java) from 1.2.28 to 1.2.29. Release notes Sourced from https://github.com/azure/azure-sdk-for-java/releases";>c

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.29.2 created (now 54a3f75561)

2024-10-29 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.29.2 in repository https://gitbox.apache.org/repos/asf/pinot.git at 54a3f75561 Bump software.amazon.awssdk:bom from 2.29.0 to 2.29.2 No n

[PR] Bump software.amazon.awssdk:bom from 2.29.0 to 2.29.2 [pinot]

2024-10-29 Thread via GitHub
dependabot[bot] opened a new pull request, #14329: URL: https://github.com/apache/pinot/pull/14329 Bumps software.amazon.awssdk:bom from 2.29.0 to 2.29.2. Most Recent Ignore Conditions Applied to This Pull Request | Dependency Name | Ignore Conditions | | --- | --- | |

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.29.1 deleted (was f82e73bf67)

2024-10-29 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.29.1 in repository https://gitbox.apache.org/repos/asf/pinot.git was f82e73bf67 Bump software.amazon.awssdk:bom from 2.29.0 to 2.29.1 The

Re: [PR] Bump software.amazon.awssdk:bom from 2.29.0 to 2.29.1 [pinot]

2024-10-29 Thread via GitHub
dependabot[bot] commented on PR #14314: URL: https://github.com/apache/pinot/pull/14314#issuecomment-2443954329 Superseded by #14329. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bump com.fasterxml.jackson:jackson-bom from 2.17.2 to 2.18.0 [pinot]

2024-10-29 Thread via GitHub
dependabot[bot] closed pull request #14101: Bump com.fasterxml.jackson:jackson-bom from 2.17.2 to 2.18.0 URL: https://github.com/apache/pinot/pull/14101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

(pinot) branch dependabot/maven/com.fasterxml.jackson-jackson-bom-2.18.0 deleted (was f22f36ecac)

2024-10-29 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.fasterxml.jackson-jackson-bom-2.18.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was f22f36ecac Bump com.fasterxml.jackson:jackson-bom from 2.17.2 t

[PR] Bump com.fasterxml.jackson:jackson-bom from 2.17.2 to 2.18.1 [pinot]

2024-10-29 Thread via GitHub
dependabot[bot] opened a new pull request, #14328: URL: https://github.com/apache/pinot/pull/14328 Bumps [com.fasterxml.jackson:jackson-bom](https://github.com/FasterXML/jackson-bom) from 2.17.2 to 2.18.1. Commits https://github.com/FasterXML/jackson-bom/commit/ef33ac77e148ad5

Re: [PR] Bump com.fasterxml.jackson:jackson-bom from 2.17.2 to 2.18.0 [pinot]

2024-10-29 Thread via GitHub
dependabot[bot] commented on PR #14101: URL: https://github.com/apache/pinot/pull/14101#issuecomment-2443953181 Superseded by #14328. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

(pinot) branch dependabot/maven/org.apache.httpcomponents.client5-httpclient5-5.4.1 created (now dcbba40b52)

2024-10-29 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.httpcomponents.client5-httpclient5-5.4.1 in repository https://gitbox.apache.org/repos/asf/pinot.git at dcbba40b52 Bump org.apache.httpcomponents.client5:ht

(pinot) branch dependabot/maven/org.apache.httpcomponents.client5-httpclient5-5.4 deleted (was 24b61aa8b3)

2024-10-29 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.httpcomponents.client5-httpclient5-5.4 in repository https://gitbox.apache.org/repos/asf/pinot.git was 24b61aa8b3 Bump org.apache.httpcomponents.client5:http

Re: [PR] Bump org.apache.httpcomponents.client5:httpclient5 from 5.3.1 to 5.4 [pinot]

2024-10-29 Thread via GitHub
dependabot[bot] closed pull request #14045: Bump org.apache.httpcomponents.client5:httpclient5 from 5.3.1 to 5.4 URL: https://github.com/apache/pinot/pull/14045 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[PR] Bump org.apache.httpcomponents.client5:httpclient5 from 5.3.1 to 5.4.1 [pinot]

2024-10-29 Thread via GitHub
dependabot[bot] opened a new pull request, #14327: URL: https://github.com/apache/pinot/pull/14327 Bumps [org.apache.httpcomponents.client5:httpclient5](https://github.com/apache/httpcomponents-client) from 5.3.1 to 5.4.1. Changelog Sourced from https://github.com/apache/httpcompo

(pinot) branch dependabot/maven/io.grpc-grpc-bom-1.68.1 created (now 020cd8d8ad)

2024-10-29 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/io.grpc-grpc-bom-1.68.1 in repository https://gitbox.apache.org/repos/asf/pinot.git at 020cd8d8ad Bump io.grpc:grpc-bom from 1.68.0 to 1.68.1 No new revisions were add

Re: [PR] Rename multi-stage engine's explain asking servers to explain include segment plan [pinot]

2024-10-29 Thread via GitHub
gortiz commented on PR #14193: URL: https://github.com/apache/pinot/pull/14193#issuecomment-2443946252 My suggestion is to modify the parser in order to support our different modes. It would be something like: - `EXPLAIN PLAN SEGMENT [INFO] FOR` _always_ shows the plan asking segments.

Re: [PR] Add optional 5th parameter - bucketing time zone - to dateTimeConvet() function [pinot]

2024-10-29 Thread via GitHub
bziobrowski commented on code in PR #14298: URL: https://github.com/apache/pinot/pull/14298#discussion_r1820514060 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DateTimeConvert.java: ## @@ -83,4 +99,67 @@ public Object dateTimeConvert(String timeValueStr,

Re: [PR] Add optional 5th parameter - bucketing time zone - to dateTimeConvet() function [pinot]

2024-10-29 Thread via GitHub
bziobrowski commented on code in PR #14298: URL: https://github.com/apache/pinot/pull/14298#discussion_r1820512853 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DateTimeConvert.java: ## @@ -42,36 +51,43 @@ public Object dateTimeConvert(String timeValueStr

Re: [I] Using SIMD for dealing with json (and more) at speed [pinot]

2024-10-29 Thread via GitHub
hpvd commented on issue #13773: URL: https://github.com/apache/pinot/issues/13773#issuecomment-2443708272 as expected, lucene changes requirements and v10 now requires Java 21, see https://lucene.apache.org/core/corenews.html#apache-lucenetm-1000-available -- This is an automated message

Re: [I] Using SIMD for dealing with json (and more) at speed [pinot]

2024-10-29 Thread via GitHub
hpvd commented on issue #13773: URL: https://github.com/apache/pinot/issues/13773#issuecomment-2443719224 just started a list to get an overview of things we are missing with staying using/being compatible to older Java versions, and determine the right point of time when its maybe worth

Re: [PR] Add optional 5th parameter - bucketing time zone - to dateTimeConvet() function [pinot]

2024-10-29 Thread via GitHub
bziobrowski commented on code in PR #14298: URL: https://github.com/apache/pinot/pull/14298#discussion_r1820433444 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/transformer/datetime/BaseDateTimeTransformer.java: ## @@ -58,41 +74,145 @@ public BaseDateTimeT

Re: [PR] Add optional 5th parameter - bucketing time zone - to dateTimeConvet() function [pinot]

2024-10-29 Thread via GitHub
bziobrowski commented on code in PR #14298: URL: https://github.com/apache/pinot/pull/14298#discussion_r1820443353 ## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DateTimeConvert.java: ## @@ -42,36 +51,43 @@ public Object dateTimeConvert(String timeValueStr

Re: [I] Lucene 9.12.0 upgrade [pinot]

2024-10-29 Thread via GitHub
hpvd commented on issue #14232: URL: https://github.com/apache/pinot/issues/14232#issuecomment-2443690848 added this topic to https://github.com/apache/pinot/issues/14325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Add optional 5th parameter - bucketing time zone - to dateTimeConvet() function [pinot]

2024-10-29 Thread via GitHub
bziobrowski commented on code in PR #14298: URL: https://github.com/apache/pinot/pull/14298#discussion_r1820409748 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/transformer/datetime/BaseDateTimeTransformer.java: ## @@ -42,14 +46,26 @@ public abstract class

Re: [PR] Add optional 5th parameter - bucketing time zone - to dateTimeConvet() function [pinot]

2024-10-29 Thread via GitHub
bziobrowski commented on code in PR #14298: URL: https://github.com/apache/pinot/pull/14298#discussion_r1820409748 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/transformer/datetime/BaseDateTimeTransformer.java: ## @@ -42,14 +46,26 @@ public abstract class

Re: [PR] Add optional 5th parameter - bucketing time zone - to dateTimeConvet() function [pinot]

2024-10-29 Thread via GitHub
bziobrowski commented on code in PR #14298: URL: https://github.com/apache/pinot/pull/14298#discussion_r1820408382 ## pinot-common/src/main/java/org/apache/pinot/common/function/TransformFunctionType.java: ## @@ -115,8 +115,14 @@ public enum TransformFunctionType { // Date ti

  1   2   >