bziobrowski commented on code in PR #14298:
URL: https://github.com/apache/pinot/pull/14298#discussion_r1820443353
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DateTimeConvert.java:
##########
@@ -42,36 +51,43 @@ public Object dateTimeConvert(String timeValueStr, String
inputFormatStr, String
_inputFormatSpec = new DateTimeFormatSpec(inputFormatStr);
_outputFormatSpec = new DateTimeFormatSpec(outputFormatStr);
_granularitySpec = new DateTimeGranularitySpec(outputGranularityStr);
+ _dateTime = new MutableDateTime(0L, DateTimeZone.UTC);
+ _buffer = new StringBuilder();
Review Comment:
As an implementation detail, I don't think it should go into javadoc. If
needed I can add some regular comments though.
I think it'd be more effective to go through codebase and fix places that
utilize joda-time inefficiently (e.g. in DateTimeFunctions class) to eradicate
bad pattern(s).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
