Jackie-Jiang commented on code in PR #14333:
URL: https://github.com/apache/pinot/pull/14333#discussion_r1821611903
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformerTest.java:
##########
@@ -244,6 +244,22 @@ public void testUnnestCollection() {
Assert.assertEquals("v4", next.getValue("array.array2.b"));
next = itr.next();
Assert.assertEquals("v2", next.getValue("array.a"));
+
+ transformer = new ComplexTypeTransformer(Arrays.asList("array"), ".");
+ genericRow = new GenericRow();
+ genericRow.putValue("array", array);
+ map1.put("array2", array2);
+ map2.put("array2", new Object[]{});
+ transformer.transform(genericRow);
+ Assert.assertNotNull(genericRow.getValue(GenericRow.MULTIPLE_RECORDS_KEY));
+ collection = (Collection<GenericRow>)
genericRow.getValue(GenericRow.MULTIPLE_RECORDS_KEY);
+ Assert.assertEquals(2, collection.size());
Review Comment:
Reverse the actual and expected, same for other places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
