bziobrowski commented on code in PR #14298:
URL: https://github.com/apache/pinot/pull/14298#discussion_r1820514060
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DateTimeConvert.java:
##########
@@ -83,4 +99,67 @@ public Object dateTimeConvert(String timeValueStr, String
inputFormatStr, String
return _outputFormatSpec.fromMillisToFormat(roundedTimeValueMs);
}
}
+
+ @ScalarFunction
+ public Object dateTimeConvert(String timeValueStr, String inputFormatStr,
String outputFormatStr,
Review Comment:
I kept two methods but extracted common bits into helper functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
