yashmayya commented on PR #14193: URL: https://github.com/apache/pinot/pull/14193#issuecomment-2443660379
I think that might be a good option given the proliferation of the different kinds of explain plans in Pinot. But we should probably discuss and come to a consensus on the best way forward here since there will be a lot more combinations possible with query options - i.e., different `explainMode` with `EXPLAIN PLAN`, `EXPLAIN IMPLEMENTATION PLAN`, `EXPLAIN PLAN WITH IMPLEMENTATION`, `EXPLAIN PLAN WITHOUT IMPLEMENTATION`. This can end up being super confusing for users if we aren't careful here - I'd suggest dropping support for at least `EXPLAIN IMPLEMENTATION PLAN` and putting that plan under something like `explainMode=workers` instead (assuming we decide upon that user facing terminology [here](https://app.gitbook.com/o/-LtRX9NwSr7Ga7zA4piL/s/-LtH6nl58DdnZnelPdTc-887967055/~/changes/2016/users/user-guide-query/explain-plan/~/comments/YBJ708T3UYdPVfigc3DF?node=hjPfjuYhajC7)). And maybe we can call out explicitly that `explainMode` can only be used with `EXPLAIN PLAN` - `EXPLAIN PLAN WITHOUT IMPLEMENTATION` will always return the basic logical plan without segment level info. Although things will still be a little tricky since `EXPLAIN PLAN` and `EXPLAIN PLAN WITH IMPLEMENTATION` are equivalent - what do we do when `explainMode` asks for logical plan without segment level info but is used with `EXPLAIN PLAN WITH IMPLEMENTATION`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
