bziobrowski commented on code in PR #14298:
URL: https://github.com/apache/pinot/pull/14298#discussion_r1820409748
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/transformer/datetime/BaseDateTimeTransformer.java:
##########
@@ -42,14 +46,26 @@ public abstract class BaseDateTimeTransformer<I, O>
implements DataTransformer<I
private final DateTimeFormatter _outputDateTimeFormatter;
private final DateTimeGranularitySpec _outputGranularity;
private final long _outputGranularityMillis;
- private final SDFDateTimeTruncate _dateTimeTruncate;
+ private final SDFDateTimeTruncate _sdfDateTimeTruncate;
+ private final MillisDateTimeTruncate _millisDateTimeTruncate;
+ private final Chronology _bucketingChronology;
+ private final MutableDateTime _dateTime;
+ private final StringBuilder _printBuffer;
private interface SDFDateTimeTruncate {
- String truncate(DateTime dateTime);
+ String truncate(MutableDateTime dateTime);
}
- public BaseDateTimeTransformer(@Nonnull DateTimeFormatSpec inputFormat,
@Nonnull DateTimeFormatSpec outputFormat,
- @Nonnull DateTimeGranularitySpec outputGranularity) {
+ private interface MillisDateTimeTruncate {
+ long truncate(MutableDateTime dateTime);
+ }
+
+ public BaseDateTimeTransformer(
+ @Nonnull DateTimeFormatSpec inputFormat,
Review Comment:
Ok. These parameters were Nonnull in master already. Should I get rid of the
annotations ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
