[GitHub] [pinot] codecov-commenter commented on pull request #9810: Default column handling of noForwardIndex and regeneration of forward index on reload path

codecov-commenter commented on PR #9810: URL: https://github.com/apache/pinot/pull/9810#issuecomment-1316534403 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9810?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] somandal opened a new pull request, #9810: Handle forward index disabled default columns and add support to enable the forward index on a forward index disabled column

somandal opened a new pull request, #9810: URL: https://github.com/apache/pinot/pull/9810 Related OSS Issue: https://github.com/apache/pinot/issues/6473 Related OSS PRs: https://github.com/apache/pinot/pull/9333 https://github.com/apache/pinot/pull/9740 Document outlining the

[GitHub] [pinot] snleee commented on a diff in pull request #9800: Adding a consumer lag as metric via a periodic task in controller

snleee commented on code in PR #9800: URL: https://github.com/apache/pinot/pull/9800#discussion_r1023558425 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/RealtimeConsumerMonitor.java: ## @@ -0,0 +1,122 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] [pinot] KKcorps commented on issue #9809: Improve the documentation on the new Date Time Formats

KKcorps commented on issue #9809: URL: https://github.com/apache/pinot/issues/9809#issuecomment-1316427380 Cool, Will do that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [pinot] snleee commented on issue #9809: Improve the documentation on the new Date Time Formats

snleee commented on issue #9809: URL: https://github.com/apache/pinot/issues/9809#issuecomment-1316426126 @KKcorps Can you take a look into this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pinot] snleee opened a new issue, #9809: Improve the documentation on the new Date Time Formats

snleee opened a new issue, #9809: URL: https://github.com/apache/pinot/issues/9809 From 0.11.0, we have adopted the new date time formats (https://github.com/apache/pinot/pull/9378). We do have the documentations regarding to the new format; however, our schema examples are still outdated.

[GitHub] [pinot] npawar commented on issue #9417: Connection with Kafka successfully but the query is not showing the topic data

npawar commented on issue #9417: URL: https://github.com/apache/pinot/issues/9417#issuecomment-1316418080 Closing this issue for now. Please reopen if issue persists and debugging steps provided by @navina don't help -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pinot] npawar closed issue #9417: Connection with Kafka successfully but the query is not showing the topic data

npawar closed issue #9417: Connection with Kafka successfully but the query is not showing the topic data URL: https://github.com/apache/pinot/issues/9417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pinot] codecov-commenter commented on pull request #9808: [Draft] [multistage] Add Multi Stage Routing Strategy

codecov-commenter commented on PR #9808: URL: https://github.com/apache/pinot/pull/9808#issuecomment-1316397830 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9808?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] walterddr commented on a diff in pull request #9806: [multistage] add big_decimal support and numeric type tests

walterddr commented on code in PR #9806: URL: https://github.com/apache/pinot/pull/9806#discussion_r1023421438 ## pinot-query-runtime/src/test/resources/queries/NumericTypes.json: ## @@ -0,0 +1,117 @@ +{ + "smallint": { +"psql": "8.1.1", +"ignored": true, +"comment"

[GitHub] [pinot] codecov-commenter commented on pull request #9807: [multistage] split out leaf stage operator

codecov-commenter commented on PR #9807: URL: https://github.com/apache/pinot/pull/9807#issuecomment-1316199797 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9807?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] drawal1 commented on issue #9793: Dead server and broker exist in ideal state - stopping kafka topic ingestion and leaving all tables in bad state

drawal1 commented on issue #9793: URL: https://github.com/apache/pinot/issues/9793#issuecomment-1316184100 This is not related to Kafka retention/cleanup, it happens any time servers/brokers/controllers die and new ones take their place. Two issues - why are the servers/controllers/brokers

[GitHub] [pinot] walterddr commented on a diff in pull request #9806: [multistage] add big_decimal support and numeric type tests

walterddr commented on code in PR #9806: URL: https://github.com/apache/pinot/pull/9806#discussion_r1023422131 ## pinot-query-runtime/src/test/resources/queries/NumericTypes.json: ## @@ -0,0 +1,117 @@ +{ + "smallint": { +"psql": "8.1.1", +"ignored": true, +"comment"

[GitHub] [pinot] walterddr commented on a diff in pull request #9782: [multistage][test] add join queries

walterddr commented on code in PR #9782: URL: https://github.com/apache/pinot/pull/9782#discussion_r1023420001 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/LeafStageTransferableBlockOperator.java: ## @@ -0,0 +1,120 @@ +package org.apache.pinot.que

[GitHub] [pinot] walterddr commented on a diff in pull request #9782: [multistage][test] add join queries

walterddr commented on code in PR #9782: URL: https://github.com/apache/pinot/pull/9782#discussion_r1023418854 ## pinot-query-runtime/src/test/resources/queries/JoinQuery.json: ## @@ -0,0 +1,200 @@ +{ + "basic_join_queries": { Review Comment: - can you clarify join on diffe

[GitHub] [pinot] walterddr opened a new pull request, #9807: [multistage] split out leaf stage operator

walterddr opened a new pull request, #9807: URL: https://github.com/apache/pinot/pull/9807 type canonicalization is not correct during split block; refactor the logic out to (1) LeafStageDataBlockOperator and (2) not doing implace replacement; -- This is an automated message from the

[GitHub] [pinot] codecov-commenter commented on pull request #9806: [multistage] add big_decimal support and numeric type tests

codecov-commenter commented on PR #9806: URL: https://github.com/apache/pinot/pull/9806#issuecomment-1316121968 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9806?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] walterddr commented on a diff in pull request #9782: [multistage][test] add join queries

walterddr commented on code in PR #9782: URL: https://github.com/apache/pinot/pull/9782#discussion_r1023401183 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/LeafStageTransferableBlockOperator.java: ## @@ -0,0 +1,120 @@ +package org.apache.pinot.que

[GitHub] [pinot] walterddr commented on a diff in pull request #9782: [multistage][test] add join queries

walterddr commented on code in PR #9782: URL: https://github.com/apache/pinot/pull/9782#discussion_r1023400979 ## pinot-query-runtime/src/test/resources/queries/JoinQuery.json: ## @@ -0,0 +1,200 @@ +{ + "basic_join_queries": { Review Comment: Sound good will add. -- Th

[GitHub] [pinot] 61yao commented on a diff in pull request #9806: [multistage] add big_decimal support and numeric type tests

61yao commented on code in PR #9806: URL: https://github.com/apache/pinot/pull/9806#discussion_r1023389693 ## pinot-query-planner/src/main/java/org/apache/pinot/query/type/TypeFactory.java: ## @@ -70,6 +70,8 @@ private RelDataType toRelDataType(FieldSpec fieldSpec) { re

[GitHub] [pinot] 61yao commented on a diff in pull request #9806: [multistage] add big_decimal support and numeric type tests

61yao commented on code in PR #9806: URL: https://github.com/apache/pinot/pull/9806#discussion_r1023391132 ## pinot-query-planner/src/main/java/org/apache/pinot/query/type/TypeFactory.java: ## @@ -70,6 +70,8 @@ private RelDataType toRelDataType(FieldSpec fieldSpec) { re

[GitHub] [pinot] 61yao commented on a diff in pull request #9806: [multistage] add big_decimal support and numeric type tests

61yao commented on code in PR #9806: URL: https://github.com/apache/pinot/pull/9806#discussion_r1023389693 ## pinot-query-planner/src/main/java/org/apache/pinot/query/type/TypeFactory.java: ## @@ -70,6 +70,8 @@ private RelDataType toRelDataType(FieldSpec fieldSpec) { re

[GitHub] [pinot] 61yao commented on a diff in pull request #9806: [multistage] add big_decimal support and numeric type tests

61yao commented on code in PR #9806: URL: https://github.com/apache/pinot/pull/9806#discussion_r1023389693 ## pinot-query-planner/src/main/java/org/apache/pinot/query/type/TypeFactory.java: ## @@ -70,6 +70,8 @@ private RelDataType toRelDataType(FieldSpec fieldSpec) { re

[GitHub] [pinot] agavra commented on a diff in pull request #9782: [multistage][test] add join queries

agavra commented on code in PR #9782: URL: https://github.com/apache/pinot/pull/9782#discussion_r1023383006 ## pinot-query-runtime/src/test/resources/queries/JoinQuery.json: ## @@ -0,0 +1,200 @@ +{ + "basic_join_queries": { Review Comment: hmm, I thought I left this somewhe

[GitHub] [pinot] agavra opened a new pull request, #9806: [multistage] add big_decimal support and numeric type tests

agavra opened a new pull request, #9806: URL: https://github.com/apache/pinot/pull/9806 1. add support for `BIG_DECIMAL` in the multistage engine 2. add some tests for numeric types - most of the interesting tests for numeric types will be done per-operator (+, -, %, etc...) this just cov

[GitHub] [pinot] 61yao commented on a diff in pull request #9782: [multistage][test] add join queries

61yao commented on code in PR #9782: URL: https://github.com/apache/pinot/pull/9782#discussion_r1023375331 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/LeafStageTransferableBlockOperator.java: ## @@ -0,0 +1,120 @@ +package org.apache.pinot.query.r

[GitHub] [pinot] walterddr commented on a diff in pull request #9782: [multistage][test] add join queries

walterddr commented on code in PR #9782: URL: https://github.com/apache/pinot/pull/9782#discussion_r1023369993 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/operands/FilterOperand.java: ## @@ -230,6 +230,7 @@ public Predicate(List functionOperands,

[GitHub] [pinot] walterddr commented on a diff in pull request #9782: [multistage][test] add join queries

walterddr commented on code in PR #9782: URL: https://github.com/apache/pinot/pull/9782#discussion_r1023369641 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/LeafStageTransferableBlockOperator.java: ## @@ -0,0 +1,120 @@ +package org.apache.pinot.que

[GitHub] [pinot] mcvsubbu commented on pull request #9800: Adding a consumer lag as metric via a periodic task in controller

mcvsubbu commented on PR #9800: URL: https://github.com/apache/pinot/pull/9800#issuecomment-1315994609 > > We can make this an opt-in periodic task. I added it as a separate task to have better control over the frequency of this task. > > This is a useful metric to have. Ideally we'd

[GitHub] [pinot] mcvsubbu commented on pull request #9800: Adding a consumer lag as metric via a periodic task in controller

mcvsubbu commented on PR #9800: URL: https://github.com/apache/pinot/pull/9800#issuecomment-1315993390 > > Moreover, when a table is rebalanced, the consuming segments get moved around. This can lead to prolonged stale value that will mostly cause noise. > > When a table is rebalanced

[GitHub] [pinot] sajjad-moradi commented on pull request #9800: Adding a consumer lag as metric via a periodic task in controller

sajjad-moradi commented on PR #9800: URL: https://github.com/apache/pinot/pull/9800#issuecomment-1315990338 > We can make this an opt-in periodic task. I added it as a separate task to have better control over the frequency of this task. This is a useful metric to have. Ideally we'd w

[GitHub] [pinot] sajjad-moradi commented on pull request #9800: Adding a consumer lag as metric via a periodic task in controller

sajjad-moradi commented on PR #9800: URL: https://github.com/apache/pinot/pull/9800#issuecomment-1315978874 > Moreover, when a table is rebalanced, the consuming segments get moved around. This can lead to prolonged stale value that will mostly cause noise. When a table is rebalanced,

[GitHub] [pinot] walterddr commented on a diff in pull request #9798: [multistage] add tests for lexical structure and value exprs

walterddr commented on code in PR #9798: URL: https://github.com/apache/pinot/pull/9798#discussion_r1023324646 ## pinot-query-runtime/src/test/resources/queries/ValueExpressions.json: ## @@ -0,0 +1,102 @@ +{ + "subscript": { +"psql": "4.2.3", +"ignored": true, +"com

[GitHub] [pinot] walterddr commented on a diff in pull request #9798: [multistage] add tests for lexical structure and value exprs

walterddr commented on code in PR #9798: URL: https://github.com/apache/pinot/pull/9798#discussion_r1023322031 ## pinot-query-runtime/src/test/resources/queries/LexicalStructure.json: ## @@ -0,0 +1,184 @@ +{ + "unquoted_identifiers": { +"tables": { + "tbl": { +

[GitHub] [pinot] agavra commented on a diff in pull request #9798: [multistage] add tests for lexical structure and value exprs

agavra commented on code in PR #9798: URL: https://github.com/apache/pinot/pull/9798#discussion_r1023315898 ## pinot-query-runtime/src/test/resources/queries/ValueExpressions.json: ## @@ -0,0 +1,102 @@ +{ + "subscript": { +"psql": "4.2.3", +"ignored": true, +"commen

[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #9727: Thread Level Usage Accounting and Query Killing on Server

jasperjiaguo commented on code in PR #9727: URL: https://github.com/apache/pinot/pull/9727#discussion_r1023312393 ## pinot-spi/src/main/java/org/apache/pinot/spi/accounting/ThreadAccountant.java: ## @@ -0,0 +1,72 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #9727: Thread Level Usage Accounting and Query Killing on Server

jasperjiaguo commented on code in PR #9727: URL: https://github.com/apache/pinot/pull/9727#discussion_r1023311988 ## pinot-spi/src/main/java/org/apache/pinot/spi/accounting/ThreadAccountantFactory.java: ## @@ -0,0 +1,26 @@ +/** + * Licensed to the Apache Software Foundation (ASF

[GitHub] [pinot] walterddr commented on a diff in pull request #9798: [multistage] add tests for lexical structure and value exprs

walterddr commented on code in PR #9798: URL: https://github.com/apache/pinot/pull/9798#discussion_r1023306211 ## pinot-query-runtime/src/test/resources/queries/LexicalStructure.json: ## @@ -0,0 +1,184 @@ +{ + "unquoted_identifiers": { +"tables": { + "tbl": { +

[GitHub] [pinot] walterddr commented on a diff in pull request #9798: [multistage] add tests for lexical structure and value exprs

walterddr commented on code in PR #9798: URL: https://github.com/apache/pinot/pull/9798#discussion_r1023305536 ## pinot-query-runtime/src/test/resources/queries/ValueExpressions.json: ## @@ -0,0 +1,102 @@ +{ + "subscript": { +"psql": "4.2.3", +"ignored": true, +"com

[GitHub] [pinot] snleee opened a new issue, #9805: Add the support for DefaultAzureCredential

snleee opened a new issue, #9805: URL: https://github.com/apache/pinot/issues/9805 Currently, S3PinotFS implementation falls back to initialize credential using `DefaultCredentialsProvider` when the access key and secret is not provided by the pinot config. In this way, we allow users to se

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #9803: Optimize AdaptiveServerSelection for replicaGroup based routing

vvivekiyer commented on code in PR #9803: URL: https://github.com/apache/pinot/pull/9803#discussion_r1023285220 ## pinot-broker/src/main/java/org/apache/pinot/broker/routing/adaptiveserverselector/LatencySelector.java: ## @@ -79,4 +81,30 @@ public List> fetchAllServerRankingsWi

[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #9727: Thread Level Usage Accounting and Query Killing on Server

jasperjiaguo commented on code in PR #9727: URL: https://github.com/apache/pinot/pull/9727#discussion_r1023259239 ## pinot-spi/src/main/java/org/apache/pinot/spi/accounting/ThreadResourceUsageProvider.java: ## @@ -0,0 +1,145 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #9727: Thread Level Usage Accounting and Query Killing on Server

jasperjiaguo commented on code in PR #9727: URL: https://github.com/apache/pinot/pull/9727#discussion_r1023254019 ## pinot-spi/src/main/java/org/apache/pinot/spi/accounting/ThreadResourceUsageProvider.java: ## @@ -0,0 +1,145 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #9727: Thread Level Usage Accounting and Query Killing on Server

jasperjiaguo commented on code in PR #9727: URL: https://github.com/apache/pinot/pull/9727#discussion_r1023252164 ## pinot-spi/src/main/java/org/apache/pinot/spi/accounting/ThreadResourceUsageProvider.java: ## @@ -0,0 +1,145 @@ +/** + * Licensed to the Apache Software Foundation

[pinot] branch adss-hotfix updated: AdaptiveServerSelection: update response stats for servers that have not responded (#9801)

This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a commit to branch adss-hotfix in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/adss-hotfix by this push: new 6f25fa533a AdaptiveServerSelection:

[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #9727: Thread Level Usage Accounting and Query Killing on Server

jasperjiaguo commented on code in PR #9727: URL: https://github.com/apache/pinot/pull/9727#discussion_r1023251290 ## pinot-spi/src/main/java/org/apache/pinot/spi/accounting/ThreadResourceUsageProvider.java: ## @@ -0,0 +1,145 @@ +/** + * Licensed to the Apache Software Foundation

[pinot] branch adss-hotfix created (now 63c6438d3c)

This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a change to branch adss-hotfix in repository https://gitbox.apache.org/repos/asf/pinot.git at 63c6438d3c Add more test for NonAggregationGroupByToDistinctQueryRewriter (#9616) No new revisions were adde

[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #9727: Thread Level Usage Accounting and Query Killing on Server

jasperjiaguo commented on code in PR #9727: URL: https://github.com/apache/pinot/pull/9727#discussion_r1023248214 ## pinot-spi/src/main/java/org/apache/pinot/spi/accounting/ExecutionContext.java: ## @@ -0,0 +1,34 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[pinot] branch master updated (2987f7ad08 -> 00294bdd93)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 2987f7ad08 [multistage] [testing] Add transform operator unit test (#9791) add 00294bdd93 [multistage] add tests f

[GitHub] [pinot] walterddr merged pull request #9798: [multistage] add tests for lexical structure and value exprs

walterddr merged PR #9798: URL: https://github.com/apache/pinot/pull/9798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

[GitHub] [pinot] walterddr commented on a diff in pull request #9797: fix potential fd leakage for SegmentProcessorFramework

walterddr commented on code in PR #9797: URL: https://github.com/apache/pinot/pull/9797#discussion_r1023207885 ## pinot-core/src/main/java/org/apache/pinot/core/segment/processing/framework/SegmentProcessorFramework.java: ## @@ -142,28 +142,31 @@ public List process() for (

[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #9727: Thread Level Usage Accounting and Query Killing on Server

jasperjiaguo commented on code in PR #9727: URL: https://github.com/apache/pinot/pull/9727#discussion_r1023203104 ## pinot-spi/src/main/java/org/apache/pinot/spi/accounting/ThreadAccountant.java: ## @@ -0,0 +1,72 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #9727: Thread Level Usage Accounting and Query Killing on Server

jasperjiaguo commented on code in PR #9727: URL: https://github.com/apache/pinot/pull/9727#discussion_r1023203104 ## pinot-spi/src/main/java/org/apache/pinot/spi/accounting/ThreadAccountant.java: ## @@ -0,0 +1,72 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[pinot] branch master updated: [multistage] [testing] Add transform operator unit test (#9791)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 2987f7ad08 [multistage] [testing] Add transform op

[GitHub] [pinot] walterddr merged pull request #9791: [multistage] [testing] Add transform operator unit test

walterddr merged PR #9791: URL: https://github.com/apache/pinot/pull/9791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #9727: Thread Level Usage Accounting and Query Killing on Server

jasperjiaguo commented on code in PR #9727: URL: https://github.com/apache/pinot/pull/9727#discussion_r1023191645 ## pinot-spi/src/main/java/org/apache/pinot/spi/accounting/ThreadAccountant.java: ## @@ -0,0 +1,72 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[pinot] branch master updated: [multistage] [testing] Filter Operator Unit Test (#9792)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 7b8c8a0fe8 [multistage] [testing] Filter Operator

[GitHub] [pinot] walterddr merged pull request #9792: [multistage] [testing] Filter Operator Unit Test

walterddr merged PR #9792: URL: https://github.com/apache/pinot/pull/9792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

[GitHub] [pinot] agavra commented on a diff in pull request #9753: [multistage] implement naive round robin operator chain scheduling

agavra commented on code in PR #9753: URL: https://github.com/apache/pinot/pull/9753#discussion_r1023190845 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/OpChain.java: ## @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [pinot] agavra commented on a diff in pull request #9753: [multistage] implement naive round robin operator chain scheduling

agavra commented on code in PR #9753: URL: https://github.com/apache/pinot/pull/9753#discussion_r1023190250 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/OpChain.java: ## @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [pinot] navina commented on pull request #9800: Adding a consumer lag as metric via a periodic task in controller

navina commented on PR #9800: URL: https://github.com/apache/pinot/pull/9800#issuecomment-1315777608 > Why do we need to emit this from the controller? We can aggregate the metrics that is being emitted from the servers, right? > > cc: @sajjad-moradi We could emit metrics from

[GitHub] [pinot] walterddr commented on a diff in pull request #9753: [multistage] implement naive round robin operator chain scheduling

walterddr commented on code in PR #9753: URL: https://github.com/apache/pinot/pull/9753#discussion_r1023187621 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/OpChain.java: ## @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #9727: Thread Level Usage Accounting and Query Killing on Server

jasperjiaguo commented on code in PR #9727: URL: https://github.com/apache/pinot/pull/9727#discussion_r1023186449 ## pinot-spi/src/main/java/org/apache/pinot/spi/accounting/ThreadAccountant.java: ## @@ -0,0 +1,72 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [pinot] 61yao commented on a diff in pull request #9753: [multistage] implement naive round robin operator chain scheduling

61yao commented on code in PR #9753: URL: https://github.com/apache/pinot/pull/9753#discussion_r1023184369 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/OpChain.java: ## @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [pinot] 61yao commented on a diff in pull request #9753: [multistage] implement naive round robin operator chain scheduling

61yao commented on code in PR #9753: URL: https://github.com/apache/pinot/pull/9753#discussion_r1023182998 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/OpChain.java: ## @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [pinot] walterddr commented on a diff in pull request #9753: [multistage] implement naive round robin operator chain scheduling

walterddr commented on code in PR #9753: URL: https://github.com/apache/pinot/pull/9753#discussion_r1023180329 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/OpChainSchedulerService.java: ## @@ -0,0 +1,147 @@ +/** + * Licensed to the Apache Software

[GitHub] [pinot] walterddr commented on a diff in pull request #9753: [multistage] implement naive round robin operator chain scheduling

walterddr commented on code in PR #9753: URL: https://github.com/apache/pinot/pull/9753#discussion_r1023179366 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/OpChainSchedulerService.java: ## @@ -0,0 +1,147 @@ +/** + * Licensed to the Apache Software

[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #9727: Thread Level Usage Accounting and Query Killing on Server

jasperjiaguo commented on code in PR #9727: URL: https://github.com/apache/pinot/pull/9727#discussion_r1023179370 ## pinot-spi/src/main/java/org/apache/pinot/spi/accounting/ThreadAccountant.java: ## @@ -0,0 +1,72 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [pinot] walterddr commented on a diff in pull request #9753: [multistage] implement naive round robin operator chain scheduling

walterddr commented on code in PR #9753: URL: https://github.com/apache/pinot/pull/9753#discussion_r1023178252 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/OpChain.java: ## @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #9727: Thread Level Usage Accounting and Query Killing on Server

jasperjiaguo commented on code in PR #9727: URL: https://github.com/apache/pinot/pull/9727#discussion_r1023171912 ## pinot-spi/src/main/java/org/apache/pinot/spi/accounting/ThreadAccountant.java: ## @@ -0,0 +1,72 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [pinot] walterddr commented on a diff in pull request #9753: [multistage] implement naive round robin operator chain scheduling

walterddr commented on code in PR #9753: URL: https://github.com/apache/pinot/pull/9753#discussion_r1023178252 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/OpChain.java: ## @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [pinot] walterddr commented on a diff in pull request #9753: [multistage] implement naive round robin operator chain scheduling

walterddr commented on code in PR #9753: URL: https://github.com/apache/pinot/pull/9753#discussion_r1023177805 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/OpChain.java: ## @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[pinot] branch master updated: [multistage] implement naive round robin operator chain scheduling (#9753)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 342b6a57b5 [multistage] implement naive round robi

[GitHub] [pinot] walterddr closed issue #9615: Support non-blocking MailboxReceivedOperator

walterddr closed issue #9615: Support non-blocking MailboxReceivedOperator URL: https://github.com/apache/pinot/issues/9615 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [pinot] walterddr merged pull request #9753: [multistage] implement naive round robin operator chain scheduling

walterddr merged PR #9753: URL: https://github.com/apache/pinot/pull/9753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

[GitHub] [pinot] 61yao commented on a diff in pull request #9753: [multistage] implement naive round robin operator chain scheduling

61yao commented on code in PR #9753: URL: https://github.com/apache/pinot/pull/9753#discussion_r1023170742 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/OpChain.java: ## @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [pinot] 61yao commented on a diff in pull request #9753: [multistage] implement naive round robin operator chain scheduling

61yao commented on code in PR #9753: URL: https://github.com/apache/pinot/pull/9753#discussion_r1016131586 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/OpChainSchedulerService.java: ## @@ -0,0 +1,147 @@ +/** + * Licensed to the Apache Software Fou

[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #9727: Thread Level Usage Accounting and Query Killing on Server

jasperjiaguo commented on code in PR #9727: URL: https://github.com/apache/pinot/pull/9727#discussion_r1023171912 ## pinot-spi/src/main/java/org/apache/pinot/spi/accounting/ThreadAccountant.java: ## @@ -0,0 +1,72 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [pinot] codecov-commenter commented on pull request #9791: [multistage] [testing] Add transform operator unit test

codecov-commenter commented on PR #9791: URL: https://github.com/apache/pinot/pull/9791#issuecomment-1315754335 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9791?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9803: Optimize AdaptiveServerSelection for replicaGroup based routing

siddharthteotia commented on code in PR #9803: URL: https://github.com/apache/pinot/pull/9803#discussion_r1023137053 ## pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/ReplicaGroupInstanceSelector.java: ## @@ -156,4 +159,20 @@ private void selectServ

[GitHub] [pinot] 61yao commented on a diff in pull request #9791: [multistage] [testing] Add transform operator unit test

61yao commented on code in PR #9791: URL: https://github.com/apache/pinot/pull/9791#discussion_r1023137348 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/RexExpression.java: ## @@ -206,6 +206,7 @@ class FunctionCall implements RexExpression { pr

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9803: Optimize AdaptiveServerSelection for replicaGroup based routing

siddharthteotia commented on code in PR #9803: URL: https://github.com/apache/pinot/pull/9803#discussion_r1023137053 ## pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/ReplicaGroupInstanceSelector.java: ## @@ -156,4 +159,20 @@ private void selectServ

[GitHub] [pinot] 61yao commented on a diff in pull request #9791: [multistage] [testing] Add transform operator unit test

61yao commented on code in PR #9791: URL: https://github.com/apache/pinot/pull/9791#discussion_r1023135772 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/operator/TransformOperatorTest.java: ## @@ -0,0 +1,246 @@ +/** + * Licensed to the Apache Software Found

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9803: Optimize AdaptiveServerSelection for replicaGroup based routing

siddharthteotia commented on code in PR #9803: URL: https://github.com/apache/pinot/pull/9803#discussion_r1023128025 ## pinot-broker/src/main/java/org/apache/pinot/broker/routing/adaptiveserverselector/LatencySelector.java: ## @@ -79,4 +81,30 @@ public List> fetchAllServerRanki

[GitHub] [pinot] 61yao commented on a diff in pull request #9792: [multistage] [testing] Filter Operator Unit Test

61yao commented on code in PR #9792: URL: https://github.com/apache/pinot/pull/9792#discussion_r1023127605 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/RexExpression.java: ## @@ -204,6 +204,7 @@ public FieldSpec.DataType getDataType() { class Fu

[GitHub] [pinot] 61yao commented on a diff in pull request #9792: [multistage] [testing] Filter Operator Unit Test

61yao commented on code in PR #9792: URL: https://github.com/apache/pinot/pull/9792#discussion_r1023126923 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/RexExpression.java: ## @@ -204,6 +204,7 @@ public FieldSpec.DataType getDataType() { class Fu

[GitHub] [pinot] agavra commented on a diff in pull request #9753: [multistage] implement naive round robin operator chain scheduling

agavra commented on code in PR #9753: URL: https://github.com/apache/pinot/pull/9753#discussion_r1023120921 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/OpChain.java: ## @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [pinot] agavra commented on a diff in pull request #9753: [multistage] implement naive round robin operator chain scheduling

agavra commented on code in PR #9753: URL: https://github.com/apache/pinot/pull/9753#discussion_r1023119856 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/OpChainSchedulerService.java: ## @@ -0,0 +1,147 @@ +/** + * Licensed to the Apache Software Fo

[GitHub] [pinot] walterddr commented on a diff in pull request #9753: [multistage] implement naive round robin operator chain scheduling

walterddr commented on code in PR #9753: URL: https://github.com/apache/pinot/pull/9753#discussion_r1023119137 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/OpChain.java: ## @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [pinot] 61yao commented on a diff in pull request #9778: [multistage] [testing] Mailbox receive operator test

61yao commented on code in PR #9778: URL: https://github.com/apache/pinot/pull/9778#discussion_r1023091276 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MailboxReceiveOperator.java: ## @@ -43,30 +44,47 @@ /** * This {@code MailboxReceiveOperator

[GitHub] [pinot] agavra commented on a diff in pull request #9753: [multistage] implement naive round robin operator chain scheduling

agavra commented on code in PR #9753: URL: https://github.com/apache/pinot/pull/9753#discussion_r1023117128 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/OpChain.java: ## @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #9727: Thread Level Usage Accounting and Query Killing on Server

jasperjiaguo commented on code in PR #9727: URL: https://github.com/apache/pinot/pull/9727#discussion_r1023104361 ## pinot-spi/src/main/java/org/apache/pinot/spi/accounting/ThreadAccountantFactory.java: ## @@ -0,0 +1,26 @@ +/** + * Licensed to the Apache Software Foundation (ASF

[GitHub] [pinot] walterddr commented on a diff in pull request #9753: [multistage] implement naive round robin operator chain scheduling

walterddr commented on code in PR #9753: URL: https://github.com/apache/pinot/pull/9753#discussion_r1023096179 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/OpChain.java: ## @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [pinot] walterddr commented on a diff in pull request #9753: [multistage] implement naive round robin operator chain scheduling

walterddr commented on code in PR #9753: URL: https://github.com/apache/pinot/pull/9753#discussion_r1023086131 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/OpChain.java: ## @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #9727: Thread Level Usage Accounting and Query Killing on Server

jasperjiaguo commented on code in PR #9727: URL: https://github.com/apache/pinot/pull/9727#discussion_r1023080741 ## pinot-spi/src/main/java/org/apache/pinot/spi/accounting/ThreadResourceUsageProvider.java: ## @@ -0,0 +1,145 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] [pinot] agavra commented on a diff in pull request #9792: [multistage] [testing] Filter Operator Unit Test

agavra commented on code in PR #9792: URL: https://github.com/apache/pinot/pull/9792#discussion_r1023016701 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/operator/FilterOperatorTest.java: ## @@ -0,0 +1,212 @@ + + +package org.apache.pinot.query.runtime.oper

[pinot] branch master updated: [multistage] add test for LiteralValueOperator (#9796)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 47c8f18436 [multistage] add test for LiteralValueO

[GitHub] [pinot] walterddr merged pull request #9796: [multistage] add test for LiteralValueOperator

walterddr merged PR #9796: URL: https://github.com/apache/pinot/pull/9796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

[GitHub] [pinot] walterddr commented on a diff in pull request #9796: [multistage] add test for LiteralValueOperator

walterddr commented on code in PR #9796: URL: https://github.com/apache/pinot/pull/9796#discussion_r1023011717 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/operator/LiteralValueOperatorTest.java: ## @@ -0,0 +1,57 @@ +/** + * Licensed to the Apache Software

[GitHub] [pinot] walterddr commented on a diff in pull request #9791: [multistage] [testing] Add transform operator unit test

walterddr commented on code in PR #9791: URL: https://github.com/apache/pinot/pull/9791#discussion_r1022998768 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/RexExpression.java: ## @@ -206,6 +206,7 @@ class FunctionCall implements RexExpression {

  1   2   >